Skip to content
This repository was archived by the owner on Mar 31, 2025. It is now read-only.

Do not require the whole gem inside the gemspec - #8

Merged
UltiMich merged 1 commit into
makerbot:masterfrom
cults:do-not-require-gems-in-gemspec
Jun 7, 2024
Merged

Do not require the whole gem inside the gemspec#8
UltiMich merged 1 commit into
makerbot:masterfrom
cults:do-not-require-gems-in-gemspec

Conversation

@sunny

@sunnysunny commented Jan 30, 2023

Copy link
Copy Markdown
Contributor

It is bad practice to require the whole gem and its dependencies inside the gemspec that defines these dependencies 🙃

This is a fix that only requires the version.

@sunnysunny changed the title Gemspec: Do not require the whole gem inside the gemspec 💎Do not require the whole gem inside the gemspecJan 30, 2023
ook
ook approved these changes Jan 30, 2023
@sunnysunny mentioned this pull request Feb 20, 2024
2 tasks
@UltiMich
UltiMich merged commit a921f17 into makerbot:masterJun 7, 2024
@sunny
sunny deleted the do-not-require-gems-in-gemspec branch June 8, 2024 07:19
@sunny

Copy link
Copy Markdown
ContributorAuthor

Thanks for the merge \o/

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@sunny@ook@UltiMich