feat(acp): include thread root kind in context - #10
Conversation
Signed-off-by: evgeniy.chernomortsev <j.malkovitc@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8996ab74e0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| messages, | ||
| total, | ||
| truncated, | ||
| root_kind, |
There was a problem hiding this comment.
Preserve root kind when the context delta is empty
On a subsequent turn in the same thread, the fetched root and prior replies are commonly all in delivered, while the new reply is in triggering; filtering therefore leaves no messages and the then_some discards the entire context, including the newly captured root_kind. The resulting [Context] omits Thread root kind precisely after history has already been delivered, so this metadata should be carried independently of whether any context messages remain.
Useful? React with 👍 / 👎.
Summary
Thread root kindin the agent's[Context]block for Forum and stream threadsThis is the minimal context slice from upstream block#3596. Setup nudges, dead-letter publication, CLI-wide reply classification, and broad filter refactors are intentionally deferred as separate work.
Verification
cargo test -p buzz-acp --lib— 819 passedcargo clippy -p buzz-acp --all-targets -- -D warningscargo fmt --all -- --checkgit diff --check