Skip to content

feat(acp): include thread root kind in context - #10

Merged
malkovitc merged 1 commit into
mainfrom
feat/acp-root-kind-context
Aug 26, 2026
Merged

malkovitc merged 1 commit into
mainfrom
feat/acp-root-kind-context

Conversation

@malkovitc

Copy link
Copy Markdown
Owner

Summary

  • retain the fetched thread root event kind in ACP conversation context
  • expose Thread root kind in the agent's [Context] block for Forum and stream threads
  • include Forum comments and stream diffs in thread reply/history/count queries
  • preserve root-kind metadata when delivery dedup filters prior context

This is the minimal context slice from upstream block#3596. Setup nudges, dead-letter publication, CLI-wide reply classification, and broad filter refactors are intentionally deferred as separate work.

Verification

  • cargo test -p buzz-acp --lib — 819 passed
  • cargo clippy -p buzz-acp --all-targets -- -D warnings
  • cargo fmt --all -- --check
  • file-size ratchet and git diff --check

Signed-off-by: evgeniy.chernomortsev <j.malkovitc@gmail.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8996ab74e0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

messages,
total,
truncated,
root_kind,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve root kind when the context delta is empty

On a subsequent turn in the same thread, the fetched root and prior replies are commonly all in delivered, while the new reply is in triggering; filtering therefore leaves no messages and the then_some discards the entire context, including the newly captured root_kind. The resulting [Context] omits Thread root kind precisely after history has already been delivered, so this metadata should be carried independently of whether any context messages remain.

Useful? React with 👍 / 👎.

@malkovitc
malkovitc merged commit 96c9bdd into main Aug 26, 2026
@malkovitc
malkovitc deleted the feat/acp-root-kind-context branch August 26, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant