Skip to content

Spaces in CWD cause pipes to fail #181

Description

@masaccio

If the current working directory has spaces in it, the pstats to pipe will fail as the variables are not quoted. The pipes library correctly quotes the assignment of IN and OUT but the command needs to quote them:

t.append("{} -f pstats \"$IN\"".format(self.gprof2dot), "f-")
t.append("dot -Tsvg -o \"$OUT\"", "-f")

Of course that will fail if there is a double quote in the current path, so an alternative would be temporary files or doing the interprocess plumbing but the quoting above does at least solve the situation where somebody is working in a directory with a space somewhere on the path.

Working in a symlink path doesn't help (which is what I do) as os.path resolves the path to its actual path in the filesystem.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions