Skip to content

Runtime plugin pattern: KnownSubTypeOf, RegisterSubtypeAssembly, RegisterDynamicSubtype - #211

Open
manuc66 wants to merge 5 commits into
feature/split/pr4-migration-fixesfrom
feature/split/pr5-plugin-pattern
Open

Runtime plugin pattern: KnownSubTypeOf, RegisterSubtypeAssembly, RegisterDynamicSubtype#211
manuc66 wants to merge 5 commits into
feature/split/pr4-migration-fixesfrom
feature/split/pr5-plugin-pattern

Conversation

@manuc66

@manuc66manuc66 commented Aug 16, 2026

Copy link
Copy Markdown
Owner

Problem

Runtime-loaded subtypes (plugins, assemblies loaded at runtime, config-driven types) could not self-declare in the STJ engine: the only cross-assembly mechanism was a process-wide assembly registry, and per-subtype runtime registration did not exist.

Fix

  • Replace the global JsonSubTypesTypeResolution.AddAssembly registry with a declarative [KnownSubTypeOtherAssembly("AssemblyName")] attribute on the base type (per-type, no process-wide leak; no compile-time reference to the plugin).
  • Add self-declaring subtypes via KnownSubTypeOf (with discriminator value or by type name) and KnownSubTypeWithPropertyOf (by property presence).
  • Add RegisterSubtypeAssembly(assembly) to scan a loaded assembly for those declarations.
  • Add RegisterDynamicSubtype(discriminator, type) to register a single subtype directly after the converter is built.
  • New JsonSubTypes.Text.Json.Tests.Plugin test project.

Tests

  • New plugin/self-declaring tests across STJ suites; full STJ suite passes (net8.0 and net10.0).

Honest note(s)

  • The generator cannot see runtime-loaded hierarchies; the converter is the only engine for them (documented in the README plugin section, added in a later PR).
  • RegisterDynamicSubtype mutates the mapping and is intended for setup time, not concurrent use with serialization.

@manuc66
Replace the global assembly registry with a declarative JsonSubTypesT…
c491827
…ypeResolution attribute
JsonSubTypesTypeResolution.AddAssembly was a process-wide mutable registry that
leaked state across serialization profiles. Replace it with
[JsonSubTypesTypeResolution("AssemblyName")] on the base type, cached per type.
The attribute takes an assembly name rather than a Type: a Type would force the
base to reference the plugin assembly, which together with the plugin's reference
to the base creates a project cycle. Naming the assembly keeps the base free of a
compile-time reference to the plugin.
The cross-assembly tests now use SharedAnimal (base) with the plugin assembly
declared on it and PluginDog (in the plugin project) resolved by name, plus a
negative test on a base without the attribute.
@manuc66
Rename JsonSubTypesTypeResolution to KnownSubTypeOtherAssembly
b99e25b
The attribute's previous name was inherited from the global AddAssembly registry
it replaced and said nothing about its contract. KnownSubTypeOtherAssembly is a
noun consistent with the KnownSubType family, and Other carries the extension
beyond the base type's own assembly. The file follows the class name.
@manuc66
Add the self-declaring plugin pattern via KnownSubTypeOf and Register…
102b079
…SubtypeAssembly
Support the inverse philosophy of the base-declares approach: the subtype declares
itself as a child of the base through [KnownSubTypeOf(typeof(Base), "value")],
and the host registers the plugin assembly at runtime through
RegisterSubtypeAssembly. This covers the real plugin scenario the attribute
cannot: assemblies loaded at runtime whose names are unknown at compile time.
The scan mirrors the runtime cross-assembly approach: register the assembly, scan
its types for self-declared subtypes, and map those that carry a discriminator
value; types without a value resolve by name in the registered assembly.
ReflectionTypeLoadException is handled so an assembly with unloadable optional
types is not fatal. Both philosophies coexist: the base can still name other
assemblies via [KnownSubTypeOtherAssembly].
@manuc66
Add RegisterDynamicSubtype to the runtime converter
cb6db9a
The generator already exposed RegisterDynamicSubtype, but the runtime converter
did not: README claimed parity that did not exist. Add the same runtime hook to
JsonSubtypes<T>, mapping a discriminator to a subtype after the converter is
built, with last-registration-wins like the generator. This covers the simple
plugin need (register a subtype at runtime) without editing the plugin or
scanning an assembly, complementing RegisterSubtypeAssembly.
NullableDictionary gains a Set method for the overwrite semantics.
@manuc66
Add self-declared subtypes by property presence via KnownSubTypeWithP…
0a878d2
…ropertyOf
Mirror the KnownSubTypeOf work for property-presence discrimination. The subtype
declares itself through [KnownSubTypeWithPropertyOf(typeof(Base), "Property")]
and JsonSubtypesWithPropertyConverterBuilder.RegisterSubtypeAssembly scans the
registered assembly for those declarations, mapping the property presence. Same
ReflectionTypeLoadException handling as the value-based scan.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@manuc66
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Runtime plugin pattern: KnownSubTypeOf, RegisterSubtypeAssembly, RegisterDynamicSubtype by manuc66 · Pull Request #211 · manuc66/JsonSubTypes · GitHub
Skip to content
Runtime plugin pattern: KnownSubTypeOf, RegisterSubtypeAssembly, RegisterDynamicSubtype - #211
Open
manuc66 wants to merge 5 commits into
feature/split/pr4-migration-fixesfrom 
feature/split/pr5-plugin-pattern
Open
Runtime plugin pattern: KnownSubTypeOf, RegisterSubtypeAssembly, RegisterDynamicSubtype#211
manuc66 wants to merge 5 commits into
feature/split/pr4-migration-fixesfrom 
feature/split/pr5-plugin-pattern
Conversation
@manuc66
@manuc66manuc66
commented
Aug 16, 2026

Copy link


Copy Markdown

Owner
Problem
Runtime-loaded subtypes (plugins, assemblies loaded at runtime, config-driven types) could not self-declare in the STJ engine: the only cross-assembly mechanism was a process-wide assembly registry, and per-subtype runtime registration did not exist.
Fix
  • Replace the global JsonSubTypesTypeResolution.AddAssembly registry with a declarative [KnownSubTypeOtherAssembly("AssemblyName")] attribute on the base type (per-type, no process-wide leak; no compile-time reference to the plugin).
  • Add self-declaring subtypes via KnownSubTypeOf (with discriminator value or by type name) and KnownSubTypeWithPropertyOf (by property presence).
  • Add RegisterSubtypeAssembly(assembly) to scan a loaded assembly for those declarations.
  • Add RegisterDynamicSubtype(discriminator, type) to register a single subtype directly after the converter is built.
  • New JsonSubTypes.Text.Json.Tests.Plugin test project.
Tests
  • New plugin/self-declaring tests across STJ suites; full STJ suite passes (net8.0 and net10.0).
Honest note(s)
  • The generator cannot see runtime-loaded hierarchies; the converter is the only engine for them (documented in the README plugin section, added in a later PR).
  • RegisterDynamicSubtype mutates the mapping and is intended for setup time, not concurrent use with serialization.
@manuc66
Replace the global assembly registry with a declarative JsonSubTypesT…
c491827
…ypeResolution attribute
JsonSubTypesTypeResolution.AddAssembly was a process-wide mutable registry that
leaked state across serialization profiles. Replace it with
[JsonSubTypesTypeResolution("AssemblyName")] on the base type, cached per type.
The attribute takes an assembly name rather than a Type: a Type would force the
base to reference the plugin assembly, which together with the plugin's reference
to the base creates a project cycle. Naming the assembly keeps the base free of a
compile-time reference to the plugin.
The cross-assembly tests now use SharedAnimal (base) with the plugin assembly
declared on it and PluginDog (in the plugin project) resolved by name, plus a
negative test on a base without the attribute.
@manuc66
Rename JsonSubTypesTypeResolution to KnownSubTypeOtherAssembly
b99e25b
The attribute's previous name was inherited from the global AddAssembly registry
it replaced and said nothing about its contract. KnownSubTypeOtherAssembly is a
noun consistent with the KnownSubType family, and Other carries the extension
beyond the base type's own assembly. The file follows the class name.
@manuc66
Add the self-declaring plugin pattern via KnownSubTypeOf and Register…
102b079
…SubtypeAssembly
Support the inverse philosophy of the base-declares approach: the subtype declares
itself as a child of the base through [KnownSubTypeOf(typeof(Base), "value")],
and the host registers the plugin assembly at runtime through
RegisterSubtypeAssembly. This covers the real plugin scenario the attribute
cannot: assemblies loaded at runtime whose names are unknown at compile time.
The scan mirrors the runtime cross-assembly approach: register the assembly, scan
its types for self-declared subtypes, and map those that carry a discriminator
value; types without a value resolve by name in the registered assembly.
ReflectionTypeLoadException is handled so an assembly with unloadable optional
types is not fatal. Both philosophies coexist: the base can still name other
assemblies via [KnownSubTypeOtherAssembly].
@manuc66
Add RegisterDynamicSubtype to the runtime converter
cb6db9a
The generator already exposed RegisterDynamicSubtype, but the runtime converter
did not: README claimed parity that did not exist. Add the same runtime hook to
JsonSubtypes<T>, mapping a discriminator to a subtype after the converter is
built, with last-registration-wins like the generator. This covers the simple
plugin need (register a subtype at runtime) without editing the plugin or
scanning an assembly, complementing RegisterSubtypeAssembly.
NullableDictionary gains a Set method for the overwrite semantics.
@manuc66
Add self-declared subtypes by property presence via KnownSubTypeWithP…
0a878d2
…ropertyOf
Mirror the KnownSubTypeOf work for property-presence discrimination. The subtype
declares itself through [KnownSubTypeWithPropertyOf(typeof(Base), "Property")]
and JsonSubtypesWithPropertyConverterBuilder.RegisterSubtypeAssembly scans the
registered assembly for those declarations, mapping the property presence. Same
ReflectionTypeLoadException handling as the value-based scan.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@manuc66

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Runtime plugin pattern: KnownSubTypeOf, RegisterSubtypeAssembly, RegisterDynamicSubtype by manuc66 · Pull Request #211 · manuc66/JsonSubTypes · GitHub
Skip to content
Runtime plugin pattern: KnownSubTypeOf, RegisterSubtypeAssembly, RegisterDynamicSubtype - #211
Open
manuc66 wants to merge 5 commits into
feature/split/pr4-migration-fixesfrom 
feature/split/pr5-plugin-pattern
Open
Runtime plugin pattern: KnownSubTypeOf, RegisterSubtypeAssembly, RegisterDynamicSubtype#211
manuc66 wants to merge 5 commits into
feature/split/pr4-migration-fixesfrom 
feature/split/pr5-plugin-pattern
Conversation
@manuc66
@manuc66manuc66
commented
Aug 16, 2026

Copy link


Copy Markdown

Owner
Problem
Runtime-loaded subtypes (plugins, assemblies loaded at runtime, config-driven types) could not self-declare in the STJ engine: the only cross-assembly mechanism was a process-wide assembly registry, and per-subtype runtime registration did not exist.
Fix
  • Replace the global JsonSubTypesTypeResolution.AddAssembly registry with a declarative [KnownSubTypeOtherAssembly("AssemblyName")] attribute on the base type (per-type, no process-wide leak; no compile-time reference to the plugin).
  • Add self-declaring subtypes via KnownSubTypeOf (with discriminator value or by type name) and KnownSubTypeWithPropertyOf (by property presence).
  • Add RegisterSubtypeAssembly(assembly) to scan a loaded assembly for those declarations.
  • Add RegisterDynamicSubtype(discriminator, type) to register a single subtype directly after the converter is built.
  • New JsonSubTypes.Text.Json.Tests.Plugin test project.
Tests
  • New plugin/self-declaring tests across STJ suites; full STJ suite passes (net8.0 and net10.0).
Honest note(s)
  • The generator cannot see runtime-loaded hierarchies; the converter is the only engine for them (documented in the README plugin section, added in a later PR).
  • RegisterDynamicSubtype mutates the mapping and is intended for setup time, not concurrent use with serialization.
@manuc66
Replace the global assembly registry with a declarative JsonSubTypesT…
c491827
…ypeResolution attribute
JsonSubTypesTypeResolution.AddAssembly was a process-wide mutable registry that
leaked state across serialization profiles. Replace it with
[JsonSubTypesTypeResolution("AssemblyName")] on the base type, cached per type.
The attribute takes an assembly name rather than a Type: a Type would force the
base to reference the plugin assembly, which together with the plugin's reference
to the base creates a project cycle. Naming the assembly keeps the base free of a
compile-time reference to the plugin.
The cross-assembly tests now use SharedAnimal (base) with the plugin assembly
declared on it and PluginDog (in the plugin project) resolved by name, plus a
negative test on a base without the attribute.
@manuc66
Rename JsonSubTypesTypeResolution to KnownSubTypeOtherAssembly
b99e25b
The attribute's previous name was inherited from the global AddAssembly registry
it replaced and said nothing about its contract. KnownSubTypeOtherAssembly is a
noun consistent with the KnownSubType family, and Other carries the extension
beyond the base type's own assembly. The file follows the class name.
@manuc66
Add the self-declaring plugin pattern via KnownSubTypeOf and Register…
102b079
…SubtypeAssembly
Support the inverse philosophy of the base-declares approach: the subtype declares
itself as a child of the base through [KnownSubTypeOf(typeof(Base), "value")],
and the host registers the plugin assembly at runtime through
RegisterSubtypeAssembly. This covers the real plugin scenario the attribute
cannot: assemblies loaded at runtime whose names are unknown at compile time.
The scan mirrors the runtime cross-assembly approach: register the assembly, scan
its types for self-declared subtypes, and map those that carry a discriminator
value; types without a value resolve by name in the registered assembly.
ReflectionTypeLoadException is handled so an assembly with unloadable optional
types is not fatal. Both philosophies coexist: the base can still name other
assemblies via [KnownSubTypeOtherAssembly].
@manuc66
Add RegisterDynamicSubtype to the runtime converter
cb6db9a
The generator already exposed RegisterDynamicSubtype, but the runtime converter
did not: README claimed parity that did not exist. Add the same runtime hook to
JsonSubtypes<T>, mapping a discriminator to a subtype after the converter is
built, with last-registration-wins like the generator. This covers the simple
plugin need (register a subtype at runtime) without editing the plugin or
scanning an assembly, complementing RegisterSubtypeAssembly.
NullableDictionary gains a Set method for the overwrite semantics.
@manuc66
Add self-declared subtypes by property presence via KnownSubTypeWithP…
0a878d2
…ropertyOf
Mirror the KnownSubTypeOf work for property-presence discrimination. The subtype
declares itself through [KnownSubTypeWithPropertyOf(typeof(Base), "Property")]
and JsonSubtypesWithPropertyConverterBuilder.RegisterSubtypeAssembly scans the
registered assembly for those declarations, mapping the property presence. Same
ReflectionTypeLoadException handling as the value-based scan.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@manuc66

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Runtime plugin pattern: KnownSubTypeOf, RegisterSubtypeAssembly, RegisterDynamicSubtype by manuc66 · Pull Request #211 · manuc66/JsonSubTypes · GitHub
Skip to content
Runtime plugin pattern: KnownSubTypeOf, RegisterSubtypeAssembly, RegisterDynamicSubtype - #211
Open
manuc66 wants to merge 5 commits into
feature/split/pr4-migration-fixesfrom 
feature/split/pr5-plugin-pattern
Open
Runtime plugin pattern: KnownSubTypeOf, RegisterSubtypeAssembly, RegisterDynamicSubtype#211
manuc66 wants to merge 5 commits into
feature/split/pr4-migration-fixesfrom 
feature/split/pr5-plugin-pattern
Conversation
@manuc66
@manuc66manuc66
commented
Aug 16, 2026

Copy link


Copy Markdown

Owner
Problem
Runtime-loaded subtypes (plugins, assemblies loaded at runtime, config-driven types) could not self-declare in the STJ engine: the only cross-assembly mechanism was a process-wide assembly registry, and per-subtype runtime registration did not exist.
Fix
  • Replace the global JsonSubTypesTypeResolution.AddAssembly registry with a declarative [KnownSubTypeOtherAssembly("AssemblyName")] attribute on the base type (per-type, no process-wide leak; no compile-time reference to the plugin).
  • Add self-declaring subtypes via KnownSubTypeOf (with discriminator value or by type name) and KnownSubTypeWithPropertyOf (by property presence).
  • Add RegisterSubtypeAssembly(assembly) to scan a loaded assembly for those declarations.
  • Add RegisterDynamicSubtype(discriminator, type) to register a single subtype directly after the converter is built.
  • New JsonSubTypes.Text.Json.Tests.Plugin test project.
Tests
  • New plugin/self-declaring tests across STJ suites; full STJ suite passes (net8.0 and net10.0).
Honest note(s)
  • The generator cannot see runtime-loaded hierarchies; the converter is the only engine for them (documented in the README plugin section, added in a later PR).
  • RegisterDynamicSubtype mutates the mapping and is intended for setup time, not concurrent use with serialization.
@manuc66
Replace the global assembly registry with a declarative JsonSubTypesT…
c491827
…ypeResolution attribute
JsonSubTypesTypeResolution.AddAssembly was a process-wide mutable registry that
leaked state across serialization profiles. Replace it with
[JsonSubTypesTypeResolution("AssemblyName")] on the base type, cached per type.
The attribute takes an assembly name rather than a Type: a Type would force the
base to reference the plugin assembly, which together with the plugin's reference
to the base creates a project cycle. Naming the assembly keeps the base free of a
compile-time reference to the plugin.
The cross-assembly tests now use SharedAnimal (base) with the plugin assembly
declared on it and PluginDog (in the plugin project) resolved by name, plus a
negative test on a base without the attribute.
@manuc66
Rename JsonSubTypesTypeResolution to KnownSubTypeOtherAssembly
b99e25b
The attribute's previous name was inherited from the global AddAssembly registry
it replaced and said nothing about its contract. KnownSubTypeOtherAssembly is a
noun consistent with the KnownSubType family, and Other carries the extension
beyond the base type's own assembly. The file follows the class name.
@manuc66
Add the self-declaring plugin pattern via KnownSubTypeOf and Register…
102b079
…SubtypeAssembly
Support the inverse philosophy of the base-declares approach: the subtype declares
itself as a child of the base through [KnownSubTypeOf(typeof(Base), "value")],
and the host registers the plugin assembly at runtime through
RegisterSubtypeAssembly. This covers the real plugin scenario the attribute
cannot: assemblies loaded at runtime whose names are unknown at compile time.
The scan mirrors the runtime cross-assembly approach: register the assembly, scan
its types for self-declared subtypes, and map those that carry a discriminator
value; types without a value resolve by name in the registered assembly.
ReflectionTypeLoadException is handled so an assembly with unloadable optional
types is not fatal. Both philosophies coexist: the base can still name other
assemblies via [KnownSubTypeOtherAssembly].
@manuc66
Add RegisterDynamicSubtype to the runtime converter
cb6db9a
The generator already exposed RegisterDynamicSubtype, but the runtime converter
did not: README claimed parity that did not exist. Add the same runtime hook to
JsonSubtypes<T>, mapping a discriminator to a subtype after the converter is
built, with last-registration-wins like the generator. This covers the simple
plugin need (register a subtype at runtime) without editing the plugin or
scanning an assembly, complementing RegisterSubtypeAssembly.
NullableDictionary gains a Set method for the overwrite semantics.
@manuc66
Add self-declared subtypes by property presence via KnownSubTypeWithP…
0a878d2
…ropertyOf
Mirror the KnownSubTypeOf work for property-presence discrimination. The subtype
declares itself through [KnownSubTypeWithPropertyOf(typeof(Base), "Property")]
and JsonSubtypesWithPropertyConverterBuilder.RegisterSubtypeAssembly scans the
registered assembly for those declarations, mapping the property presence. Same
ReflectionTypeLoadException handling as the value-based scan.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@manuc66

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Runtime plugin pattern: KnownSubTypeOf, RegisterSubtypeAssembly, RegisterDynamicSubtype by manuc66 · Pull Request #211 · manuc66/JsonSubTypes · GitHub
Skip to content
Runtime plugin pattern: KnownSubTypeOf, RegisterSubtypeAssembly, RegisterDynamicSubtype - #211
Open
manuc66 wants to merge 5 commits into
feature/split/pr4-migration-fixesfrom 
feature/split/pr5-plugin-pattern
Open
Runtime plugin pattern: KnownSubTypeOf, RegisterSubtypeAssembly, RegisterDynamicSubtype#211
manuc66 wants to merge 5 commits into
feature/split/pr4-migration-fixesfrom 
feature/split/pr5-plugin-pattern
Conversation
@manuc66
@manuc66manuc66
commented
Aug 16, 2026

Copy link


Copy Markdown

Owner
Problem
Runtime-loaded subtypes (plugins, assemblies loaded at runtime, config-driven types) could not self-declare in the STJ engine: the only cross-assembly mechanism was a process-wide assembly registry, and per-subtype runtime registration did not exist.
Fix
  • Replace the global JsonSubTypesTypeResolution.AddAssembly registry with a declarative [KnownSubTypeOtherAssembly("AssemblyName")] attribute on the base type (per-type, no process-wide leak; no compile-time reference to the plugin).
  • Add self-declaring subtypes via KnownSubTypeOf (with discriminator value or by type name) and KnownSubTypeWithPropertyOf (by property presence).
  • Add RegisterSubtypeAssembly(assembly) to scan a loaded assembly for those declarations.
  • Add RegisterDynamicSubtype(discriminator, type) to register a single subtype directly after the converter is built.
  • New JsonSubTypes.Text.Json.Tests.Plugin test project.
Tests
  • New plugin/self-declaring tests across STJ suites; full STJ suite passes (net8.0 and net10.0).
Honest note(s)
  • The generator cannot see runtime-loaded hierarchies; the converter is the only engine for them (documented in the README plugin section, added in a later PR).
  • RegisterDynamicSubtype mutates the mapping and is intended for setup time, not concurrent use with serialization.
@manuc66
Replace the global assembly registry with a declarative JsonSubTypesT…
c491827
…ypeResolution attribute
JsonSubTypesTypeResolution.AddAssembly was a process-wide mutable registry that
leaked state across serialization profiles. Replace it with
[JsonSubTypesTypeResolution("AssemblyName")] on the base type, cached per type.
The attribute takes an assembly name rather than a Type: a Type would force the
base to reference the plugin assembly, which together with the plugin's reference
to the base creates a project cycle. Naming the assembly keeps the base free of a
compile-time reference to the plugin.
The cross-assembly tests now use SharedAnimal (base) with the plugin assembly
declared on it and PluginDog (in the plugin project) resolved by name, plus a
negative test on a base without the attribute.
@manuc66
Rename JsonSubTypesTypeResolution to KnownSubTypeOtherAssembly
b99e25b
The attribute's previous name was inherited from the global AddAssembly registry
it replaced and said nothing about its contract. KnownSubTypeOtherAssembly is a
noun consistent with the KnownSubType family, and Other carries the extension
beyond the base type's own assembly. The file follows the class name.
@manuc66
Add the self-declaring plugin pattern via KnownSubTypeOf and Register…
102b079
…SubtypeAssembly
Support the inverse philosophy of the base-declares approach: the subtype declares
itself as a child of the base through [KnownSubTypeOf(typeof(Base), "value")],
and the host registers the plugin assembly at runtime through
RegisterSubtypeAssembly. This covers the real plugin scenario the attribute
cannot: assemblies loaded at runtime whose names are unknown at compile time.
The scan mirrors the runtime cross-assembly approach: register the assembly, scan
its types for self-declared subtypes, and map those that carry a discriminator
value; types without a value resolve by name in the registered assembly.
ReflectionTypeLoadException is handled so an assembly with unloadable optional
types is not fatal. Both philosophies coexist: the base can still name other
assemblies via [KnownSubTypeOtherAssembly].
@manuc66
Add RegisterDynamicSubtype to the runtime converter
cb6db9a
The generator already exposed RegisterDynamicSubtype, but the runtime converter
did not: README claimed parity that did not exist. Add the same runtime hook to
JsonSubtypes<T>, mapping a discriminator to a subtype after the converter is
built, with last-registration-wins like the generator. This covers the simple
plugin need (register a subtype at runtime) without editing the plugin or
scanning an assembly, complementing RegisterSubtypeAssembly.
NullableDictionary gains a Set method for the overwrite semantics.
@manuc66
Add self-declared subtypes by property presence via KnownSubTypeWithP…
0a878d2
…ropertyOf
Mirror the KnownSubTypeOf work for property-presence discrimination. The subtype
declares itself through [KnownSubTypeWithPropertyOf(typeof(Base), "Property")]
and JsonSubtypesWithPropertyConverterBuilder.RegisterSubtypeAssembly scans the
registered assembly for those declarations, mapping the property presence. Same
ReflectionTypeLoadException handling as the value-based scan.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@manuc66

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Runtime plugin pattern: KnownSubTypeOf, RegisterSubtypeAssembly, RegisterDynamicSubtype by manuc66 · Pull Request #211 · manuc66/JsonSubTypes · GitHub
Skip to content
Runtime plugin pattern: KnownSubTypeOf, RegisterSubtypeAssembly, RegisterDynamicSubtype - #211
Open
manuc66 wants to merge 5 commits into
feature/split/pr4-migration-fixesfrom 
feature/split/pr5-plugin-pattern
Open
Runtime plugin pattern: KnownSubTypeOf, RegisterSubtypeAssembly, RegisterDynamicSubtype#211
manuc66 wants to merge 5 commits into
feature/split/pr4-migration-fixesfrom 
feature/split/pr5-plugin-pattern
Conversation
@manuc66
@manuc66manuc66
commented
Aug 16, 2026

Copy link


Copy Markdown

Owner
Problem
Runtime-loaded subtypes (plugins, assemblies loaded at runtime, config-driven types) could not self-declare in the STJ engine: the only cross-assembly mechanism was a process-wide assembly registry, and per-subtype runtime registration did not exist.
Fix
  • Replace the global JsonSubTypesTypeResolution.AddAssembly registry with a declarative [KnownSubTypeOtherAssembly("AssemblyName")] attribute on the base type (per-type, no process-wide leak; no compile-time reference to the plugin).
  • Add self-declaring subtypes via KnownSubTypeOf (with discriminator value or by type name) and KnownSubTypeWithPropertyOf (by property presence).
  • Add RegisterSubtypeAssembly(assembly) to scan a loaded assembly for those declarations.
  • Add RegisterDynamicSubtype(discriminator, type) to register a single subtype directly after the converter is built.
  • New JsonSubTypes.Text.Json.Tests.Plugin test project.
Tests
  • New plugin/self-declaring tests across STJ suites; full STJ suite passes (net8.0 and net10.0).
Honest note(s)
  • The generator cannot see runtime-loaded hierarchies; the converter is the only engine for them (documented in the README plugin section, added in a later PR).
  • RegisterDynamicSubtype mutates the mapping and is intended for setup time, not concurrent use with serialization.
@manuc66
Replace the global assembly registry with a declarative JsonSubTypesT…
c491827
…ypeResolution attribute
JsonSubTypesTypeResolution.AddAssembly was a process-wide mutable registry that
leaked state across serialization profiles. Replace it with
[JsonSubTypesTypeResolution("AssemblyName")] on the base type, cached per type.
The attribute takes an assembly name rather than a Type: a Type would force the
base to reference the plugin assembly, which together with the plugin's reference
to the base creates a project cycle. Naming the assembly keeps the base free of a
compile-time reference to the plugin.
The cross-assembly tests now use SharedAnimal (base) with the plugin assembly
declared on it and PluginDog (in the plugin project) resolved by name, plus a
negative test on a base without the attribute.
@manuc66
Rename JsonSubTypesTypeResolution to KnownSubTypeOtherAssembly
b99e25b
The attribute's previous name was inherited from the global AddAssembly registry
it replaced and said nothing about its contract. KnownSubTypeOtherAssembly is a
noun consistent with the KnownSubType family, and Other carries the extension
beyond the base type's own assembly. The file follows the class name.
@manuc66
Add the self-declaring plugin pattern via KnownSubTypeOf and Register…
102b079
…SubtypeAssembly
Support the inverse philosophy of the base-declares approach: the subtype declares
itself as a child of the base through [KnownSubTypeOf(typeof(Base), "value")],
and the host registers the plugin assembly at runtime through
RegisterSubtypeAssembly. This covers the real plugin scenario the attribute
cannot: assemblies loaded at runtime whose names are unknown at compile time.
The scan mirrors the runtime cross-assembly approach: register the assembly, scan
its types for self-declared subtypes, and map those that carry a discriminator
value; types without a value resolve by name in the registered assembly.
ReflectionTypeLoadException is handled so an assembly with unloadable optional
types is not fatal. Both philosophies coexist: the base can still name other
assemblies via [KnownSubTypeOtherAssembly].
@manuc66
Add RegisterDynamicSubtype to the runtime converter
cb6db9a
The generator already exposed RegisterDynamicSubtype, but the runtime converter
did not: README claimed parity that did not exist. Add the same runtime hook to
JsonSubtypes<T>, mapping a discriminator to a subtype after the converter is
built, with last-registration-wins like the generator. This covers the simple
plugin need (register a subtype at runtime) without editing the plugin or
scanning an assembly, complementing RegisterSubtypeAssembly.
NullableDictionary gains a Set method for the overwrite semantics.
@manuc66
Add self-declared subtypes by property presence via KnownSubTypeWithP…
0a878d2
…ropertyOf
Mirror the KnownSubTypeOf work for property-presence discrimination. The subtype
declares itself through [KnownSubTypeWithPropertyOf(typeof(Base), "Property")]
and JsonSubtypesWithPropertyConverterBuilder.RegisterSubtypeAssembly scans the
registered assembly for those declarations, mapping the property presence. Same
ReflectionTypeLoadException handling as the value-based scan.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@manuc66

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Runtime plugin pattern: KnownSubTypeOf, RegisterSubtypeAssembly, RegisterDynamicSubtype by manuc66 · Pull Request #211 · manuc66/JsonSubTypes · GitHub
Skip to content
Runtime plugin pattern: KnownSubTypeOf, RegisterSubtypeAssembly, RegisterDynamicSubtype - #211
Open
manuc66 wants to merge 5 commits into
feature/split/pr4-migration-fixesfrom 
feature/split/pr5-plugin-pattern
Open
Runtime plugin pattern: KnownSubTypeOf, RegisterSubtypeAssembly, RegisterDynamicSubtype#211
manuc66 wants to merge 5 commits into
feature/split/pr4-migration-fixesfrom 
feature/split/pr5-plugin-pattern
Conversation
@manuc66
@manuc66manuc66
commented
Aug 16, 2026

Copy link


Copy Markdown

Owner
Problem
Runtime-loaded subtypes (plugins, assemblies loaded at runtime, config-driven types) could not self-declare in the STJ engine: the only cross-assembly mechanism was a process-wide assembly registry, and per-subtype runtime registration did not exist.
Fix
  • Replace the global JsonSubTypesTypeResolution.AddAssembly registry with a declarative [KnownSubTypeOtherAssembly("AssemblyName")] attribute on the base type (per-type, no process-wide leak; no compile-time reference to the plugin).
  • Add self-declaring subtypes via KnownSubTypeOf (with discriminator value or by type name) and KnownSubTypeWithPropertyOf (by property presence).
  • Add RegisterSubtypeAssembly(assembly) to scan a loaded assembly for those declarations.
  • Add RegisterDynamicSubtype(discriminator, type) to register a single subtype directly after the converter is built.
  • New JsonSubTypes.Text.Json.Tests.Plugin test project.
Tests
  • New plugin/self-declaring tests across STJ suites; full STJ suite passes (net8.0 and net10.0).
Honest note(s)
  • The generator cannot see runtime-loaded hierarchies; the converter is the only engine for them (documented in the README plugin section, added in a later PR).
  • RegisterDynamicSubtype mutates the mapping and is intended for setup time, not concurrent use with serialization.
@manuc66
Replace the global assembly registry with a declarative JsonSubTypesT…
c491827
…ypeResolution attribute
JsonSubTypesTypeResolution.AddAssembly was a process-wide mutable registry that
leaked state across serialization profiles. Replace it with
[JsonSubTypesTypeResolution("AssemblyName")] on the base type, cached per type.
The attribute takes an assembly name rather than a Type: a Type would force the
base to reference the plugin assembly, which together with the plugin's reference
to the base creates a project cycle. Naming the assembly keeps the base free of a
compile-time reference to the plugin.
The cross-assembly tests now use SharedAnimal (base) with the plugin assembly
declared on it and PluginDog (in the plugin project) resolved by name, plus a
negative test on a base without the attribute.
@manuc66
Rename JsonSubTypesTypeResolution to KnownSubTypeOtherAssembly
b99e25b
The attribute's previous name was inherited from the global AddAssembly registry
it replaced and said nothing about its contract. KnownSubTypeOtherAssembly is a
noun consistent with the KnownSubType family, and Other carries the extension
beyond the base type's own assembly. The file follows the class name.
@manuc66
Add the self-declaring plugin pattern via KnownSubTypeOf and Register…
102b079
…SubtypeAssembly
Support the inverse philosophy of the base-declares approach: the subtype declares
itself as a child of the base through [KnownSubTypeOf(typeof(Base), "value")],
and the host registers the plugin assembly at runtime through
RegisterSubtypeAssembly. This covers the real plugin scenario the attribute
cannot: assemblies loaded at runtime whose names are unknown at compile time.
The scan mirrors the runtime cross-assembly approach: register the assembly, scan
its types for self-declared subtypes, and map those that carry a discriminator
value; types without a value resolve by name in the registered assembly.
ReflectionTypeLoadException is handled so an assembly with unloadable optional
types is not fatal. Both philosophies coexist: the base can still name other
assemblies via [KnownSubTypeOtherAssembly].
@manuc66
Add RegisterDynamicSubtype to the runtime converter
cb6db9a
The generator already exposed RegisterDynamicSubtype, but the runtime converter
did not: README claimed parity that did not exist. Add the same runtime hook to
JsonSubtypes<T>, mapping a discriminator to a subtype after the converter is
built, with last-registration-wins like the generator. This covers the simple
plugin need (register a subtype at runtime) without editing the plugin or
scanning an assembly, complementing RegisterSubtypeAssembly.
NullableDictionary gains a Set method for the overwrite semantics.
@manuc66
Add self-declared subtypes by property presence via KnownSubTypeWithP…
0a878d2
…ropertyOf
Mirror the KnownSubTypeOf work for property-presence discrimination. The subtype
declares itself through [KnownSubTypeWithPropertyOf(typeof(Base), "Property")]
and JsonSubtypesWithPropertyConverterBuilder.RegisterSubtypeAssembly scans the
registered assembly for those declarations, mapping the property presence. Same
ReflectionTypeLoadException handling as the value-based scan.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@manuc66

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Runtime plugin pattern: KnownSubTypeOf, RegisterSubtypeAssembly, RegisterDynamicSubtype by manuc66 · Pull Request #211 · manuc66/JsonSubTypes · GitHub
Skip to content
Runtime plugin pattern: KnownSubTypeOf, RegisterSubtypeAssembly, RegisterDynamicSubtype - #211
Open
manuc66 wants to merge 5 commits into
feature/split/pr4-migration-fixesfrom 
feature/split/pr5-plugin-pattern
Open
Runtime plugin pattern: KnownSubTypeOf, RegisterSubtypeAssembly, RegisterDynamicSubtype#211
manuc66 wants to merge 5 commits into
feature/split/pr4-migration-fixesfrom 
feature/split/pr5-plugin-pattern
Conversation
@manuc66
@manuc66manuc66
commented
Aug 16, 2026

Copy link


Copy Markdown

Owner
Problem
Runtime-loaded subtypes (plugins, assemblies loaded at runtime, config-driven types) could not self-declare in the STJ engine: the only cross-assembly mechanism was a process-wide assembly registry, and per-subtype runtime registration did not exist.
Fix
  • Replace the global JsonSubTypesTypeResolution.AddAssembly registry with a declarative [KnownSubTypeOtherAssembly("AssemblyName")] attribute on the base type (per-type, no process-wide leak; no compile-time reference to the plugin).
  • Add self-declaring subtypes via KnownSubTypeOf (with discriminator value or by type name) and KnownSubTypeWithPropertyOf (by property presence).
  • Add RegisterSubtypeAssembly(assembly) to scan a loaded assembly for those declarations.
  • Add RegisterDynamicSubtype(discriminator, type) to register a single subtype directly after the converter is built.
  • New JsonSubTypes.Text.Json.Tests.Plugin test project.
Tests
  • New plugin/self-declaring tests across STJ suites; full STJ suite passes (net8.0 and net10.0).
Honest note(s)
  • The generator cannot see runtime-loaded hierarchies; the converter is the only engine for them (documented in the README plugin section, added in a later PR).
  • RegisterDynamicSubtype mutates the mapping and is intended for setup time, not concurrent use with serialization.
@manuc66
Replace the global assembly registry with a declarative JsonSubTypesT…
c491827
…ypeResolution attribute
JsonSubTypesTypeResolution.AddAssembly was a process-wide mutable registry that
leaked state across serialization profiles. Replace it with
[JsonSubTypesTypeResolution("AssemblyName")] on the base type, cached per type.
The attribute takes an assembly name rather than a Type: a Type would force the
base to reference the plugin assembly, which together with the plugin's reference
to the base creates a project cycle. Naming the assembly keeps the base free of a
compile-time reference to the plugin.
The cross-assembly tests now use SharedAnimal (base) with the plugin assembly
declared on it and PluginDog (in the plugin project) resolved by name, plus a
negative test on a base without the attribute.
@manuc66
Rename JsonSubTypesTypeResolution to KnownSubTypeOtherAssembly
b99e25b
The attribute's previous name was inherited from the global AddAssembly registry
it replaced and said nothing about its contract. KnownSubTypeOtherAssembly is a
noun consistent with the KnownSubType family, and Other carries the extension
beyond the base type's own assembly. The file follows the class name.
@manuc66
Add the self-declaring plugin pattern via KnownSubTypeOf and Register…
102b079
…SubtypeAssembly
Support the inverse philosophy of the base-declares approach: the subtype declares
itself as a child of the base through [KnownSubTypeOf(typeof(Base), "value")],
and the host registers the plugin assembly at runtime through
RegisterSubtypeAssembly. This covers the real plugin scenario the attribute
cannot: assemblies loaded at runtime whose names are unknown at compile time.
The scan mirrors the runtime cross-assembly approach: register the assembly, scan
its types for self-declared subtypes, and map those that carry a discriminator
value; types without a value resolve by name in the registered assembly.
ReflectionTypeLoadException is handled so an assembly with unloadable optional
types is not fatal. Both philosophies coexist: the base can still name other
assemblies via [KnownSubTypeOtherAssembly].
@manuc66
Add RegisterDynamicSubtype to the runtime converter
cb6db9a
The generator already exposed RegisterDynamicSubtype, but the runtime converter
did not: README claimed parity that did not exist. Add the same runtime hook to
JsonSubtypes<T>, mapping a discriminator to a subtype after the converter is
built, with last-registration-wins like the generator. This covers the simple
plugin need (register a subtype at runtime) without editing the plugin or
scanning an assembly, complementing RegisterSubtypeAssembly.
NullableDictionary gains a Set method for the overwrite semantics.
@manuc66
Add self-declared subtypes by property presence via KnownSubTypeWithP…
0a878d2
…ropertyOf
Mirror the KnownSubTypeOf work for property-presence discrimination. The subtype
declares itself through [KnownSubTypeWithPropertyOf(typeof(Base), "Property")]
and JsonSubtypesWithPropertyConverterBuilder.RegisterSubtypeAssembly scans the
registered assembly for those declarations, mapping the property presence. Same
ReflectionTypeLoadException handling as the value-based scan.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@manuc66