Skip to content

Add OIDC authentication plugin import - #302

Merged
manusa merged 2 commits into
manusa:mainfrom
ttbadr:oidc
Nov 13, 2025
Merged

Add OIDC authentication plugin import#302
manusa merged 2 commits into
manusa:mainfrom
ttbadr:oidc

Conversation

@ttbadr

@ttbadrttbadr commented Nov 2, 2025

Copy link
Copy Markdown
Contributor

Fixes#300

@manusamanusa left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for OIDC authentication by importing Kubernetes client-go authentication plugins, addressing issue #300. The change enables Helm operations to work with clusters using OIDC, Azure AD, GCP, and exec-based authentication methods.

  • Adds new plugins.go file with side-effect imports for Kubernetes authentication plugins
  • Reorganizes imports in helm.go to follow standard Go grouping conventions

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

FileDescription
native/internal/helm/plugins.goIntroduces authentication plugin imports (azure, exec, gcp, oidc) to enable various Kubernetes authentication methods
native/internal/helm/helm.goRefactors import statements to group standard library and third-party imports separately

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +19 to +22
import _ "k8s.io/client-go/plugin/pkg/client/auth/azure"
import _ "k8s.io/client-go/plugin/pkg/client/auth/exec"
import _ "k8s.io/client-go/plugin/pkg/client/auth/gcp"
import _ "k8s.io/client-go/plugin/pkg/client/auth/oidc"

CopilotAINov 13, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import statements should be grouped together in a single import block with parentheses, following the Go convention and the style used throughout this codebase. Consider formatting like this:

import (
_ "k8s.io/client-go/plugin/pkg/client/auth/azure"
_ "k8s.io/client-go/plugin/pkg/client/auth/exec"
_ "k8s.io/client-go/plugin/pkg/client/auth/gcp"
_ "k8s.io/client-go/plugin/pkg/client/auth/oidc"
)

This is the standard Go style for multiple imports and matches the pattern used in other files in this project (e.g., helm.go, install.go, version.go).

Suggested change
import _ "k8s.io/client-go/plugin/pkg/client/auth/azure"
import _ "k8s.io/client-go/plugin/pkg/client/auth/exec"
import _ "k8s.io/client-go/plugin/pkg/client/auth/gcp"
import _ "k8s.io/client-go/plugin/pkg/client/auth/oidc"
import (
_"k8s.io/client-go/plugin/pkg/client/auth/azure"
_"k8s.io/client-go/plugin/pkg/client/auth/exec"
_"k8s.io/client-go/plugin/pkg/client/auth/gcp"
_"k8s.io/client-go/plugin/pkg/client/auth/oidc"
)

Copilot uses AI. Check for mistakes.
@manusa
manusa merged commit 30c8a45 into manusa:mainNov 13, 2025
9 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OIDC support

3 participants

@ttbadr@manusa