Removing static fields - #62
Merged
Merged
Conversation
move referece tile field to map visualization as map visualization relies on reference point remove world scale and made other scripts to get it from world root transform. scale shouldn't be relevant to map vis, it is unity vis
…s but only in support modules like directions helper, slippy etc
# Conflicts: # sdkproject/Assets/Mapbox/Core/Unity/MeshGeneration/MapVisualization.cs # sdkproject/Assets/Mapbox/Examples/SlippyVectorTerrain/SlippyDemo.unity
… chance to override lat/lon on enable). Private setters for ref rect and world scale
…s it down to factories
…ox-unity-sdk into removingStaticFields # Conflicts: # sdkproject/Assets/Mapbox/Core/Unity/MeshGeneration/MapController.cs
Moving execution to start to allow developers to set lat/lon before map creation.
david-rhodes
approved these changes
May 11, 2017
david-rhodes
left a comment
There was a problem hiding this comment.
I think we should make some of these fields private and use struct for world params instead, but those can be handled in a future refactor (planned).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.