Uh oh!
There was an error while loading. Please reload this page.
fix(#868kfujp9): Fix CVEs, migrate build from @zeit/ncc to esbuild - #4
Merged
Conversation
loopingrage
approved these changes
Aug 10, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ No new overrides
Fixed:
The previous @actions/core bump to ^3.0.0 (already on master) made this package ESM-only, which the old @zeit/ncc bundler can't handle — its build was silently failing, so dist/index.js and dist/cleanup.js had never actually been rebuilt since that bump and were running stale pre-bump code. Migrated the build to esbuild (actively maintained, handles ESM deps natively) and converted index.js/cleanup.js to ESM import syntax to match. Verified dist/index.js and dist/cleanup.js end-to-end against a real generated SSH key (known_hosts write, ssh-agent start, key add, cleanup) — all working as before.