Enhance Test Framework to be able to run a single test. by rhou1 · Pull Request #391 · mapr/drill-test-framework

rhou1 · 2018-01-04T05:25:54Z

The -s option can now support a mixture of test suites and individual query files,
separated by commas. If the individual query file does not have a json definition
file in the same directory, the Test Framework will check the parent directories
until it finds at least one JSON file, at which time it assumes that one of those
JSON files can be used.

The -s option can now support a mixture of test suites and individual query files, separated by commas. If the individual query file does not have a json definition file in the same directory, the Test Framework will check the parent directories until it finds at least one JSON file, at which time it assumes that one of those JSON files can be used.

rhou1 · 2018-01-04T05:26:09Z

Chun, please take a look.

agirish · 2018-01-04T06:03:35Z

Hey this is really cool! Thanks for adding this

agirish · 2018-01-04T19:54:50Z

Does this handle cases when there are more than one test def JSON files in the folder?

rhou1 · 2018-01-04T21:14:14Z

Yes, this supports having multiple JSON definition files in the same folder. This is how I discovered the query file extension is not quite correct, because I was picking the wrong JSON file.

agirish · 2018-01-04T21:35:57Z

cool, thanks! I'd like to try this out sometime.

cchang738 · 2018-01-04T22:38:23Z

+ List<File> jsonFiles = searchFiles(singleTestFile.getParentFile(), ".*.json");
+ if (jsonFiles.isEmpty()) {
+ String updir = "";
+ while (jsonFiles.isEmpty()) {


What happens if you never encounter a test definition file in any of the upstream directories?

cchang738 · 2018-01-04T22:46:48Z

+ }
+ }
+ }
+


Can you test the following scenarios:
-s .../dir contains test definition file and sudirs containing .json
-s .../test_definition_file.json
-s .../test_query.q
-s .../dir without any test definition files in any of the dir and parent dirs

Do we need to specify the relative path to the test, including the file extension?

What does the "..." do?
how is .json different from test definition file?
are there any files besides test_definition_file.json in the directory?

@agirish. Yes. Previously we would say
-s Functional/p1tests
Now we can say
-s Functional/p1tests/is_null.q

rhou1 · 2018-01-04T05:25:54Z

The -s option can now support a mixture of test suites and individual query files,
separated by commas. If the individual query file does not have a json definition
file in the same directory, the Test Framework will check the parent directories
until it finds at least one JSON file, at which time it assumes that one of those
JSON files can be used.

The -s option can now support a mixture of test suites and individual query files, separated by commas. If the individual query file does not have a json definition file in the same directory, the Test Framework will check the parent directories until it finds at least one JSON file, at which time it assumes that one of those JSON files can be used.

rhou1 · 2018-01-04T05:26:09Z

Chun, please take a look.

agirish · 2018-01-04T06:03:35Z

Hey this is really cool! Thanks for adding this

agirish · 2018-01-04T19:54:50Z

Does this handle cases when there are more than one test def JSON files in the folder?

rhou1 · 2018-01-04T21:14:14Z

Yes, this supports having multiple JSON definition files in the same folder. This is how I discovered the query file extension is not quite correct, because I was picking the wrong JSON file.

agirish · 2018-01-04T21:35:57Z

cool, thanks! I'd like to try this out sometime.

cchang738 · 2018-01-04T22:38:23Z

+ List<File> jsonFiles = searchFiles(singleTestFile.getParentFile(), ".*.json");
+ if (jsonFiles.isEmpty()) {
+ String updir = "";
+ while (jsonFiles.isEmpty()) {


What happens if you never encounter a test definition file in any of the upstream directories?

cchang738 · 2018-01-04T22:46:48Z

+ }
+ }
+ }
+


Can you test the following scenarios:
-s .../dir contains test definition file and sudirs containing .json
-s .../test_definition_file.json
-s .../test_query.q
-s .../dir without any test definition files in any of the dir and parent dirs

Do we need to specify the relative path to the test, including the file extension?

What does the "..." do?
how is .json different from test definition file?
are there any files besides test_definition_file.json in the directory?

@agirish. Yes. Previously we would say
-s Functional/p1tests
Now we can say
-s Functional/p1tests/is_null.q

rhou1 · 2018-01-04T05:25:54Z

The -s option can now support a mixture of test suites and individual query files,
separated by commas. If the individual query file does not have a json definition
file in the same directory, the Test Framework will check the parent directories
until it finds at least one JSON file, at which time it assumes that one of those
JSON files can be used.

The -s option can now support a mixture of test suites and individual query files, separated by commas. If the individual query file does not have a json definition file in the same directory, the Test Framework will check the parent directories until it finds at least one JSON file, at which time it assumes that one of those JSON files can be used.

rhou1 · 2018-01-04T05:26:09Z

Chun, please take a look.

agirish · 2018-01-04T06:03:35Z

Hey this is really cool! Thanks for adding this

agirish · 2018-01-04T19:54:50Z

Does this handle cases when there are more than one test def JSON files in the folder?

rhou1 · 2018-01-04T21:14:14Z

Yes, this supports having multiple JSON definition files in the same folder. This is how I discovered the query file extension is not quite correct, because I was picking the wrong JSON file.

agirish · 2018-01-04T21:35:57Z

cool, thanks! I'd like to try this out sometime.

cchang738 · 2018-01-04T22:38:23Z

+ List<File> jsonFiles = searchFiles(singleTestFile.getParentFile(), ".*.json");
+ if (jsonFiles.isEmpty()) {
+ String updir = "";
+ while (jsonFiles.isEmpty()) {


What happens if you never encounter a test definition file in any of the upstream directories?

cchang738 · 2018-01-04T22:46:48Z

+ }
+ }
+ }
+


Can you test the following scenarios:
-s .../dir contains test definition file and sudirs containing .json
-s .../test_definition_file.json
-s .../test_query.q
-s .../dir without any test definition files in any of the dir and parent dirs

Do we need to specify the relative path to the test, including the file extension?

What does the "..." do?
how is .json different from test definition file?
are there any files besides test_definition_file.json in the directory?

@agirish. Yes. Previously we would say
-s Functional/p1tests
Now we can say
-s Functional/p1tests/is_null.q

rhou1 · 2018-01-04T05:25:54Z

The -s option can now support a mixture of test suites and individual query files,
separated by commas. If the individual query file does not have a json definition
file in the same directory, the Test Framework will check the parent directories
until it finds at least one JSON file, at which time it assumes that one of those
JSON files can be used.

The -s option can now support a mixture of test suites and individual query files, separated by commas. If the individual query file does not have a json definition file in the same directory, the Test Framework will check the parent directories until it finds at least one JSON file, at which time it assumes that one of those JSON files can be used.

rhou1 · 2018-01-04T05:26:09Z

Chun, please take a look.

agirish · 2018-01-04T06:03:35Z

Hey this is really cool! Thanks for adding this

agirish · 2018-01-04T19:54:50Z

Does this handle cases when there are more than one test def JSON files in the folder?

rhou1 · 2018-01-04T21:14:14Z

Yes, this supports having multiple JSON definition files in the same folder. This is how I discovered the query file extension is not quite correct, because I was picking the wrong JSON file.

agirish · 2018-01-04T21:35:57Z

cool, thanks! I'd like to try this out sometime.

cchang738 · 2018-01-04T22:38:23Z

+ List<File> jsonFiles = searchFiles(singleTestFile.getParentFile(), ".*.json");
+ if (jsonFiles.isEmpty()) {
+ String updir = "";
+ while (jsonFiles.isEmpty()) {


What happens if you never encounter a test definition file in any of the upstream directories?

cchang738 · 2018-01-04T22:46:48Z

+ }
+ }
+ }
+


Can you test the following scenarios:
-s .../dir contains test definition file and sudirs containing .json
-s .../test_definition_file.json
-s .../test_query.q
-s .../dir without any test definition files in any of the dir and parent dirs

Do we need to specify the relative path to the test, including the file extension?

What does the "..." do?
how is .json different from test definition file?
are there any files besides test_definition_file.json in the directory?

@agirish. Yes. Previously we would say
-s Functional/p1tests
Now we can say
-s Functional/p1tests/is_null.q

rhou1 · 2018-01-04T05:25:54Z

The -s option can now support a mixture of test suites and individual query files,
separated by commas. If the individual query file does not have a json definition
file in the same directory, the Test Framework will check the parent directories
until it finds at least one JSON file, at which time it assumes that one of those
JSON files can be used.

The -s option can now support a mixture of test suites and individual query files, separated by commas. If the individual query file does not have a json definition file in the same directory, the Test Framework will check the parent directories until it finds at least one JSON file, at which time it assumes that one of those JSON files can be used.

rhou1 · 2018-01-04T05:26:09Z

Chun, please take a look.

agirish · 2018-01-04T06:03:35Z

Hey this is really cool! Thanks for adding this

agirish · 2018-01-04T19:54:50Z

Does this handle cases when there are more than one test def JSON files in the folder?

rhou1 · 2018-01-04T21:14:14Z

Yes, this supports having multiple JSON definition files in the same folder. This is how I discovered the query file extension is not quite correct, because I was picking the wrong JSON file.

agirish · 2018-01-04T21:35:57Z

cool, thanks! I'd like to try this out sometime.

cchang738 · 2018-01-04T22:38:23Z

+ List<File> jsonFiles = searchFiles(singleTestFile.getParentFile(), ".*.json");
+ if (jsonFiles.isEmpty()) {
+ String updir = "";
+ while (jsonFiles.isEmpty()) {


What happens if you never encounter a test definition file in any of the upstream directories?

cchang738 · 2018-01-04T22:46:48Z

+ }
+ }
+ }
+


Can you test the following scenarios:
-s .../dir contains test definition file and sudirs containing .json
-s .../test_definition_file.json
-s .../test_query.q
-s .../dir without any test definition files in any of the dir and parent dirs

Do we need to specify the relative path to the test, including the file extension?

What does the "..." do?
how is .json different from test definition file?
are there any files besides test_definition_file.json in the directory?

@agirish. Yes. Previously we would say
-s Functional/p1tests
Now we can say
-s Functional/p1tests/is_null.q

rhou1 · 2018-01-04T05:25:54Z

The -s option can now support a mixture of test suites and individual query files,
separated by commas. If the individual query file does not have a json definition
file in the same directory, the Test Framework will check the parent directories
until it finds at least one JSON file, at which time it assumes that one of those
JSON files can be used.

The -s option can now support a mixture of test suites and individual query files, separated by commas. If the individual query file does not have a json definition file in the same directory, the Test Framework will check the parent directories until it finds at least one JSON file, at which time it assumes that one of those JSON files can be used.

rhou1 · 2018-01-04T05:26:09Z

Chun, please take a look.

agirish · 2018-01-04T06:03:35Z

Hey this is really cool! Thanks for adding this

agirish · 2018-01-04T19:54:50Z

Does this handle cases when there are more than one test def JSON files in the folder?

rhou1 · 2018-01-04T21:14:14Z

Yes, this supports having multiple JSON definition files in the same folder. This is how I discovered the query file extension is not quite correct, because I was picking the wrong JSON file.

agirish · 2018-01-04T21:35:57Z

cool, thanks! I'd like to try this out sometime.

cchang738 · 2018-01-04T22:38:23Z

+ List<File> jsonFiles = searchFiles(singleTestFile.getParentFile(), ".*.json");
+ if (jsonFiles.isEmpty()) {
+ String updir = "";
+ while (jsonFiles.isEmpty()) {


What happens if you never encounter a test definition file in any of the upstream directories?

cchang738 · 2018-01-04T22:46:48Z

+ }
+ }
+ }
+


Can you test the following scenarios:
-s .../dir contains test definition file and sudirs containing .json
-s .../test_definition_file.json
-s .../test_query.q
-s .../dir without any test definition files in any of the dir and parent dirs

Do we need to specify the relative path to the test, including the file extension?

What does the "..." do?
how is .json different from test definition file?
are there any files besides test_definition_file.json in the directory?

@agirish. Yes. Previously we would say
-s Functional/p1tests
Now we can say
-s Functional/p1tests/is_null.q

rhou1 · 2018-01-04T05:25:54Z

The -s option can now support a mixture of test suites and individual query files,
separated by commas. If the individual query file does not have a json definition
file in the same directory, the Test Framework will check the parent directories
until it finds at least one JSON file, at which time it assumes that one of those
JSON files can be used.

The -s option can now support a mixture of test suites and individual query files, separated by commas. If the individual query file does not have a json definition file in the same directory, the Test Framework will check the parent directories until it finds at least one JSON file, at which time it assumes that one of those JSON files can be used.

rhou1 · 2018-01-04T05:26:09Z

Chun, please take a look.

agirish · 2018-01-04T06:03:35Z

Hey this is really cool! Thanks for adding this

agirish · 2018-01-04T19:54:50Z

Does this handle cases when there are more than one test def JSON files in the folder?

rhou1 · 2018-01-04T21:14:14Z

Yes, this supports having multiple JSON definition files in the same folder. This is how I discovered the query file extension is not quite correct, because I was picking the wrong JSON file.

agirish · 2018-01-04T21:35:57Z

cool, thanks! I'd like to try this out sometime.

cchang738 · 2018-01-04T22:38:23Z

+ List<File> jsonFiles = searchFiles(singleTestFile.getParentFile(), ".*.json");
+ if (jsonFiles.isEmpty()) {
+ String updir = "";
+ while (jsonFiles.isEmpty()) {


What happens if you never encounter a test definition file in any of the upstream directories?

cchang738 · 2018-01-04T22:46:48Z

+ }
+ }
+ }
+


Can you test the following scenarios:
-s .../dir contains test definition file and sudirs containing .json
-s .../test_definition_file.json
-s .../test_query.q
-s .../dir without any test definition files in any of the dir and parent dirs

Do we need to specify the relative path to the test, including the file extension?

What does the "..." do?
how is .json different from test definition file?
are there any files besides test_definition_file.json in the directory?

@agirish. Yes. Previously we would say
-s Functional/p1tests
Now we can say
-s Functional/p1tests/is_null.q

rhou1 · 2018-01-04T05:25:54Z

The -s option can now support a mixture of test suites and individual query files,
separated by commas. If the individual query file does not have a json definition
file in the same directory, the Test Framework will check the parent directories
until it finds at least one JSON file, at which time it assumes that one of those
JSON files can be used.

The -s option can now support a mixture of test suites and individual query files, separated by commas. If the individual query file does not have a json definition file in the same directory, the Test Framework will check the parent directories until it finds at least one JSON file, at which time it assumes that one of those JSON files can be used.

rhou1 · 2018-01-04T05:26:09Z

Chun, please take a look.

agirish · 2018-01-04T06:03:35Z

Hey this is really cool! Thanks for adding this

agirish · 2018-01-04T19:54:50Z

Does this handle cases when there are more than one test def JSON files in the folder?

rhou1 · 2018-01-04T21:14:14Z

Yes, this supports having multiple JSON definition files in the same folder. This is how I discovered the query file extension is not quite correct, because I was picking the wrong JSON file.

agirish · 2018-01-04T21:35:57Z

cool, thanks! I'd like to try this out sometime.

cchang738 · 2018-01-04T22:38:23Z

+ List<File> jsonFiles = searchFiles(singleTestFile.getParentFile(), ".*.json");
+ if (jsonFiles.isEmpty()) {
+ String updir = "";
+ while (jsonFiles.isEmpty()) {


What happens if you never encounter a test definition file in any of the upstream directories?

cchang738 · 2018-01-04T22:46:48Z

+ }
+ }
+ }
+


Can you test the following scenarios:
-s .../dir contains test definition file and sudirs containing .json
-s .../test_definition_file.json
-s .../test_query.q
-s .../dir without any test definition files in any of the dir and parent dirs

Do we need to specify the relative path to the test, including the file extension?

What does the "..." do?
how is .json different from test definition file?
are there any files besides test_definition_file.json in the directory?

@agirish. Yes. Previously we would say
-s Functional/p1tests
Now we can say
-s Functional/p1tests/is_null.q

cchang738 reviewed Jan 4, 2018
View reviewed changes

Uh oh!

Conversation

rhou1 commented Jan 4, 2018

Uh oh!

rhou1 commented Jan 4, 2018

Uh oh!

agirish commented Jan 4, 2018

Uh oh!

agirish commented Jan 4, 2018

Uh oh!

rhou1 commented Jan 4, 2018

Uh oh!

agirish commented Jan 4, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

rhou1 commented Jan 4, 2018

Uh oh!

rhou1 commented Jan 4, 2018

Uh oh!

agirish commented Jan 4, 2018

Uh oh!

agirish commented Jan 4, 2018

Uh oh!

rhou1 commented Jan 4, 2018

Uh oh!

agirish commented Jan 4, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

rhou1 commented Jan 4, 2018

Uh oh!

rhou1 commented Jan 4, 2018

Uh oh!

agirish commented Jan 4, 2018

Uh oh!

agirish commented Jan 4, 2018

Uh oh!

rhou1 commented Jan 4, 2018

Uh oh!

agirish commented Jan 4, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!