Fix idle watcher start race after PR #38 - #39
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke
PR #38 preserved the guard that pauses a compactor created after system activity resumes, but it still had a pre-compactor gap: an IdleOnly watcher run could be parsing when the system became active, then start background compression later because
PauseCompacting()had nothing active to pause yet.The runtime log reproduced this exact sequence: idle analysis started, the system became active, and background compression started roughly 30 seconds afterward. That leaves
WatchedFolder.IsWorkingtrue once the run reaches a long/paused folder, which is the progress ring visible in the watcher UI.Fix
The corrective diff is limited to
Watcher.vbandBackgroundCompactor.vb; none of the custom charcoal/compression UI files are changed.Verification
git diff --check: clean.Build and ReleaseWindows x64 workflow: passed.Supply-chain auditworkflow: passed.SEC_E_NO_CREDENTIALS); GitHub Actions completed the authoritative Windows build successfully.