Uh oh!
There was an error while loading. Please reload this page.
Added support to adding simple block rules - #1003
Closed
KostyaTretyak wants to merge 2 commits into
Closed
Conversation
joshbruce
commented
Jan 6, 2018
Member
Thanks @KostyaTretyak! Gonna flag this for milestone 0.5.0. If you could take a look at #1002 - I believe it could cause this to have merge conflicts in the future as we would need to add tests to document and validate the solution works. Cheers. |
KostyaTretyak
commented
Jan 6, 2018
ContributorAuthor
@joshbruce no, it does not seem that my changes were in conflict with the changes introduced in #1002. |
Feder1co5oave
suggested changes
Jan 20, 2018
| for (var i = 0; i < simpleRules.length; i++) { | ||
| if (cap = simpleRules[i].exec(src)) { | ||
| src = src.substring(cap[0].length); | ||
| this.tokens.push({ type: 'simpleRule' + simpleRules.length, cap: cap }); |
Contributor
There was a problem hiding this comment.
shouldn't this be 'simpleRule' + i ?
ContributorAuthor
There was a problem hiding this comment.
Yes, you are right, I'll correct it right now. Thank you.
joshbruce
commented
Jan 21, 2018
Member
See #1026 Closing as merge conflicts - also building out the issue above to consolidate ideas and approaches proposed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Output: