Skip to content

Escapedpipes - #1239

Merged
joshbruce merged 2 commits into
markedjs:masterfrom
tomtheisen:escapedpipes
Apr 25, 2018
Merged

Escapedpipes#1239
joshbruce merged 2 commits into
markedjs:masterfrom
tomtheisen:escapedpipes

Conversation

@tomtheisen

@tomtheisentomtheisen commented Apr 25, 2018

Copy link
Copy Markdown

Marked version: 0.3.19

Markdown flavor: Markdown.pl|CommonMark|GitHub Flavored Markdown|n/a

Description

This PR adds support for escaped pipes inside GFM tables. \| can be used to embed a literal pipe inside a table cell.

This means compliance with GFM spec example #193.

Contributor

  • Test(s) exist to ensure functionality and minimize regression: Example 193 in gfm.0.28.json
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@UziTechUziTech left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@UziTech
UziTech requested a review from joshbruceApril 25, 2018 05:27

@joshbrucejoshbruce left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. LGTM

@joshbruce
joshbruce merged commit c5cc037 into markedjs:masterApr 25, 2018
@joshbrucejoshbruce mentioned this pull request Apr 25, 2018
6 tasks
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GFM doesn't handle escaped pipes in code blocks

3 participants

@tomtheisen@UziTech@joshbruce