Skip to content

Allow travis to pass when redos check fails - #1256

Merged
styfle merged 3 commits into
markedjs:masterfrom
UziTech:test-travis
May 8, 2018
Merged

Allow travis to pass when redos check fails#1256
styfle merged 3 commits into
markedjs:masterfrom
UziTech:test-travis

Conversation

@UziTech

@UziTechUziTech commented May 7, 2018•
edited by styfle
Loading

Copy link
Copy Markdown
Member

Markdown flavor:7a9e35e

Description

  • Allows travis to pass even when npm run test:redos fails

image

closes#1254

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

styfle
styfle approved these changes May 7, 2018
View reviewed changes

@styflestyfle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

@styflestyfle mentioned this pull request May 7, 2018
Closed
4 tasks
@davisjam

davisjam commented May 8, 2018

Copy link
Copy Markdown
Contributor

Sounds good.

@davisjam
davisjam removed their request for review May 8, 2018 13:58
davisjam
davisjam approved these changes May 8, 2018
View reviewed changes

@davisjamdavisjam left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@styfle
styfle merged commit dbd0dff into markedjs:masterMay 8, 2018
@UziTech
UziTech deleted the test-travis branch February 19, 2019 20:19
@snyk-botsnyk-bot mentioned this pull request Aug 19, 2019
Open
This was referenced Aug 30, 2019
Open
Open
@snyk-botsnyk-bot mentioned this pull request Sep 24, 2019
Open
This was referenced Oct 26, 2019
Open
Open
Open
Closed
Open
@snyk-botsnyk-bot mentioned this pull request Nov 4, 2019
Open
This was referenced Nov 18, 2019
Open
Open
Open
Open
Open
Open
Open
This was referenced Mar 24, 2020
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Mar 31, 2020
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Apr 7, 2020
Open
Open
Open
Open
Open
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
@styfle
Merge pull requestmarkedjs#1256from UziTech/test-travis
4c51d55
Allow travis to pass when redos check fails
@snyk-botsnyk-bot mentioned this pull request Dec 29, 2022
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@styflestyflestyfle approved these changes
@davisjamdavisjamdavisjam approved these changes
@joshbrucejoshbruceAwaiting requested review from joshbruce

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@UziTech@davisjam@styfle