Skip to content

Add missing semicolons, add lint rule - #1340

Merged
styfle merged 3 commits into
markedjs:masterfrom
styfle:semicolons
Sep 26, 2018
Merged

Add missing semicolons, add lint rule#1340
styfle merged 3 commits into
markedjs:masterfrom
styfle:semicolons

Conversation

@styfle

@styflestyfle commented Sep 23, 2018

Copy link
Copy Markdown
Member

Marked version:

0.5.0

Markdown flavor: All

Description

There were several places missing semicolons which get auto-inserted but typically its better to be explicit and match the existing js style.

Functionally, there is no change.

https://lgtm.com/projects/g/markedjs/marked/alerts/?mode=list

Contributor

  • Test(s) exist to ensure functionality and minimize regression (lint rule)

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@UziTech

Copy link
Copy Markdown
Member

Perhaps we should add a rule to eslint to make sure we dont miss any in the future.

@styfle

Copy link
Copy Markdown
MemberAuthor

@UziTech Good point! I added a rule to .eslintrc.json 👍

@styfle
styfle requested a review from UziTechSeptember 24, 2018 01:02

@davisjamdavisjam left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@styflestyfle changed the title Add missing semicolonsAdd missing semicolons, add lint ruleSep 26, 2018
@styfle
styfle merged commit 99c8c1c into markedjs:masterSep 26, 2018
@styfle
styfle deleted the semicolons branch September 26, 2018 15:27
@styflestyfle mentioned this pull request Nov 19, 2018
12 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@styfle@UziTech@davisjam