Skip to content

Make autolinks case insensitive - #1384

Merged
styfle merged 3 commits into
markedjs:masterfrom
UziTech:url-case-insensitive
Dec 6, 2018
Merged

Make autolinks case insensitive#1384
styfle merged 3 commits into
markedjs:masterfrom
UziTech:url-case-insensitive

Conversation

@UziTech

@UziTechUziTech commented Dec 5, 2018

Copy link
Copy Markdown
Member

Marked version: master

Markdown flavor: Markdown.pl|CommonMark|GitHub Flavored Markdown|n/a

Description

Make urls case insensitive

implements #1350 (comment)

marked("hTtP://fOo.CoM");// <p><a href=\"hTtP://fOo.CoM\">hTtP://fOo.CoM</a></p>

Contributor

  • Test(s) exist to ensure functionality and minimize regression

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

Comment threadtest/specs/marked/marked.json Outdated
Comment threadtest/specs/marked/marked.json Outdated
Comment threadtest/specs/marked/marked.json
@styfle

Copy link
Copy Markdown
Member

/cc @roygold7 since PR 1350 was started but didn't finish.

I want to make sure Roy is aware of this PR and that the reason for the new PR is no movement on the old PR.

I don't want to end up in this scenario.

styfleand others added 2 commits December 5, 2018 12:12
Co-Authored-By: UziTech <tony@brix.ninja>
Co-Authored-By: UziTech <tony@brix.ninja>
@roygold7

Copy link
Copy Markdown

@styfle I appreciate the comment but I'd be just as happy if the issue was resolved in a different PR. I'm not looking for credit.

@davisjam

Copy link
Copy Markdown
Contributor

LGTM. This should not have a ReDoS impact.

@styflestyfle changed the title Make links case insensitiveMake autolinks case insensitiveDec 6, 2018
@styfle
styfle merged commit 06297df into markedjs:masterDec 6, 2018
@UziTech
UziTech deleted the url-case-insensitive branch February 19, 2019 20:19
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@UziTech@styfle@roygold7@davisjam