Skip to content

Fix tag escaping - #1397

Merged
styfle merged 1 commit into
markedjs:masterfrom
mccraveiro:escape-tag
Dec 20, 2018
Merged

Fix tag escaping#1397
styfle merged 1 commit into
markedjs:masterfrom
mccraveiro:escape-tag

Conversation

@mccraveiro

@mccraveiromccraveiro commented Dec 20, 2018

Copy link
Copy Markdown
Contributor

Marked version: master branch

Markdown flavor: CommonMark

Description

Input

\*not emphasized*\<br/> not a tag
\[not a link](/foo)\`not code`
1\. not a list
\* not a list
\# not a heading
\[foo]: /url "not a reference"

Expectation

<p>*not emphasized*
&lt;br/&gt; not a tag
[not a link](/foo)
`not code`
1. not a list
* not a list
# not a heading
[foo]: /url &quot;not a reference&quot;</p>

Result

<p>*not emphasized*
<br/&gt; not a tag
[not a link](/foo)
`not code`
1. not a list
* not a list
# not a heading
[foo]: /url &quot;not a reference&quot;</p>

What was attempted

HTML escaping tag start

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Important: I had to change 2 old tests so they match the spec. Please double check it! :)

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@mccraveiromccraveiro changed the title Fix tag escapingWIP Fix tag escapingDec 20, 2018
@mccraveiromccraveiro changed the title WIP Fix tag escapingFix tag escapingDec 20, 2018

@UziTechUziTech left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a roll 💯

@styflestyfle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grand Slam ⚾️

@styfle
styfle merged commit 53d7ba0 into markedjs:masterDec 20, 2018
@mccraveiro
mccraveiro deleted the escape-tag branch December 20, 2018 21:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mccraveiro@UziTech@styfle