Skip to content

Update devDependencies to last stable - #1409

Merged
styfle merged 1 commit into
markedjs:masterfrom
Feder1co5oave:update-devdeps
Jan 14, 2019
Merged

Update devDependencies to last stable#1409
styfle merged 1 commit into
markedjs:masterfrom
Feder1co5oave:update-devdeps

Conversation

@Feder1co5oave

Copy link
Copy Markdown
Contributor

Update devDependencies to versions found at https://david-dm.org/markedjs/marked?type=dev

Had to disable new eslint rule to avoid introducing codebase changes. We have mixed type of literal objects:

{key: "value"}{key: "value"}

so we might go for one or the other, or leave them as they are.
If we consider linting more aggressively, also the rule space-before-function-paren can be enforced, and we might take the chance and change indentation warnings into errors so they're caught by the CI robot. Let me know.

…ing` standard rule (eslint-config-standard#124).
@styfle

Copy link
Copy Markdown
Member

I personally prefer spaces in object literals such as { key: "value" } and the same for destructuring such as const { key } = obj.

@styflestyfle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! These were severely out of date. I seem to recall @UziTech pinning glob-to-regexp for some reason but I'm not sure why.

@Martii

Copy link
Copy Markdown
Contributor

@Feder1co5oave

Apologies for the interruption...

... last stable

Do you mean "latest"? Last implies that something is EOL'd from a quick read in my emails/notifications.

@Feder1co5oave

Copy link
Copy Markdown
ContributorAuthor

@Martii all the versions are described as "stable" at the link above. I think in semver everything is considered "stable" unless a postfix such as "-alpha" or "-rc" is appended.

@Feder1co5oave

Copy link
Copy Markdown
ContributorAuthor

glob-to-regex@0.3.0 was introduced in #1004 but I can't find the specific reason it was pinned

@styfle
styfle requested a review from UziTechJanuary 14, 2019 14:18
@UziTech

Copy link
Copy Markdown
Member

I probably just forgot the caret (^) It doesn't look like v0.4.0 should break anything.

@styfle
styfle merged commit 5c5de3e into markedjs:masterJan 14, 2019
@UziTechUziTech mentioned this pull request Feb 18, 2019
12 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Feder1co5oave@styfle@Martii@UziTech