Uh oh!
There was an error while loading. Please reload this page.
demo worker - #1418
Conversation
Check out the current redos here This takes about 10 seconds to parse on my machine. You can change the version to |
Uh oh!
There was an error while loading. Please reload this page.
UziTech
commented
Feb 14, 2019
I also got it working with PRs I moved quite a bit of code around to make it more readable and added a loading screen at the beginning since we need to load the versions and worker before anything will work. the latest version is at: https://docs-g29qo7nxq.now.sh/demo/ |
styfle
left a comment
There was a problem hiding this comment.
Amazing! 🎉
I was going to suggest we start deploying PR's using ZEIT Now but this is almost just as good, as long as we don't refactor marked into multiple files.
UziTech
commented
Feb 14, 2019
If we refactor marked in multiple files and use ES modules it should still work in modern browsers. |
davisjam
left a comment
There was a problem hiding this comment.
I've never used WebWorkers but this looks about like I would have imagined it.
Can we recycle some of this code into a marked+timeout API usable in Node and web contexts?
joshbruce
left a comment
There was a problem hiding this comment.
Just verification for milestone considerations. This only effects the demo site at this point, not marked itself. It improves our ability to discover the one major bug type we feel rushed to fix.
UziTech
commented
Feb 14, 2019
@joshbruce correct, this only changes the demo site |
joshbruce
commented
Feb 15, 2019
Sorry didn't notice this the first time but I'd like to add the same caveat for my approval as what's on #1414 - what's up with Snyk? What needs to happen? What can I do to help that endeavor? |
UziTech
commented
Feb 16, 2019
see my comment on Snyk at #1414 (comment) |


Description
I added a web worker to the demo page. This will allow easier testing for redos attacks.
You can test it out at: https://docs-8bxhez41v.now.sh/demo/
This PR adds is branched off #1415 with https://github.com/remyhunt/marked/pull/1 merged so we should get that PR merged first.
Contributor
Committer
In most cases, this should be a different person than the contributor.