Skip to content

add docs for workers - #1432

Merged
joshbruce merged 12 commits into
markedjs:masterfrom
UziTech:worker-docs
May 3, 2019
Merged

add docs for workers#1432
joshbruce merged 12 commits into
markedjs:masterfrom
UziTech:worker-docs

Conversation

@UziTech

@UziTechUziTech commented Mar 1, 2019•
edited
Loading

Copy link
Copy Markdown
Member

Description

Add examples of how to run marked in a worker on node and in a browser.
https://docs-4nj255ohp.now.sh/#/USING_ADVANCED.md#workers

fixes#1184

Contributor

  • no tests required for this PR.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@UziTechUziTech added the category: docs Documentation changes label Mar 1, 2019
styfle
styfle reviewed Mar 2, 2019
View reviewed changes
Comment threaddocs/USING_ADVANCED.md Outdated
styfle
styfle reviewed Mar 2, 2019
View reviewed changes
Comment threaddocs/USING_ADVANCED.md Outdated
styfle
styfle reviewed Mar 2, 2019
View reviewed changes
Comment threaddocs/USING_ADVANCED.md Outdated
styfle
styfle reviewed Mar 2, 2019
View reviewed changes
Comment threaddocs/USING_ADVANCED.md Outdated
@styfle

styfle commented Mar 2, 2019

Copy link
Copy Markdown
Member

There was one bug in the example that was mixing function keyword and arrow functions.

I think we should just use arrow functions for workers because its an advanced feature and so we can assume the reader understands ES6.

styfleand others added 3 commits March 2, 2019 15:04
@styfle@UziTech
Update docs/USING_ADVANCED.md
bc812cc
Co-Authored-By: UziTech <tony@brix.ninja>
@styfle@UziTech
Update docs/USING_ADVANCED.md
b551b88
Co-Authored-By: UziTech <tony@brix.ninja>
@styfle@UziTech
Update docs/USING_ADVANCED.md
6d37c18
Co-Authored-By: UziTech <tony@brix.ninja>
styfle
styfle approved these changes Mar 2, 2019
View reviewed changes

@styflestyfle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💚

@UziTech

UziTech commented Mar 2, 2019

Copy link
Copy Markdown
MemberAuthor

Nice catch

@UziTechUziTech changed the title add docs for workers[WIP] add docs for workersMar 7, 2019
@UziTech

UziTech commented Mar 7, 2019

Copy link
Copy Markdown
MemberAuthor

wait to merge this until after worker_threads in node are stable

@UziTechUziTech mentioned this pull request Mar 11, 2019
Closed
@UziTechUziTech changed the title [WIP] add docs for workersadd docs for workersApr 26, 2019
@UziTech

UziTech commented Apr 26, 2019

Copy link
Copy Markdown
MemberAuthor

I added notes about Worker Threads being experimental and Web Workers sending objects on postMessage instead of just the string.

https://docs-4nj255ohp.now.sh/#/USING_ADVANCED.md#workers

I think this should be good to merge.

styfle
styfle reviewed Apr 26, 2019
View reviewed changes
Comment threaddocs/USING_ADVANCED.md Outdated
@styfle@UziTech
relative markedWorker.js
0d1f923
Co-Authored-By: UziTech <tony@brix.ninja>
@UziTech
UziTech requested review from davisjam and joshbruceMay 3, 2019 18:08
@yogansnykgityogansnykgit mentioned this pull request Oct 25, 2024
Open
@shad0w92shad0w92 mentioned this pull request Oct 26, 2024
Open
@shyamaaronshyamaaron mentioned this pull request Oct 26, 2024
Open
@Gowtham3223108Gowtham3223108 mentioned this pull request Oct 26, 2024
Open
@udayreddy026udayreddy026 mentioned this pull request Oct 26, 2024
Open
@moamed-syedmoamed-syed mentioned this pull request Oct 27, 2024
Open
@ManPrivateManPrivate mentioned this pull request Oct 27, 2024
Closed
@tdsnyktdsnyk mentioned this pull request Oct 28, 2024
Open
@sri-sankarisri-sankari mentioned this pull request Oct 28, 2024
Open
@mohankumar931mohankumar931 mentioned this pull request Oct 28, 2024
Open
@sound25sound25 mentioned this pull request Oct 29, 2024
Open
@Latha-lgtmLatha-lgtm mentioned this pull request Oct 29, 2024
Open
@GOWTHAMAKURINJIVEANDANGOWTHAMAKURINJIVEANDAN mentioned this pull request Oct 29, 2024
Open
@Dejah2024Dejah2024 mentioned this pull request Oct 30, 2024
Open
@ThiruVaithiyaThiruVaithiya mentioned this pull request Oct 30, 2024
Open
@Suriya0802Suriya0802 mentioned this pull request Oct 30, 2024
Open
@Shriv12Shriv12 mentioned this pull request Oct 30, 2024
Open
@Magali0007Magali0007 mentioned this pull request Oct 31, 2024
Open
@Ganesh13349Ganesh13349 mentioned this pull request Oct 31, 2024
Open
@sinnakkrishnansinnakkrishnan mentioned this pull request Nov 1, 2024
Open
@krithika-manoharkrithika-manohar mentioned this pull request Nov 1, 2024
Open
@SAGAYANELSON55SAGAYANELSON55 mentioned this pull request Nov 1, 2024
Open
@swathi-raswathi-ra mentioned this pull request Nov 2, 2024
Open
@HUGO-AppSecHUGO-AppSec mentioned this pull request Nov 3, 2024
Open
@danielsb74danielsb74 mentioned this pull request Nov 5, 2024
Open
@selvaganesh26selvaganesh26 mentioned this pull request Nov 5, 2024
Open
@merkeldevmerkeldev mentioned this pull request Nov 5, 2024
Open
@joedean-gitjoedean-git mentioned this pull request Nov 9, 2024
Open
@MimiDas-SnykMimiDas-Snyk mentioned this pull request Nov 10, 2024
Open
@BenDrKoBenDrKo mentioned this pull request Nov 11, 2024
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@styflestyflestyfle approved these changes
@joshbrucejoshbrucejoshbruce approved these changes
@davisjamdavisjamAwaiting requested review from davisjam

Assignees

No one assigned

Labels

category: docsDocumentation changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Question: Markdown, storage and security

3 participants

@UziTech@styfle@joshbruce