Skip to content

Add --test man documentation and changes argv parameters test/index.js - #1442

Merged
styfle merged 12 commits into
masterfrom
unknown repository
Mar 12, 2019
Merged

Add --test man documentation and changes argv parameters test/index.js#1442
styfle merged 12 commits into
masterfrom
unknown repository

Conversation

@ghost

@ghostghost commented Mar 10, 2019

Copy link
Copy Markdown

Marked version:

Markdown flavor: Markdown.pl|CommonMark|GitHub Flavored Markdown|n/a

Description

  • Added --test man documentation in response to Add --test option in man page #1423. I don't know If I'm using the correct groff format. I ran "man -P cat ./marked.1 > marked.1.txt" to write the "marked.1.txt" file. I don't know if that's what I'm suppose to do.
  • Changed the parseArg code in test/index.js because it was using process.argv and not argv.
    varopt=parseArg();

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

Comment threadlib/marked.js Outdated
Comment threadman/marked.1.txt Outdated
@ghost

Copy link
Copy Markdown
Author

I meant --minified and not --run. The loose parameter was a mistake.

Comment threadtest/index.js
Comment threadbin/marked Outdated
Comment threadtest/index.js Outdated
Comment threadman/marked.1.txt
@UziTech

Copy link
Copy Markdown
Member

To make the tests pass you will have to change /test/specs/original/specs-spec.js line 6

- if (!specTests({stop: true})) {+ if (!specTests(['', '', '--stop'])) {

Comment threadtest/index.js Outdated
Comment threadtest/index.js
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@UziTech@styfle