Skip to content

Normalize tests - #1444

Merged
UziTech merged 12 commits into
markedjs:masterfrom
UziTech:normalize-tests
Mar 12, 2019
Merged

Normalize tests#1444
UziTech merged 12 commits into
markedjs:masterfrom
UziTech:normalize-tests

Conversation

@UziTech

@UziTechUziTech commented Mar 10, 2019

Copy link
Copy Markdown
Member

Marked version: master

Description

Normalize tests. Put non-spec tests into /new files.

New tests should be put into their own files so we don't have merge conflicts every time a PR with tests is merged.

Contributor

  • Test(s) exist to ensure functionality and minimize regression

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@UziTech

UziTech commented Mar 10, 2019•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

the tests will pass once #1439 is merged

styfle
styfle reviewed Mar 10, 2019
View reviewed changes
Comment threadtest/helpers/helpers.js
styfle
styfle reviewed Mar 10, 2019
View reviewed changes
Comment threadtest/specs/run-spec.js Outdated
styfle
styfle reviewed Mar 10, 2019
View reviewed changes
Comment threadtest/specs/run-spec.js Outdated
styfle
styfle reviewed Mar 10, 2019
View reviewed changes
Comment threadtest/specs/run-spec.js Outdated
styfle
styfle reviewed Mar 10, 2019
View reviewed changes
Comment threadtest/specs/run-spec.js Outdated
styfle
styfle reviewed Mar 11, 2019
View reviewed changes
Comment threadtest/helpers/helpers.js Outdated
@UziTechUziTech mentioned this pull request Mar 12, 2019
Closed
4 tasks
davisjam
davisjam approved these changes Mar 12, 2019
View reviewed changes

@davisjamdavisjam left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.

@UziTech
UziTech merged commit 5d6bde0 into markedjs:masterMar 12, 2019
@UziTech
UziTech deleted the normalize-tests branch March 12, 2019 17:05
This was referenced Mar 12, 2019
Closed
Closed
@styflestyfle mentioned this pull request Mar 25, 2019
Merged
12 tasks
@yogansnykgityogansnykgit mentioned this pull request Oct 25, 2024
Open
@shad0w92shad0w92 mentioned this pull request Oct 26, 2024
Open
@shyamaaronshyamaaron mentioned this pull request Oct 26, 2024
Open
@Gowtham3223108Gowtham3223108 mentioned this pull request Oct 26, 2024
Open
@udayreddy026udayreddy026 mentioned this pull request Oct 26, 2024
Open
@moamed-syedmoamed-syed mentioned this pull request Oct 27, 2024
Open
@ManPrivateManPrivate mentioned this pull request Oct 27, 2024
Closed
@tdsnyktdsnyk mentioned this pull request Oct 28, 2024
Open
@sri-sankarisri-sankari mentioned this pull request Oct 28, 2024
Open
@mohankumar931mohankumar931 mentioned this pull request Oct 28, 2024
Open
@sound25sound25 mentioned this pull request Oct 29, 2024
Open
@Latha-lgtmLatha-lgtm mentioned this pull request Oct 29, 2024
Open
@GOWTHAMAKURINJIVEANDANGOWTHAMAKURINJIVEANDAN mentioned this pull request Oct 29, 2024
Open
@Dejah2024Dejah2024 mentioned this pull request Oct 30, 2024
Open
@ThiruVaithiyaThiruVaithiya mentioned this pull request Oct 30, 2024
Open
@Suriya0802Suriya0802 mentioned this pull request Oct 30, 2024
Open
@Shriv12Shriv12 mentioned this pull request Oct 30, 2024
Open
@Magali0007Magali0007 mentioned this pull request Oct 31, 2024
Open
@Ganesh13349Ganesh13349 mentioned this pull request Oct 31, 2024
Open
@sinnakkrishnansinnakkrishnan mentioned this pull request Nov 1, 2024
Open
@krithika-manoharkrithika-manohar mentioned this pull request Nov 1, 2024
Open
@SAGAYANELSON55SAGAYANELSON55 mentioned this pull request Nov 1, 2024
Open
@swathi-raswathi-ra mentioned this pull request Nov 2, 2024
Open
@HUGO-AppSecHUGO-AppSec mentioned this pull request Nov 3, 2024
Open
@danielsb74danielsb74 mentioned this pull request Nov 5, 2024
Open
@selvaganesh26selvaganesh26 mentioned this pull request Nov 5, 2024
Open
@merkeldevmerkeldev mentioned this pull request Nov 5, 2024
Open
@joedean-gitjoedean-git mentioned this pull request Nov 9, 2024
Open
@MimiDas-SnykMimiDas-Snyk mentioned this pull request Nov 10, 2024
Open
@BenDrKoBenDrKo mentioned this pull request Nov 11, 2024
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@styflestyflestyfle approved these changes
@davisjamdavisjamdavisjam approved these changes
@joshbrucejoshbruceAwaiting requested review from joshbruce

Assignees

No one assigned

Labels

category: tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@UziTech@styfle@davisjam