Skip to content

use latest commit for demo master - #1457

Merged
joshbruce merged 3 commits into
markedjs:masterfrom
UziTech:demo-master-version
Apr 6, 2019
Merged

use latest commit for demo master#1457
joshbruce merged 3 commits into
markedjs:masterfrom
UziTech:demo-master-version

Conversation

@UziTech

@UziTechUziTech commented Mar 29, 2019

Copy link
Copy Markdown
Member

Description

use @master in demo for master version

https://docs-ikjy0vxvf.now.sh/demo/

Contributor

  • no tests required for this PR.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@UziTechUziTech mentioned this pull request Mar 29, 2019
@styfle

Copy link
Copy Markdown
Member

I think the branch is cached by the CDN for a week or so which is maybe why it wasn’t showing the latest.

@UziTech

Copy link
Copy Markdown
MemberAuthor

If that is the case than this won't fix the issue. I wonder If I should grab the latest commit hash and use that.

@styfle

Copy link
Copy Markdown
Member

@UziTech That might work. Another alternative is to add a "bust cache" button since there appears to be an API for that (requires an email).

See the full discussion here: jsdelivr/jsdelivr#18101

@UziTech

Copy link
Copy Markdown
MemberAuthor

Using the latest commit hash seems to be the right way to go.

https://docs-qaob045da.now.sh/demo/

@UziTech

UziTech commented Apr 3, 2019

Copy link
Copy Markdown
MemberAuthor

I also fixed a bug when using a regular version

https://docs-ikjy0vxvf.now.sh/demo/

@UziTechUziTech changed the title use @masteruse latest commit for demo masterApr 3, 2019
@UziTechUziTech added the category: docs Documentation changes label Apr 3, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: docsDocumentation changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@UziTech@styfle@joshbruce