Skip to content

Nested blockquotes - #1464

Merged
joshbruce merged 4 commits into
markedjs:masterfrom
UziTech:nested-blockquotes
May 3, 2019
Merged

Nested blockquotes#1464
joshbruce merged 4 commits into
markedjs:masterfrom
UziTech:nested-blockquotes

Conversation

@UziTech

@UziTechUziTech commented Apr 9, 2019•
edited by joshbruce
Loading

Copy link
Copy Markdown
Member

Marked version: master

Markdown flavor: All

Description

Removes recursion for nested blockquotes

Fixes#1462demo

TODO:

  • clean up code
  • add more tests

Contributor

  • Test(s) exist to ensure functionality and minimize regression

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@UziTechUziTech mentioned this pull request Apr 9, 2019
Closed
@UziTechUziTech changed the title [WIP] Nested blockquotesNested blockquotesApr 12, 2019
@styfle

styfle commented Apr 18, 2019

Copy link
Copy Markdown
Member

@UziTech Are these todo's still relevant?

  • clean up code
  • add more tests

@UziTech

UziTech commented Apr 18, 2019

Copy link
Copy Markdown
MemberAuthor

Sorry no, I forgot to check them.

@styflestyfle added category: blockquotes L0 - security A security vulnerability within the Marked library is discovered labels Apr 18, 2019
@UziTechUziTech closed this Apr 25, 2019
@UziTech
UziTech deleted the nested-blockquotes branch April 25, 2019 05:11
@UziTech
UziTech restored the nested-blockquotes branch May 3, 2019 19:54
@UziTechUziTech reopened this May 3, 2019
@UziTech

UziTech commented May 3, 2019

Copy link
Copy Markdown
MemberAuthor

I'm not sure why I closed this before. This should be ready to merge.

/cc @styfle@joshbruce@davisjam

@joshbruce
joshbruce merged commit 67b91cf into markedjs:masterMay 3, 2019
@anderskandersk mentioned this pull request May 3, 2019
Closed
This was referenced Jun 4, 2019
Closed
Merged
joshbruce added a commit that referenced this pull request Jun 12, 2019
@joshbruce
Merge pull request#1497from UziTech/revert-1464
5ba9ba5
revert #1464
@UziTech
UziTech deleted the nested-blockquotes branch July 1, 2019 18:08
@snyk-botsnyk-bot mentioned this pull request Aug 19, 2019
Open
This was referenced Aug 30, 2019
Open
Open
@snyk-botsnyk-bot mentioned this pull request Sep 24, 2019
Open
@yogansnykgityogansnykgit mentioned this pull request Oct 25, 2024
Open
@shad0w92shad0w92 mentioned this pull request Oct 26, 2024
Open
@shyamaaronshyamaaron mentioned this pull request Oct 26, 2024
Open
@Gowtham3223108Gowtham3223108 mentioned this pull request Oct 26, 2024
Open
@udayreddy026udayreddy026 mentioned this pull request Oct 26, 2024
Open
@moamed-syedmoamed-syed mentioned this pull request Oct 27, 2024
Open
@ManPrivateManPrivate mentioned this pull request Oct 27, 2024
Closed
@tdsnyktdsnyk mentioned this pull request Oct 28, 2024
Open
@sri-sankarisri-sankari mentioned this pull request Oct 28, 2024
Open
@mohankumar931mohankumar931 mentioned this pull request Oct 28, 2024
Open
@sound25sound25 mentioned this pull request Oct 29, 2024
Open
@Latha-lgtmLatha-lgtm mentioned this pull request Oct 29, 2024
Open
@GOWTHAMAKURINJIVEANDANGOWTHAMAKURINJIVEANDAN mentioned this pull request Oct 29, 2024
Open
@Dejah2024Dejah2024 mentioned this pull request Oct 30, 2024
Open
@ThiruVaithiyaThiruVaithiya mentioned this pull request Oct 30, 2024
Open
@Suriya0802Suriya0802 mentioned this pull request Oct 30, 2024
Open
@Shriv12Shriv12 mentioned this pull request Oct 30, 2024
Open
@Magali0007Magali0007 mentioned this pull request Oct 31, 2024
Open
@Ganesh13349Ganesh13349 mentioned this pull request Oct 31, 2024
Open
@sinnakkrishnansinnakkrishnan mentioned this pull request Nov 1, 2024
Open
@krithika-manoharkrithika-manohar mentioned this pull request Nov 1, 2024
Open
@SAGAYANELSON55SAGAYANELSON55 mentioned this pull request Nov 1, 2024
Open
@swathi-raswathi-ra mentioned this pull request Nov 2, 2024
Open
@HUGO-AppSecHUGO-AppSec mentioned this pull request Nov 3, 2024
Open
@danielsb74danielsb74 mentioned this pull request Nov 5, 2024
Open
@selvaganesh26selvaganesh26 mentioned this pull request Nov 5, 2024
Open
@merkeldevmerkeldev mentioned this pull request Nov 5, 2024
Open
@joedean-gitjoedean-git mentioned this pull request Nov 9, 2024
Open
@MimiDas-SnykMimiDas-Snyk mentioned this pull request Nov 10, 2024
Open
@BenDrKoBenDrKo mentioned this pull request Nov 11, 2024
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@styflestyflestyfle approved these changes
@joshbrucejoshbrucejoshbruce approved these changes
@davisjamdavisjamAwaiting requested review from davisjam

Assignees

No one assigned

Labels

category: blockquotesL0 - securityA security vulnerability within the Marked library is discovered

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

marked(">".repeat(5000)) crashes with recursion error

3 participants

@UziTech@styfle@joshbruce