Skip to content

Link parenthesis - #1509

Merged
UziTech merged 2 commits into
markedjs:masterfrom
UziTech:link-paren
Jul 2, 2019
Merged

Link parenthesis#1509
UziTech merged 2 commits into
markedjs:masterfrom
UziTech:link-paren

Conversation

@UziTech

@UziTechUziTech commented Jul 1, 2019

Copy link
Copy Markdown
Member

Marked version: master

Description

Fix multiple inline links with parenthesis around them

Markdown

([one](http://example.com/1)) ([two](http://example.com/2))

Expected

(one) (two)

Actual

(one (two)

Contributor

  • Test(s) exist to ensure functionality and minimize regression

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@styflestyfle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@UziTech

Copy link
Copy Markdown
MemberAuthor

I found a few more edge cases that were broken and fixed them

@davisjamdavisjam left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No opinion.

@UziTech
UziTech merged commit 6bae3a2 into markedjs:masterJul 2, 2019
@UziTech
UziTech deleted the link-paren branch July 2, 2019 15:43
@UziTechUziTech mentioned this pull request Jul 5, 2019
12 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Last closing round bracket is stripped out from the href

3 participants

@UziTech@styfle@davisjam