Skip to content

Fix GFM Example 116 - #1600

Merged
styfle merged 1 commit into
markedjs:masterfrom
calculuschild:Fix-Example-116
Feb 11, 2020
Merged

Fix GFM Example 116#1600
styfle merged 1 commit into
markedjs:masterfrom
calculuschild:Fix-Example-116

Conversation

@calculuschild

@calculuschildcalculuschild commented Feb 10, 2020•
edited by styfle
Loading

Copy link
Copy Markdown
Contributor

Marked version: 8.0

Markdown flavor: CommonMark & GitHub Flavored Markdown

Description

Also adds tests for detection of these fences if they should or not break paragraphs.

Implementing code as discussed in #1598 (comment)

Contributor

  • Test(s) exist to ensure functionality and minimize regression

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@calculuschild
Fix GFM Example 116
63454d2
Only code fences made from backticks cannot have other backticks in the same line. Fences with tildes can have both tildes and backticks. This allows the tilde case to work correctly.
Also test for detection of these fences as they break or do not break paragraphs.
@vercel

vercelBot commented Feb 10, 2020

Copy link
Copy Markdown

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click on the icon next to each commit.

@calculuschildcalculuschild mentioned this pull request Feb 10, 2020
Merged
4 tasks
UziTech
UziTech approved these changes Feb 11, 2020
View reviewed changes

@UziTechUziTech left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚢

@calculuschild

calculuschild commented Feb 11, 2020

Copy link
Copy Markdown
ContributorAuthor

Cool. Does anything else need to happen to merge this?

calculuschild added a commit to calculuschild/marked that referenced this pull request Feb 11, 2020
@calculuschild
Update fences after tables regex
5972e73
Fences after tables fixed in line with PR markedjs#1600.
@vercel
vercelBot requested a deployment to Preview February 11, 2020 18:06 Abandoned
@vercel

vercelBot commented Feb 11, 2020

Copy link
Copy Markdown

Deployment failed with the following error:

Configuring `regions` is not necessary for Static Files. Deploying Serverless Functions to multiple regions is restricted to paid plans. Upgrade here: https://zeit.co/teams/markedjs/settings/billing.

styfle
styfle approved these changes Feb 11, 2020
View reviewed changes

@styflestyfle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@styfle
styfle merged commit 1f96816 into markedjs:masterFeb 11, 2020
@UziTechUziTech mentioned this pull request Mar 6, 2020
Merged
12 tasks
@rhymesrhymes mentioned this pull request Mar 19, 2020
Merged
This was referenced Mar 21, 2020
Closed
Merged
Merged
Open
Merged
Merged
This was referenced Mar 30, 2020
Open
Open
This was referenced Apr 9, 2020
Merged
Open
Closed
Open
Closed
Merged
Open
Closed
@shyamaaronshyamaaron mentioned this pull request Oct 26, 2024
Open
@Gowtham3223108Gowtham3223108 mentioned this pull request Oct 26, 2024
Open
@udayreddy026udayreddy026 mentioned this pull request Oct 26, 2024
Open
@moamed-syedmoamed-syed mentioned this pull request Oct 27, 2024
Open
@ManPrivateManPrivate mentioned this pull request Oct 27, 2024
Closed
@tdsnyktdsnyk mentioned this pull request Oct 28, 2024
Open
@sri-sankarisri-sankari mentioned this pull request Oct 28, 2024
Open
@mohankumar931mohankumar931 mentioned this pull request Oct 28, 2024
Open
@sound25sound25 mentioned this pull request Oct 29, 2024
Open
@Latha-lgtmLatha-lgtm mentioned this pull request Oct 29, 2024
Open
@GOWTHAMAKURINJIVEANDANGOWTHAMAKURINJIVEANDAN mentioned this pull request Oct 29, 2024
Open
@Dejah2024Dejah2024 mentioned this pull request Oct 30, 2024
Open
@ThiruVaithiyaThiruVaithiya mentioned this pull request Oct 30, 2024
Open
@Suriya0802Suriya0802 mentioned this pull request Oct 30, 2024
Open
@Shriv12Shriv12 mentioned this pull request Oct 30, 2024
Open
@Magali0007Magali0007 mentioned this pull request Oct 31, 2024
Open
@Ganesh13349Ganesh13349 mentioned this pull request Oct 31, 2024
Open
@sinnakkrishnansinnakkrishnan mentioned this pull request Nov 1, 2024
Open
@krithika-manoharkrithika-manohar mentioned this pull request Nov 1, 2024
Open
@SAGAYANELSON55SAGAYANELSON55 mentioned this pull request Nov 1, 2024
Open
@swathi-raswathi-ra mentioned this pull request Nov 2, 2024
Open
@HUGO-AppSecHUGO-AppSec mentioned this pull request Nov 3, 2024
Open
@danielsb74danielsb74 mentioned this pull request Nov 5, 2024
Open
@selvaganesh26selvaganesh26 mentioned this pull request Nov 5, 2024
Open
@merkeldevmerkeldev mentioned this pull request Nov 5, 2024
Open
@joedean-gitjoedean-git mentioned this pull request Nov 9, 2024
Open
@MimiDas-SnykMimiDas-Snyk mentioned this pull request Nov 10, 2024
Open
@BenDrKoBenDrKo mentioned this pull request Nov 11, 2024
Open
tn0ms pushed a commit to warashibe/marked that referenced this pull request May 27, 2026
@styfle
Merge pull requestmarkedjs#1600from calculuschild/Fix-Example-116
918e769
Fix GFM Example 116
tn0ms pushed a commit to warashibe/marked that referenced this pull request May 27, 2026
@calculuschild
Update fences after tables regex
849419c
Fences after tables fixed in line with PR markedjs#1600.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UziTechUziTechUziTech approved these changes
@styflestyflestyfle approved these changes

Assignees

No one assigned

Labels

category: code blocks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@calculuschild@UziTech@styfle