Skip to content

Fix a bug in does not display of the table cell if it empty. - #697

Closed
icm7216 wants to merge 2 commits into
markedjs:masterfrom
icm7216:fix_display_table_cell
Closed

Fix a bug in does not display of the table cell if it empty.#697
icm7216 wants to merge 2 commits into
markedjs:masterfrom
icm7216:fix_display_table_cell

Conversation

@icm7216

Copy link
Copy Markdown

Fix this issue. In the table cell does not display if bottom right corner of the table cell is empty.
This fix#188, fix#476, fix#693, and fixatom/markdown-preview#206

before the fix

before_fix

after the fix

after_fix

@DoumanAsh

Copy link
Copy Markdown

Glad to see that someone already fixed :)
Sad that i didn't find it before i started to look into it...

It is btw shouldn't if the last empty cell has nothing inside(including no spaces)

@DanielSmedegaardBuus

Copy link
Copy Markdown

Why isn't this merged? It's been over 18 months :D

@DanielSmedegaardBuus

Copy link
Copy Markdown

Thanks, @icm7216 !

Since this doesn't seem to be merged anytime soon, I forked marked and merged it into my own fork.

@redfast00redfast00 mentioned this pull request Jul 28, 2017
@redfast00

Copy link
Copy Markdown

Can this or #357 be merged? :D

@joshbruce

Copy link
Copy Markdown
Member

#980

@joshbrucejoshbruce removed this from the 0.4.0 - No known defects milestone Apr 4, 2018
@icm7216

Copy link
Copy Markdown
Author

This issue seems to be solved by #1245. My PR is no longer needed. Thanks everyone.

marked_gfm_table

@icm7216icm7216 closed this May 16, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

6 participants

@icm7216@DoumanAsh@DanielSmedegaardBuus@redfast00@joshbruce@styfle