Skip to content

Added search by place id #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Serhii-Slutskyi wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added search by place id #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c80d692
added search by place_id
Serhii-Slutskyi Jul 15, 2021
4e43c3f
Updated readme
Serhii-Slutskyi Aug 5, 2021
44ec8a6
added comment
Serhii-Slutskyi Aug 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Geocoder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,10 @@ export default Geocoder = {
else if (params[0] instanceof Array)
queryParams = {latlng : `${params[0][0]},${params[0][1]}`};

// {place_id}
else if (params[0] instanceof Object && params[0].hasOwnProperty('place_id'))
queryParams = {place_id : `${params[0].place_id}`};

// {latitude, longitude} or {lat, lng}
else if (params[0] instanceof Object)
queryParams = {latlng : `${params[0].lat || params[0].latitude},${params[0].lng || params[0].longitude}`};
Expand Down
6 changes: 6 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,12 @@ Geocoder.from({

// array
Geocoder.from([41.89, 12.49]);

// object with place_id, provided by Google Places Api
Geocoder.from({
place_id: 'ChIJgUbEo8cfqokR5lP9_Wh_DaM'
});

```

# Error Codes
Expand Down