Skip to content

vector k_i_gain - #772

Closed
smilesun wants to merge 9 commits into
fboptfrom
fbopt_vector_ki_gain
Closed

vector k_i_gain#772
smilesun wants to merge 9 commits into
fboptfrom
fbopt_vector_ki_gain

Conversation

@smilesun

Copy link
Copy Markdown
Collaborator

No description provided.

@codecov-commenter

codecov-commenter commented Feb 1, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 103 lines in your changes are missing coverage. Please review.

Comparison is base (154ac0b) 92.85% compared to head (8e5926d) 92.84%.
Report is 725 commits behind head on fbopt.

FilesPatch %Lines
domainlab/utils/generate_fbopt_phase_portrait.py0.00%40 Missing ⚠️
domainlab/algos/trainers/compos/matchdg_match.py87.23%6 Missing ⚠️
domainlab/algos/trainers/train_matchdg.py95.20%6 Missing ⚠️
domainlab/models/a_model_classif.py90.24%4 Missing ⚠️
domainlab/algos/trainers/fbopt_mu_controller.py90.00%3 Missing ⚠️
domainlab/algos/trainers/train_fbopt_b.py83.33%3 Missing ⚠️
domainlab/algos/builder_custom.py87.50%2 Missing ⚠️
domainlab/algos/trainers/fbopt_setpoint_ada.py90.00%2 Missing ⚠️
domainlab/algos/trainers/train_fishr.py96.92%2 Missing ⚠️
domainlab/algos/trainers/zoo_trainer.py88.88%2 Missing ⚠️
... and 24 more
Additional details and impacted files
@@ Coverage Diff @@## fbopt #772 +/- ##
==========================================
- Coverage 92.85% 92.84% -0.01% 
==========================================
Files 136 135 -1 Lines 5400 5605 +205 ==========================================
+ Hits 5014 5204 +190 - Misses 386 401 +15 
FlagCoverage Δ
unittests92.84% <93.71%> (-0.01%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smilesun
smilesun requested a review from ntchenFebruary 1, 2024 18:41
@smilesun

Copy link
Copy Markdown
CollaboratorAuthor

this code has bug, see #880

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@smilesun@codecov-commenter