Skip to content

Gamma reg collision test if different gamma is set correctly - #847

Draft
smilesun wants to merge 7 commits into
masterfrom
gamma_reg_collision_test
Draft

Gamma reg collision test if different gamma is set correctly#847
smilesun wants to merge 7 commits into
masterfrom
gamma_reg_collision_test

Conversation

@smilesun

Copy link
Copy Markdown
Collaborator

No description provided.

@smilesunsmilesun self-assigned this Jul 2, 2024
@smilesun
smilesun changed the base branch from master to gamma_reg_collisionJuly 2, 2024 14:41
@smilesun
smilesun marked this pull request as draft July 2, 2024 14:41
@smilesun

smilesun commented Jul 2, 2024

Copy link
Copy Markdown
CollaboratorAuthor

running

https://github.com/marrlab/DomainLab/pull/847/files

error is:

> exp = Exp(margs) tests/test_composite_reg_cmd.py:18: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
domainlab/exp/exp_main.py:30: in __init__ self.task = TaskChainNodeGetter(args)() domainlab/tasks/zoo_tasks.py:47: in __call__ node = chain.handle(self.request) domainlab/compos/pcr/p_chain_handler.py:89: in handle return self._success_node.handle(request) _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
self = <domainlab.tasks.task_mnist_color.NodeTaskMNISTColor10 object at 0x7f1b1e724ca0>, request = None
def handle(self, request):
"""This method invoke self.is_myjob() to check which node in the chain should handle the
request
:param request: subclass can override request object to be string or function
:return: light weight AbstractChainNodeHandler
"""
if self.is_myjob(request):
return self
if self._success_node is not None:
return self._success_node.handle(request)
err_msg = "option " + str(request) + " does not exist"
E NotImplementedError: option None does not exist
domainlab/compos/pcr/p_chain_handler.py:95: NotImplementedError

Base automatically changed from gamma_reg_collision to masterJuly 2, 2024 14:53
@smilesun

Copy link
Copy Markdown
CollaboratorAuthor

strange, testing the same yaml file with command line works through.

https://github.com/marrlab/DomainLab/blob/faf7589abf34e2901678b9b6eabfa585ab237851/.github/workflows/ci.yml#L45C48-L45C91

@smilesun
smilesun requested a review from agisgaJuly 2, 2024 14:57
@smilesun

Copy link
Copy Markdown
CollaboratorAuthor

FAILED tests/test_composite_reg_cmd.py::test_parse_yml_args - NotImplementedE...

@smilesun

Copy link
Copy Markdown
CollaboratorAuthor

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@smilesun