Uh oh!
There was an error while loading. Please reload this page.
decoupling from mathics.builtin.builtins - #1155
Closed
mmatera wants to merge 6 commits into
Closed
Conversation
rocky
reviewed
Feb 21, 2021
Uh oh!
There was an error while loading. Please reload this page.
mmatera
commented
Mar 4, 2021
ContributorAuthor
Already included in PR #1140 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has the aim of continuing to remove hard-linked objects in the mathics core. In particular, this removes mathics.builtin.builtins
This dictionary was used in some formating operations, the definition of certain Test symbols, and in the doctest mechanism. The problem with this comes up when we implemented the pymathics mechanism. Then, to fulfill the functionality of true built-in symbols, the global dictionary should be modified, which also has consequences if we want to make to coexist two instances of MathicsSession objects.
In any case, with the present changes, this global object would be not necessary anymore.