Uh oh!
There was an error while loading. Please reload this page.
Resolve merge conflicts with master - #1255
Merged
Merged
Conversation
That is, in a way that doesn't depend on OS characteristics or specifics of how Compress compresses things. Simplify test/helper.py and remove unused imports. BTW: I think ToString should be the exception not the rule. In other words the defaults to_string_expr and to_string_expected should be opposite of what it currently is.
Handle Compress/Uncompress checks better..
Use Symbol{True,False,Null} more; lint sparse.pyIt's a small thing, but that's what it is called in Mathics - Clarify, Simplify.
same -> sameQ; do_compare -> equal2
Sorted file names
Processing comments in Read Expression
do_comparison -> equal2 l1, l2 -> lhs, rhs Use newer test helper and Compress/Uncompress test
rockyforce-pushed
the
fixcomparison-rebase
branch
from
April 11, 2021 00:07
478e8e5 to
5ddf614Comparerockyforce-pushed
the
fixcomparison-rebase
branch
from
April 11, 2021 00:18
19a452d to
a047b46Comparerockyforce-pushed
the
fixcomparison-rebase
branch
from
April 11, 2021 00:22
a047b46 to
32d130aComparerocky
commented
Apr 11, 2021
MemberAuthor
@mmatera If this clears CI, this should be an equivalent to a rebase to a master with a couple more variable renamings. There will be another branch off of this to try to modularize and simplify this code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.