Skip to content

Set $InputFileName on mathics_open() - #1304

Merged
mmatera merged 3 commits into
masterfrom
set-$InputFileName
Apr 28, 2021
Merged

Set $InputFileName on mathics_open()#1304
mmatera merged 3 commits into
masterfrom
set-$InputFileName

Conversation

@rocky

Copy link
Copy Markdown
Member

TODO write a test for this.

@rocky
rocky requested a review from mmateraApril 22, 2021 19:43
@rocky
rocky marked this pull request as draft April 22, 2021 19:43
@rockyrocky mentioned this pull request Apr 22, 2021
@mmatera

Copy link
Copy Markdown
Contributor

I think the test would be the one that motivated this PR. If that test passes, then we can implement it later in the test engine.

@mmaterammatera left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmatera
mmatera marked this pull request as ready for review April 28, 2021 02:36
@mmatera

Copy link
Copy Markdown
Contributor

LGTM

I included a simple test for $InputFileName. If passes in all the platforms, I think that this is ready for merging.

@mmatera
mmatera merged commit 41a3c30 into masterApr 28, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@rocky@mmatera