Circle2D intersection with Line(Segment)2D by f-frhs · Pull Request #237 · mathnet/mathnet-spatial

f-frhs · 2023-11-25T11:36:33Z

I implemented the code to calculate the intersection of the circle with the line, specifically,

intersection of Circle2D with Line2D
intersection of Circle2D with LineSegment2D

It will be nice if we can discuss whether the testcases are sufficient or not.

this task is based on the comment in #186:

I think it would be useful to have additional methods, like
intersection of sphere with line/ray
intersection of sphere with plane
intersection of sphere with another sphere
functions which check if a point lies inside/on/outside of the circle

Originally posted by @jkalias in #186 (comment)

Aleady existing test cases must be changed because of the implementation of FindRoots.Polynomial(coeffs), that is, the order of the solutions.

This reverts commit 0a2521d.

jkalias

Naming

jkalias · 2023-12-01T20:30:30Z

+ var d = line.Direction;
+ var r = this.Radius;
+
+ var a = 1d;


var a = 1.0;

Could you tell me what the difference is between var a = 1.0 and var a = 1d?
If this repo has coding conventions, I failed to read the doc. I will read it and fix this.
Thanks for the comment.

I feel that var a = 1d; is a bit like C of Fortran, that's all. I wouldn't reject a PR based on this.

Thanks for the comment.
I respect your feeling, and I will fix this.

done in the commit f-frhs@0e7eb69

…to the circle

for the case where LineSegment contains some of obtained intersections.

- parallel to X-axis - parallel to Y-axis - general cases (eg. x-y+c=0) test: rename method's name

f-frhs · 2023-12-09T11:00:51Z

Could you tell me which requrest remains?
I lost myself in this PR.

jkalias · 2023-12-09T11:01:26Z

Thank you for your effort and time!

f-frhs · 2023-12-09T11:05:41Z

Thank YOU for your patience.
It was a nice time for me.

f-frhs added 5 commits November 23, 2023 22:11

Feat: Line2D.DistanceTo(point)
0a2521d

feat: Circle2D.IntersectWith(Line2D)
c3ad590

doc: fix xml comment
037d3c5

refactor: extract the private method findParameterTs(Line2D)
fb0314b
Aleady existing test cases must be changed because of the implementation of FindRoots.Polynomial(coeffs), that is, the order of the solutions.

feat: Circle2D.IntersectWith(LineSegment2D)
baf6605

jkalias requested changes Nov 27, 2023
View reviewed changes

f-frhs added 5 commits November 28, 2023 22:46

doc: fix the variable-name list in comment
c2612b6

fix: a typo
4685302

change: use the fact that dot-product of the unit vector is always 1.0
f3e4731

Revert "Feat: Line2D.DistanceTo(point)"
847cdaf
This reverts commit 0a2521d.

remove: src/Spatial/Extensions/DoubleExtensions.cs
2d222ac

jkalias requested changes Nov 29, 2023
View reviewed changes

Comment threadsrc/Spatial/Euclidean/Circle2D.cs Outdated
Comment threadsrc/Spatial/Euclidean/Circle2D.cs Outdated

jkalias requested changes Nov 30, 2023
View reviewed changes

Comment threadsrc/Spatial.Tests/Euclidean/Circle2DTests.cs Outdated
Comment threadsrc/Spatial.Tests/Euclidean/Circle2DTests.cs Outdated

f-frhs added 2 commits December 1, 2023 14:40

doc: revise xml comments
571cf7d

fix a typo
9e33c1b

jkalias reviewed Dec 1, 2023
View reviewed changes

f-frhs added 5 commits December 3, 2023 16:04

test: fix testcases to test number of intersections
7c5df6a

fix: IntersectionWith() to return a single point when a line tangent …
1a527b1
…to the circle

test: Add tests for intersection of Circle and LineSegment2D
b27fdb1
for the case where LineSegment contains some of obtained intersections.

test: add TODO comment
dc7ea85

refactor: rename line to segment
5930b12

jkalias reviewed Dec 3, 2023
View reviewed changes

Comment threadsrc/Spatial.Tests/Euclidean/Circle2DTests.cs Outdated

jkalias reviewed Dec 3, 2023
View reviewed changes

Comment threadsrc/Spatial.Tests/Euclidean/Circle2DTests.cs Outdated

jkalias reviewed Dec 3, 2023
View reviewed changes

Comment threadsrc/Spatial.Tests/Euclidean/Circle2DTests.cs Outdated

jkalias reviewed Dec 3, 2023
View reviewed changes

Comment threadsrc/Spatial.Tests/Euclidean/Circle2DTests.cs Outdated

f-frhs added 5 commits December 7, 2023 12:07

fix: type declaration (from 1d to 1.0)
0e7eb69

test: fix testcases to use expected points
5c3cd70

test: fix testcases to use expected points
ab59a23

test: add testcases where the line is parallel to the Y-axis
451a87d

test: add testcases parallel to Y-axis and general cases
3d3748b

f-frhs added 2 commits December 7, 2023 18:45

test: add testcases for Intersection of Circle2D with LIneSegment2D
6b8c3db
- parallel to X-axis - parallel to Y-axis - general cases (eg. x-y+c=0) test: rename method's name

test: replace +01 to +1
f3815ed

f-frhs force-pushed the Circle2D_Intersection branch from 4081b03 to f3815edCompare December 7, 2023 09:45

Minor changes in test
acccdbf

f-frhs requested a review from jkalias December 9, 2023 10:54

jkalias merged commit 9a40b9f into mathnet:masterDec 9, 2023

f-frhs deleted the Circle2D_Intersection branch December 25, 2023 15:47

Uh oh!

Conversation

f-frhs commented Nov 25, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jkalias left a comment

Choose a reason for hiding this comment

Uh oh!

jkaliasDec 1, 2023

Choose a reason for hiding this comment

Uh oh!

f-frhsDec 3, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jkaliasDec 3, 2023

Choose a reason for hiding this comment

Uh oh!

f-frhsDec 6, 2023

Choose a reason for hiding this comment

Uh oh!

f-frhsDec 7, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

f-frhs commented Dec 9, 2023

Uh oh!

jkalias commented Dec 9, 2023

Uh oh!

f-frhs commented Dec 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

f-frhs commented Nov 25, 2023•
edited
Loading

f-frhsDec 3, 2023•
edited
Loading