Uh oh!
There was an error while loading. Please reload this page.
Ensure many batches are able to be imported (MSC2716) - #212
Closed
MadLittleMods wants to merge 4 commits into
Closed
Ensure many batches are able to be imported (MSC2716)#212MadLittleMods wants to merge 4 commits into
MadLittleMods wants to merge 4 commits into
Conversation
MadLittleMods
marked this pull request as draft
October 13, 2021 03:38
MadLittleMods
marked this pull request as ready for review
October 13, 2021 03:57
…s-work Conflicts: tests/msc2716_test.go
| "dir": []string{"b"}, | ||
| "limit": []string{"100"}, | ||
| })) | ||
| }) |
ContributorAuthor
There was a problem hiding this comment.
Maybe move this down one more test
kegsay
reviewed
Oct 21, 2021
| } | ||
| // Ensure the /message response gives a 200 | ||
| alice.MustDoFunc(t, "GET", []string{"_matrix", "client", "r0", "rooms", roomID, "messages"}, client.WithContentType("application/json"), client.WithQueries(url.Values{ |
Member
There was a problem hiding this comment.
It would be nice to assert the number of events returned too, and that they have different event IDs.
ContributorAuthor
There was a problem hiding this comment.
👍 Going to close this one in favor of #214 which actually checks for all of the messages in the batches
kegsay
approved these changes
Oct 21, 2021
MadLittleMods
commented
Nov 2, 2021
ContributorAuthor
Thanks for the review @kegsay 🦎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure many batches are able to be imported and
/messagesstill gives us a 200 OK.Used to reproduce https://gitlab.com/gitterHQ/webapp/-/merge_requests/2229#note_665906390 which led to the fix in Synapse, matrix-org/synapse#11027.
Part of MSC2716: matrix-org/matrix-spec-proposals#2716