Uh oh!
There was an error while loading. Please reload this page.
4311 stripped state create event - #871
Conversation
but extra fields shouldn't be there
787b2fc to
3653b4bCompare| // find the create event: MSC4311 requires it to be present, but clients | ||
| // still receive it in stripped state format (no extra fields) |
There was a problem hiding this comment.
I think that there was a small error in
TestMSC4311FullCreateEventOnStrippedState,
Yes, this test is flawed but there are two distinct pieces to MSC4311:
- Ensuring the
m.room.createevent is included in the client API (stripped state) - Ensuring all state events in the federation API are using full PDU including the
m.room.createwhich is required.
#796 fixes the second issue.
The first issue doesn't have a good test yet and I don't think this test is necessarily a "good" test. It looks like you've adapted what's here 👍 but it could be better. For example, even the test name here needs updating. And we could some of the same must.MatchGJSON(...) assertions here instead of these for loops. Also can be simplified to not use federation at all, etc, etc, etc.
There was a problem hiding this comment.
Overall, this is probably something we can tackle in #796
I think that there was a small error in
TestMSC4311FullCreateEventOnStrippedState, the test was checking for extra fields in a stripped event while they shouldn't be thereComes with element-hq/synapse#19749
Pull Request Checklist
Signed-off-by: Thomas Traineau t.traineau@famedly.com