You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
(useful for third party authentication in some matrix deployments).
Hi, for some matrix instances (for example Thalès Citadel), it is necessary to use an auth string that is somewhat different.
This PR for letting users define their own auth-string.
Shall changes be needed, please do not hesitate to let me know.
Hi @clouetb - thank you for the PR. You may know that this library is not the suggested Python SDK for Matrix - you should consider using https://github.com/poljar/matrix-nio, which is far more actively maintained. It's also more feature-rich.
Hi,
I realized this after sending my PR on matrix-python-sdk (which was the one
proposed by Thalès...).
Then I proposed another PR on matrix-nio :
matrix-nio/matrix-nio#105 which was accepted;
Anyway, thank you for your reply.
On Mon, Mar 2, 2020 at 3:56 PM Ben Parsons ***@***.***> wrote:
Hi @clouetb <https://github.com/clouetb> - thank you for the PR. You may
know that this library is not the suggested Python SDK for Matrix - you
should consider using https://github.com/poljar/matrix-nio, which is far
more actively maintained. It's also more feature-rich.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#314?email_source=notifications&email_token=AAE33BIAI2HFD6SGT53EPU3RFPCJTA5CNFSM4K6XNWGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENPTMKQ#issuecomment-593442346>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE33BNJ2UDF4465O5X4GBLRFPCJTANCNFSM4K6XNWGA>
.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(useful for third party authentication in some matrix deployments).
Hi, for some matrix instances (for example Thalès Citadel), it is necessary to use an auth string that is somewhat different.
This PR for letting users define their own auth-string.
Shall changes be needed, please do not hesitate to let me know.