Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Changes.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## next release

- Fixed a `-Wsign-compare` warning in `MMDB_open()` that broke builds with
`-Werror` on platforms where `ssize_t` is 32 bits, such as i686. Pull request
by Robert Scheck. GitHub #487.

## 1.14.0 - 2026-09-08

- Bounded the resources that `MMDB_get_entry_data_list()` spends decoding a
Expand Down
6 changes: 3 additions & 3 deletions src/maxminddb.c
Original file line number Diff line number Diff line change
Expand Up @@ -374,9 +374,9 @@ int MMDB_open(const char *const filename, uint32_t flags, MMDB_s *const mmdb) {
mmdb->data_section_size = (uint32_t)data_section_size;

// Although it is likely not possible to construct a database with valid
// valid metadata, as parsed above, and a data_section_size less than 3,
// we do this check as later we assume it is at least three when doing
// bound checks.
// metadata, as parsed above, and a data_section_size less than 3, we do
// this check as later we assume it is at least three when doing bound
// checks.
if (mmdb->data_section_size < 3) {
status = MMDB_INVALID_DATA_ERROR;
goto cleanup;
Expand Down
Loading