Add --debug flag to display Gmail search URL - #409
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
7998f7d to
0d985deCompareizidormatusov
commented
Jul 13, 2024
I have resolved the comments and added tests. Please have a look again |
There was a problem hiding this comment.
Looks good, thanks! And sorry for the delay in reviewing.
Please fix the lint errors and then we're good to merge.
izidormatusov
commented
Jul 17, 2024
I have run |
mbrt
commented
Jul 18, 2024
Uhm, @izidormatusov it looks like the check still fails. Could you double check? |
When creating a complicated search criteria, it can be helpful to verify that it matches the emails. If you specify `--debug` on diff, apply, edit commands, URL to Gmail search will be displayed in the diff. Fixesmbrt#407
izidormatusov
commented
Jul 18, 2024
Forgot to add the formatted files into the commit 🤦 Should be fixed now |
mbrt
commented
Jul 18, 2024
More files need to be fixed. I suggest running |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## master #409 +/- ##
==========================================
+ Coverage 65.67% 66.55% +0.87%
==========================================
Files 20 20 Lines 2025 2051 +26 ==========================================
+ Hits 1330 1365 +35 + Misses 609 599 -10 - Partials 86 87 +1 ☔ View full report in Codecov by Sentry. |
mbrt
commented
Jul 18, 2024
Ah, nevermind. I could fix it myself quickly. Thanks for the contribution! |
When creating a complicated search criteria, it can be helpful to verify that it matches the emails. If you specify
--debugon diff, apply, edit commands, URL to Gmail search will be displayed in the diff.Fixes#407