Skip to content

ci: add GitHub Actions workflow for PR checks - #2

Closed
greg3d wants to merge 2 commits into
masterfrom
add-ci-checks
Closed

ci: add GitHub Actions workflow for PR checks#2
greg3d wants to merge 2 commits into
masterfrom
add-ci-checks

Conversation

@greg3d

Copy link
Copy Markdown
Contributor

Summary

Adds a minimal GitHub Actions workflow at `.github/workflows/ci.yml` that runs the mocha suite on every push to master and every PR against master.

Setup

  • Matrix: Node 18, 20, 22
  • Steps: `actions/checkout@v4` → `actions/setup-node@v4` → `npm install` → `npm test`
  • `fail-fast: false` so all matrix legs report independently

Why this minimal shape

  • No lockfile in the repo (intentional for a library), so no `cache: npm` and no `npm ci`.
  • 9 mocha specs, ~1 s suite — no need for parallelism, sharding, or caching.

Follow-ups (out of scope)

Once green, this workflow can be marked as a required status check in the repo branch protection settings.

Test plan

  • Workflow runs successfully on this PR (all three matrix legs green)

greg3dand others added 2 commits May 17, 2026 20:50
Runs the mocha suite on every push to master and every PR against
master, across Node 20 and 22 (current active LTS).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
CopilotAI review requested due to automatic review settings May 17, 2026 17:54

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a minimal GitHub Actions CI workflow to run the project’s Mocha test suite for pushes to master and PRs targeting master, ensuring basic automated checks run consistently across supported Node versions.

Changes:

  • Introduces a CI workflow triggered on push/pull_request for the master branch.
  • Runs npm install and npm test across a Node version matrix (18, 20, 22) with fail-fast: false.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@greg3dgreg3d self-assigned this May 17, 2026
@greg3d
greg3d requested a review from erezmceMay 17, 2026 18:25
@greg3d

Copy link
Copy Markdown
ContributorAuthor

Superseded by #3 — consolidated into a single PR per request. The workflow lives on publish-readiness now, upgraded to use npm ci + cache: npm against the committed lockfile.

@greg3dgreg3d closed this May 17, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@greg3d