Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
# 1.6.7
- Added optional substring exempt path matching when `exempt_prefix_match` is `True`

# 1.6.6
- Support long-lived connections in ASGI middleware

Expand Down
8 changes: 6 additions & 2 deletions mauth_client/middlewares/asgi.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,16 +19,17 @@
)
from mauth_client.signable import RequestSignable
from mauth_client.signed import Signed
from mauth_client.utils import decode
from mauth_client.utils import decode, is_exempt_request_path

logger = logging.getLogger("mauth_asgi")


class MAuthASGIMiddleware:
def __init__(self, app: ASGI3Application, exempt: Optional[set] = None) -> None:
def __init__(self, app: ASGI3Application, exempt: Optional[set] = None, exempt_prefix_match: bool = False) -> None:
self._validate_configs()
self.app = app
self.exempt = exempt.copy() if exempt else set()
self.exempt_prefix_match = exempt_prefix_match

async def __call__(
self, scope: Scope, receive: ASGIReceiveCallable, send: ASGISendCallable
Expand All@@ -40,6 +41,9 @@ async def __call__(
if path in self.exempt:
return await self.app(scope, receive, send)

if self.exempt_prefix_match and is_exempt_request_path(path, self.exempt):
return await self.app(scope, receive, send)

query_string = scope["query_string"]
url = f"{path}?{decode(query_string)}" if query_string else path
headers = {decode(k): decode(v) for k, v in scope["headers"]}
Expand Down
7 changes: 6 additions & 1 deletion mauth_client/middlewares/wsgi.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,22 +14,27 @@

from mauth_client.signable import RequestSignable
from mauth_client.signed import Signed
from mauth_client.utils import is_exempt_request_path

logger = logging.getLogger("mauth_wsgi")


class MAuthWSGIMiddleware:
def __init__(self, app, exempt=None):
def __init__(self, app, exempt=None, exempt_prefix_match=False):
self._validate_configs()
self.app = app
self.exempt = exempt.copy() if exempt else set()
self.exempt_prefix_match = exempt_prefix_match

def __call__(self, environ, start_response):
path = environ.get("PATH_INFO", "")

if path in self.exempt:
return self.app(environ, start_response)

if self.exempt_prefix_match and is_exempt_request_path(path, self.exempt):
return self.app(environ, start_response)

signable = RequestSignable(
method=environ["REQUEST_METHOD"],
url=self._extract_url(environ),
Expand Down
33 changes: 33 additions & 0 deletions mauth_client/utils.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -32,3 +32,36 @@ def decode(byte_string: bytes) -> str:
except UnicodeDecodeError:
encoding = charset_normalizer.detect(byte_string)["encoding"]
return byte_string.decode(encoding)


def is_exempt_request_path(path: str, exempt: set) -> bool:
"""
Check if a request path should be exempt from authentication based on prefix matching.

This function performs prefix matching with path separator boundary checking to prevent
false positives. A path matches an exempt prefix only if it starts with the exempt path
followed by a path separator ('/').

:param str path: The request path to check (e.g., '/health/live', '/api/users')
:param set exempt: Set of exempt path prefixes (e.g., {'/health', '/metrics'})
:return: True if the path matches any exempt prefix, False otherwise
:rtype: bool

Examples:
Matching cases (returns True):
- path='/health/live', exempt={'/health'} -> True
- path='/health/ready', exempt={'/health'} -> True
- path='/metrics/prometheus', exempt={'/metrics'} -> True

Non-matching cases (returns False):
- path='/health', exempt={'/health'} -> False (exact match without trailing slash)
- path='/api-admin', exempt={'/api'} -> False (not a path separator boundary)
- path='/app_status_admin', exempt={'/app_status'} -> False (underscore, not separator)
- path='/healthcare', exempt={'/health'} -> False (different path)
"""
for exempt_path in exempt:
# Exact match or prefix match with path separator
# For instance this prevents /api matching /api-admin or /app_status matching /app_status_admin
if path.startswith(exempt_path.rstrip('/') + '/'):
return True
return False
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "mauth-client"
version = "1.6.6"
version = "1.6.7"
description = "MAuth Client for Python"
repository = "https://github.com/mdsol/mauth-client-python"
authors = ["Medidata Solutions <support@mdsol.com>"]
Expand Down
76 changes: 76 additions & 0 deletions tests/middlewares/asgi_test.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -278,3 +278,79 @@ async def mock_receive():
self.assertEqual(call_order[0], ("body", "http.request"))
self.assertEqual(call_order[1], ("disconnect", "http.disconnect"))
self.assertEqual(receive_calls, 2) # Called once for auth, once from app


class TestMAuthASGIMiddlewareWithPrefixMatch(unittest.TestCase):
def setUp(self):
self.app_uuid = str(uuid4())
Config.APP_UUID = self.app_uuid
Config.MAUTH_URL = "https://mauth.com"
Config.MAUTH_API_VERSION = "v1"
Config.PRIVATE_KEY = "key"

self.app = FastAPI()
self.app.add_middleware(
MAuthASGIMiddleware,
exempt={"/health", "/metrics"},
exempt_prefix_match=True
)

@self.app.get("/")
async def root():
return {"msg": "authenticated"}

@self.app.get("/health")
async def health_exact():
return {"msg": "exact health"}

@self.app.get("/health/live")
async def health_live():
return {"msg": "health live"}

@self.app.get("/health/ready")
async def health_ready():
return {"msg": "health ready"}

@self.app.get("/metrics/prometheus")
async def metrics():
return {"msg": "metrics"}

@self.app.get("/api/health")
async def api_health():
return {"msg": "api health"}

self.client = TestClient(self.app)

def test_prefix_match_allows_nested_paths(self):
"""Test that nested paths under exempt prefix are allowed"""
response = self.client.get("/health/live")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"msg": "health live"})

response = self.client.get("/health/ready")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"msg": "health ready"})

response = self.client.get("/metrics/prometheus")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"msg": "metrics"})

def test_prefix_match_blocks_similar_paths(self):
"""Test that similar but non-matching paths are still blocked"""
response = self.client.get("/api/health")
self.assertEqual(response.status_code, 401)

def test_prefix_match_allows_exact_match_in_exempt_set(self):
"""Test that exact match in exempt set is allowed (from exact match check)"""
response = self.client.get("/health")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"msg": "exact health"})

@patch.object(LocalAuthenticator, "is_authentic")
def test_prefix_match_still_authenticates_non_exempt_paths(self, is_authentic_mock):
"""Test that non-exempt paths still require authentication"""
is_authentic_mock.return_value = (True, 200, "")

response = self.client.get("/")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"msg": "authenticated"})
76 changes: 76 additions & 0 deletions tests/middlewares/wsgi_test.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -192,3 +192,79 @@ def post_test():

self.assertEqual(response.status_code, 200)
self.assertEqual(response.json, body)


class TestMAuthWSGIMiddlewareWithPrefixMatch(unittest.TestCase):
def setUp(self):
self.app_uuid = str(uuid4())
Config.APP_UUID = self.app_uuid
Config.MAUTH_URL = "https://mauth.com"
Config.MAUTH_API_VERSION = "v1"
Config.PRIVATE_KEY = "key"

self.app = Flask("Test App")
self.app.wsgi_app = MAuthWSGIMiddleware(
self.app.wsgi_app,
exempt={"/health", "/metrics"},
exempt_prefix_match=True
)

@self.app.get("/")
def root():
return "authenticated!"

@self.app.get("/health")
def health_exact():
return "exact health"

@self.app.get("/health/live")
def health_live():
return "health live"

@self.app.get("/health/ready")
def health_ready():
return "health ready"

@self.app.get("/metrics/prometheus")
def metrics():
return "metrics"

@self.app.get("/api/health")
def api_health():
return "api health"

self.client = self.app.test_client()

def test_prefix_match_allows_nested_paths(self):
"""Test that nested paths under exempt prefix are allowed"""
response = self.client.get("/health/live")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_data(as_text=True), "health live")

response = self.client.get("/health/ready")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_data(as_text=True), "health ready")

response = self.client.get("/metrics/prometheus")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_data(as_text=True), "metrics")

def test_prefix_match_blocks_similar_paths(self):
"""Test that similar but non-matching paths are still blocked"""
response = self.client.get("/api/health")
self.assertEqual(response.status_code, 401)

def test_prefix_match_allows_exact_match_in_exempt_set(self):
"""Test that exact match in exempt set is allowed (from exact match check)"""
response = self.client.get("/health")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_data(as_text=True), "exact health")

@patch.object(LocalAuthenticator, "is_authentic")
def test_prefix_match_still_authenticates_non_exempt_paths(self, is_authentic_mock):
"""Test that non-exempt paths still require authentication"""
is_authentic_mock.return_value = (True, 200, "")

response = self.client.get("/")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_data(as_text=True), "authenticated!")
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
# 1.6.7
- Added optional substring exempt path matching when `exempt_prefix_match` is `True`

# 1.6.6
- Support long-lived connections in ASGI middleware

Expand Down
8 changes: 6 additions & 2 deletions mauth_client/middlewares/asgi.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,16 +19,17 @@
)
from mauth_client.signable import RequestSignable
from mauth_client.signed import Signed
from mauth_client.utils import decode
from mauth_client.utils import decode, is_exempt_request_path

logger = logging.getLogger("mauth_asgi")


class MAuthASGIMiddleware:
def __init__(self, app: ASGI3Application, exempt: Optional[set] = None) -> None:
def __init__(self, app: ASGI3Application, exempt: Optional[set] = None, exempt_prefix_match: bool = False) -> None:
self._validate_configs()
self.app = app
self.exempt = exempt.copy() if exempt else set()
self.exempt_prefix_match = exempt_prefix_match

async def __call__(
self, scope: Scope, receive: ASGIReceiveCallable, send: ASGISendCallable
Expand All@@ -40,6 +41,9 @@ async def __call__(
if path in self.exempt:
return await self.app(scope, receive, send)

if self.exempt_prefix_match and is_exempt_request_path(path, self.exempt):
return await self.app(scope, receive, send)

query_string = scope["query_string"]
url = f"{path}?{decode(query_string)}" if query_string else path
headers = {decode(k): decode(v) for k, v in scope["headers"]}
Expand Down
7 changes: 6 additions & 1 deletion mauth_client/middlewares/wsgi.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,22 +14,27 @@

from mauth_client.signable import RequestSignable
from mauth_client.signed import Signed
from mauth_client.utils import is_exempt_request_path

logger = logging.getLogger("mauth_wsgi")


class MAuthWSGIMiddleware:
def __init__(self, app, exempt=None):
def __init__(self, app, exempt=None, exempt_prefix_match=False):
self._validate_configs()
self.app = app
self.exempt = exempt.copy() if exempt else set()
self.exempt_prefix_match = exempt_prefix_match

def __call__(self, environ, start_response):
path = environ.get("PATH_INFO", "")

if path in self.exempt:
return self.app(environ, start_response)

if self.exempt_prefix_match and is_exempt_request_path(path, self.exempt):
return self.app(environ, start_response)

signable = RequestSignable(
method=environ["REQUEST_METHOD"],
url=self._extract_url(environ),
Expand Down
33 changes: 33 additions & 0 deletions mauth_client/utils.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -32,3 +32,36 @@ def decode(byte_string: bytes) -> str:
except UnicodeDecodeError:
encoding = charset_normalizer.detect(byte_string)["encoding"]
return byte_string.decode(encoding)


def is_exempt_request_path(path: str, exempt: set) -> bool:
"""
Check if a request path should be exempt from authentication based on prefix matching.

This function performs prefix matching with path separator boundary checking to prevent
false positives. A path matches an exempt prefix only if it starts with the exempt path
followed by a path separator ('/').

:param str path: The request path to check (e.g., '/health/live', '/api/users')
:param set exempt: Set of exempt path prefixes (e.g., {'/health', '/metrics'})
:return: True if the path matches any exempt prefix, False otherwise
:rtype: bool

Examples:
Matching cases (returns True):
- path='/health/live', exempt={'/health'} -> True
- path='/health/ready', exempt={'/health'} -> True
- path='/metrics/prometheus', exempt={'/metrics'} -> True

Non-matching cases (returns False):
- path='/health', exempt={'/health'} -> False (exact match without trailing slash)
- path='/api-admin', exempt={'/api'} -> False (not a path separator boundary)
- path='/app_status_admin', exempt={'/app_status'} -> False (underscore, not separator)
- path='/healthcare', exempt={'/health'} -> False (different path)
"""
for exempt_path in exempt:
# Exact match or prefix match with path separator
# For instance this prevents /api matching /api-admin or /app_status matching /app_status_admin
if path.startswith(exempt_path.rstrip('/') + '/'):
return True
return False
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "mauth-client"
version = "1.6.6"
version = "1.6.7"
description = "MAuth Client for Python"
repository = "https://github.com/mdsol/mauth-client-python"
authors = ["Medidata Solutions <support@mdsol.com>"]
Expand Down
76 changes: 76 additions & 0 deletions tests/middlewares/asgi_test.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -278,3 +278,79 @@ async def mock_receive():
self.assertEqual(call_order[0], ("body", "http.request"))
self.assertEqual(call_order[1], ("disconnect", "http.disconnect"))
self.assertEqual(receive_calls, 2) # Called once for auth, once from app


class TestMAuthASGIMiddlewareWithPrefixMatch(unittest.TestCase):
def setUp(self):
self.app_uuid = str(uuid4())
Config.APP_UUID = self.app_uuid
Config.MAUTH_URL = "https://mauth.com"
Config.MAUTH_API_VERSION = "v1"
Config.PRIVATE_KEY = "key"

self.app = FastAPI()
self.app.add_middleware(
MAuthASGIMiddleware,
exempt={"/health", "/metrics"},
exempt_prefix_match=True
)

@self.app.get("/")
async def root():
return {"msg": "authenticated"}

@self.app.get("/health")
async def health_exact():
return {"msg": "exact health"}

@self.app.get("/health/live")
async def health_live():
return {"msg": "health live"}

@self.app.get("/health/ready")
async def health_ready():
return {"msg": "health ready"}

@self.app.get("/metrics/prometheus")
async def metrics():
return {"msg": "metrics"}

@self.app.get("/api/health")
async def api_health():
return {"msg": "api health"}

self.client = TestClient(self.app)

def test_prefix_match_allows_nested_paths(self):
"""Test that nested paths under exempt prefix are allowed"""
response = self.client.get("/health/live")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"msg": "health live"})

response = self.client.get("/health/ready")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"msg": "health ready"})

response = self.client.get("/metrics/prometheus")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"msg": "metrics"})

def test_prefix_match_blocks_similar_paths(self):
"""Test that similar but non-matching paths are still blocked"""
response = self.client.get("/api/health")
self.assertEqual(response.status_code, 401)

def test_prefix_match_allows_exact_match_in_exempt_set(self):
"""Test that exact match in exempt set is allowed (from exact match check)"""
response = self.client.get("/health")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"msg": "exact health"})

@patch.object(LocalAuthenticator, "is_authentic")
def test_prefix_match_still_authenticates_non_exempt_paths(self, is_authentic_mock):
"""Test that non-exempt paths still require authentication"""
is_authentic_mock.return_value = (True, 200, "")

response = self.client.get("/")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"msg": "authenticated"})
76 changes: 76 additions & 0 deletions tests/middlewares/wsgi_test.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -192,3 +192,79 @@ def post_test():

self.assertEqual(response.status_code, 200)
self.assertEqual(response.json, body)


class TestMAuthWSGIMiddlewareWithPrefixMatch(unittest.TestCase):
def setUp(self):
self.app_uuid = str(uuid4())
Config.APP_UUID = self.app_uuid
Config.MAUTH_URL = "https://mauth.com"
Config.MAUTH_API_VERSION = "v1"
Config.PRIVATE_KEY = "key"

self.app = Flask("Test App")
self.app.wsgi_app = MAuthWSGIMiddleware(
self.app.wsgi_app,
exempt={"/health", "/metrics"},
exempt_prefix_match=True
)

@self.app.get("/")
def root():
return "authenticated!"

@self.app.get("/health")
def health_exact():
return "exact health"

@self.app.get("/health/live")
def health_live():
return "health live"

@self.app.get("/health/ready")
def health_ready():
return "health ready"

@self.app.get("/metrics/prometheus")
def metrics():
return "metrics"

@self.app.get("/api/health")
def api_health():
return "api health"

self.client = self.app.test_client()

def test_prefix_match_allows_nested_paths(self):
"""Test that nested paths under exempt prefix are allowed"""
response = self.client.get("/health/live")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_data(as_text=True), "health live")

response = self.client.get("/health/ready")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_data(as_text=True), "health ready")

response = self.client.get("/metrics/prometheus")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_data(as_text=True), "metrics")

def test_prefix_match_blocks_similar_paths(self):
"""Test that similar but non-matching paths are still blocked"""
response = self.client.get("/api/health")
self.assertEqual(response.status_code, 401)

def test_prefix_match_allows_exact_match_in_exempt_set(self):
"""Test that exact match in exempt set is allowed (from exact match check)"""
response = self.client.get("/health")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_data(as_text=True), "exact health")

@patch.object(LocalAuthenticator, "is_authentic")
def test_prefix_match_still_authenticates_non_exempt_paths(self, is_authentic_mock):
"""Test that non-exempt paths still require authentication"""
is_authentic_mock.return_value = (True, 200, "")

response = self.client.get("/")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_data(as_text=True), "authenticated!")
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
# 1.6.7
- Added optional substring exempt path matching when `exempt_prefix_match` is `True`

# 1.6.6
- Support long-lived connections in ASGI middleware

Expand Down
8 changes: 6 additions & 2 deletions mauth_client/middlewares/asgi.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,16 +19,17 @@
)
from mauth_client.signable import RequestSignable
from mauth_client.signed import Signed
from mauth_client.utils import decode
from mauth_client.utils import decode, is_exempt_request_path

logger = logging.getLogger("mauth_asgi")


class MAuthASGIMiddleware:
def __init__(self, app: ASGI3Application, exempt: Optional[set] = None) -> None:
def __init__(self, app: ASGI3Application, exempt: Optional[set] = None, exempt_prefix_match: bool = False) -> None:
self._validate_configs()
self.app = app
self.exempt = exempt.copy() if exempt else set()
self.exempt_prefix_match = exempt_prefix_match

async def __call__(
self, scope: Scope, receive: ASGIReceiveCallable, send: ASGISendCallable
Expand All@@ -40,6 +41,9 @@ async def __call__(
if path in self.exempt:
return await self.app(scope, receive, send)

if self.exempt_prefix_match and is_exempt_request_path(path, self.exempt):
return await self.app(scope, receive, send)

query_string = scope["query_string"]
url = f"{path}?{decode(query_string)}" if query_string else path
headers = {decode(k): decode(v) for k, v in scope["headers"]}
Expand Down
7 changes: 6 additions & 1 deletion mauth_client/middlewares/wsgi.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,22 +14,27 @@

from mauth_client.signable import RequestSignable
from mauth_client.signed import Signed
from mauth_client.utils import is_exempt_request_path

logger = logging.getLogger("mauth_wsgi")


class MAuthWSGIMiddleware:
def __init__(self, app, exempt=None):
def __init__(self, app, exempt=None, exempt_prefix_match=False):
self._validate_configs()
self.app = app
self.exempt = exempt.copy() if exempt else set()
self.exempt_prefix_match = exempt_prefix_match

def __call__(self, environ, start_response):
path = environ.get("PATH_INFO", "")

if path in self.exempt:
return self.app(environ, start_response)

if self.exempt_prefix_match and is_exempt_request_path(path, self.exempt):
return self.app(environ, start_response)

signable = RequestSignable(
method=environ["REQUEST_METHOD"],
url=self._extract_url(environ),
Expand Down
33 changes: 33 additions & 0 deletions mauth_client/utils.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -32,3 +32,36 @@ def decode(byte_string: bytes) -> str:
except UnicodeDecodeError:
encoding = charset_normalizer.detect(byte_string)["encoding"]
return byte_string.decode(encoding)


def is_exempt_request_path(path: str, exempt: set) -> bool:
"""
Check if a request path should be exempt from authentication based on prefix matching.

This function performs prefix matching with path separator boundary checking to prevent
false positives. A path matches an exempt prefix only if it starts with the exempt path
followed by a path separator ('/').

:param str path: The request path to check (e.g., '/health/live', '/api/users')
:param set exempt: Set of exempt path prefixes (e.g., {'/health', '/metrics'})
:return: True if the path matches any exempt prefix, False otherwise
:rtype: bool

Examples:
Matching cases (returns True):
- path='/health/live', exempt={'/health'} -> True
- path='/health/ready', exempt={'/health'} -> True
- path='/metrics/prometheus', exempt={'/metrics'} -> True

Non-matching cases (returns False):
- path='/health', exempt={'/health'} -> False (exact match without trailing slash)
- path='/api-admin', exempt={'/api'} -> False (not a path separator boundary)
- path='/app_status_admin', exempt={'/app_status'} -> False (underscore, not separator)
- path='/healthcare', exempt={'/health'} -> False (different path)
"""
for exempt_path in exempt:
# Exact match or prefix match with path separator
# For instance this prevents /api matching /api-admin or /app_status matching /app_status_admin
if path.startswith(exempt_path.rstrip('/') + '/'):
return True
return False
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "mauth-client"
version = "1.6.6"
version = "1.6.7"
description = "MAuth Client for Python"
repository = "https://github.com/mdsol/mauth-client-python"
authors = ["Medidata Solutions <support@mdsol.com>"]
Expand Down
76 changes: 76 additions & 0 deletions tests/middlewares/asgi_test.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -278,3 +278,79 @@ async def mock_receive():
self.assertEqual(call_order[0], ("body", "http.request"))
self.assertEqual(call_order[1], ("disconnect", "http.disconnect"))
self.assertEqual(receive_calls, 2) # Called once for auth, once from app


class TestMAuthASGIMiddlewareWithPrefixMatch(unittest.TestCase):
def setUp(self):
self.app_uuid = str(uuid4())
Config.APP_UUID = self.app_uuid
Config.MAUTH_URL = "https://mauth.com"
Config.MAUTH_API_VERSION = "v1"
Config.PRIVATE_KEY = "key"

self.app = FastAPI()
self.app.add_middleware(
MAuthASGIMiddleware,
exempt={"/health", "/metrics"},
exempt_prefix_match=True
)

@self.app.get("/")
async def root():
return {"msg": "authenticated"}

@self.app.get("/health")
async def health_exact():
return {"msg": "exact health"}

@self.app.get("/health/live")
async def health_live():
return {"msg": "health live"}

@self.app.get("/health/ready")
async def health_ready():
return {"msg": "health ready"}

@self.app.get("/metrics/prometheus")
async def metrics():
return {"msg": "metrics"}

@self.app.get("/api/health")
async def api_health():
return {"msg": "api health"}

self.client = TestClient(self.app)

def test_prefix_match_allows_nested_paths(self):
"""Test that nested paths under exempt prefix are allowed"""
response = self.client.get("/health/live")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"msg": "health live"})

response = self.client.get("/health/ready")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"msg": "health ready"})

response = self.client.get("/metrics/prometheus")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"msg": "metrics"})

def test_prefix_match_blocks_similar_paths(self):
"""Test that similar but non-matching paths are still blocked"""
response = self.client.get("/api/health")
self.assertEqual(response.status_code, 401)

def test_prefix_match_allows_exact_match_in_exempt_set(self):
"""Test that exact match in exempt set is allowed (from exact match check)"""
response = self.client.get("/health")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"msg": "exact health"})

@patch.object(LocalAuthenticator, "is_authentic")
def test_prefix_match_still_authenticates_non_exempt_paths(self, is_authentic_mock):
"""Test that non-exempt paths still require authentication"""
is_authentic_mock.return_value = (True, 200, "")

response = self.client.get("/")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"msg": "authenticated"})
76 changes: 76 additions & 0 deletions tests/middlewares/wsgi_test.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -192,3 +192,79 @@ def post_test():

self.assertEqual(response.status_code, 200)
self.assertEqual(response.json, body)


class TestMAuthWSGIMiddlewareWithPrefixMatch(unittest.TestCase):
def setUp(self):
self.app_uuid = str(uuid4())
Config.APP_UUID = self.app_uuid
Config.MAUTH_URL = "https://mauth.com"
Config.MAUTH_API_VERSION = "v1"
Config.PRIVATE_KEY = "key"

self.app = Flask("Test App")
self.app.wsgi_app = MAuthWSGIMiddleware(
self.app.wsgi_app,
exempt={"/health", "/metrics"},
exempt_prefix_match=True
)

@self.app.get("/")
def root():
return "authenticated!"

@self.app.get("/health")
def health_exact():
return "exact health"

@self.app.get("/health/live")
def health_live():
return "health live"

@self.app.get("/health/ready")
def health_ready():
return "health ready"

@self.app.get("/metrics/prometheus")
def metrics():
return "metrics"

@self.app.get("/api/health")
def api_health():
return "api health"

self.client = self.app.test_client()

def test_prefix_match_allows_nested_paths(self):
"""Test that nested paths under exempt prefix are allowed"""
response = self.client.get("/health/live")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_data(as_text=True), "health live")

response = self.client.get("/health/ready")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_data(as_text=True), "health ready")

response = self.client.get("/metrics/prometheus")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_data(as_text=True), "metrics")

def test_prefix_match_blocks_similar_paths(self):
"""Test that similar but non-matching paths are still blocked"""
response = self.client.get("/api/health")
self.assertEqual(response.status_code, 401)

def test_prefix_match_allows_exact_match_in_exempt_set(self):
"""Test that exact match in exempt set is allowed (from exact match check)"""
response = self.client.get("/health")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_data(as_text=True), "exact health")

@patch.object(LocalAuthenticator, "is_authentic")
def test_prefix_match_still_authenticates_non_exempt_paths(self, is_authentic_mock):
"""Test that non-exempt paths still require authentication"""
is_authentic_mock.return_value = (True, 200, "")

response = self.client.get("/")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_data(as_text=True), "authenticated!")
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
# 1.6.7
- Added optional substring exempt path matching when `exempt_prefix_match` is `True`

# 1.6.6
- Support long-lived connections in ASGI middleware

Expand Down
8 changes: 6 additions & 2 deletions mauth_client/middlewares/asgi.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,16 +19,17 @@
)
from mauth_client.signable import RequestSignable
from mauth_client.signed import Signed
from mauth_client.utils import decode
from mauth_client.utils import decode, is_exempt_request_path

logger = logging.getLogger("mauth_asgi")


class MAuthASGIMiddleware:
def __init__(self, app: ASGI3Application, exempt: Optional[set] = None) -> None:
def __init__(self, app: ASGI3Application, exempt: Optional[set] = None, exempt_prefix_match: bool = False) -> None:
self._validate_configs()
self.app = app
self.exempt = exempt.copy() if exempt else set()
self.exempt_prefix_match = exempt_prefix_match

async def __call__(
self, scope: Scope, receive: ASGIReceiveCallable, send: ASGISendCallable
Expand All@@ -40,6 +41,9 @@ async def __call__(
if path in self.exempt:
return await self.app(scope, receive, send)

if self.exempt_prefix_match and is_exempt_request_path(path, self.exempt):
return await self.app(scope, receive, send)

query_string = scope["query_string"]
url = f"{path}?{decode(query_string)}" if query_string else path
headers = {decode(k): decode(v) for k, v in scope["headers"]}
Expand Down
7 changes: 6 additions & 1 deletion mauth_client/middlewares/wsgi.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,22 +14,27 @@

from mauth_client.signable import RequestSignable
from mauth_client.signed import Signed
from mauth_client.utils import is_exempt_request_path

logger = logging.getLogger("mauth_wsgi")


class MAuthWSGIMiddleware:
def __init__(self, app, exempt=None):
def __init__(self, app, exempt=None, exempt_prefix_match=False):
self._validate_configs()
self.app = app
self.exempt = exempt.copy() if exempt else set()
self.exempt_prefix_match = exempt_prefix_match

def __call__(self, environ, start_response):
path = environ.get("PATH_INFO", "")

if path in self.exempt:
return self.app(environ, start_response)

if self.exempt_prefix_match and is_exempt_request_path(path, self.exempt):
return self.app(environ, start_response)

signable = RequestSignable(
method=environ["REQUEST_METHOD"],
url=self._extract_url(environ),
Expand Down
33 changes: 33 additions & 0 deletions mauth_client/utils.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -32,3 +32,36 @@ def decode(byte_string: bytes) -> str:
except UnicodeDecodeError:
encoding = charset_normalizer.detect(byte_string)["encoding"]
return byte_string.decode(encoding)


def is_exempt_request_path(path: str, exempt: set) -> bool:
"""
Check if a request path should be exempt from authentication based on prefix matching.

This function performs prefix matching with path separator boundary checking to prevent
false positives. A path matches an exempt prefix only if it starts with the exempt path
followed by a path separator ('/').

:param str path: The request path to check (e.g., '/health/live', '/api/users')
:param set exempt: Set of exempt path prefixes (e.g., {'/health', '/metrics'})
:return: True if the path matches any exempt prefix, False otherwise
:rtype: bool

Examples:
Matching cases (returns True):
- path='/health/live', exempt={'/health'} -> True
- path='/health/ready', exempt={'/health'} -> True
- path='/metrics/prometheus', exempt={'/metrics'} -> True

Non-matching cases (returns False):
- path='/health', exempt={'/health'} -> False (exact match without trailing slash)
- path='/api-admin', exempt={'/api'} -> False (not a path separator boundary)
- path='/app_status_admin', exempt={'/app_status'} -> False (underscore, not separator)
- path='/healthcare', exempt={'/health'} -> False (different path)
"""
for exempt_path in exempt:
# Exact match or prefix match with path separator
# For instance this prevents /api matching /api-admin or /app_status matching /app_status_admin
if path.startswith(exempt_path.rstrip('/') + '/'):
return True
return False
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "mauth-client"
version = "1.6.6"
version = "1.6.7"
description = "MAuth Client for Python"
repository = "https://github.com/mdsol/mauth-client-python"
authors = ["Medidata Solutions <support@mdsol.com>"]
Expand Down
76 changes: 76 additions & 0 deletions tests/middlewares/asgi_test.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -278,3 +278,79 @@ async def mock_receive():
self.assertEqual(call_order[0], ("body", "http.request"))
self.assertEqual(call_order[1], ("disconnect", "http.disconnect"))
self.assertEqual(receive_calls, 2) # Called once for auth, once from app


class TestMAuthASGIMiddlewareWithPrefixMatch(unittest.TestCase):
def setUp(self):
self.app_uuid = str(uuid4())
Config.APP_UUID = self.app_uuid
Config.MAUTH_URL = "https://mauth.com"
Config.MAUTH_API_VERSION = "v1"
Config.PRIVATE_KEY = "key"

self.app = FastAPI()
self.app.add_middleware(
MAuthASGIMiddleware,
exempt={"/health", "/metrics"},
exempt_prefix_match=True
)

@self.app.get("/")
async def root():
return {"msg": "authenticated"}

@self.app.get("/health")
async def health_exact():
return {"msg": "exact health"}

@self.app.get("/health/live")
async def health_live():
return {"msg": "health live"}

@self.app.get("/health/ready")
async def health_ready():
return {"msg": "health ready"}

@self.app.get("/metrics/prometheus")
async def metrics():
return {"msg": "metrics"}

@self.app.get("/api/health")
async def api_health():
return {"msg": "api health"}

self.client = TestClient(self.app)

def test_prefix_match_allows_nested_paths(self):
"""Test that nested paths under exempt prefix are allowed"""
response = self.client.get("/health/live")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"msg": "health live"})

response = self.client.get("/health/ready")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"msg": "health ready"})

response = self.client.get("/metrics/prometheus")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"msg": "metrics"})

def test_prefix_match_blocks_similar_paths(self):
"""Test that similar but non-matching paths are still blocked"""
response = self.client.get("/api/health")
self.assertEqual(response.status_code, 401)

def test_prefix_match_allows_exact_match_in_exempt_set(self):
"""Test that exact match in exempt set is allowed (from exact match check)"""
response = self.client.get("/health")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"msg": "exact health"})

@patch.object(LocalAuthenticator, "is_authentic")
def test_prefix_match_still_authenticates_non_exempt_paths(self, is_authentic_mock):
"""Test that non-exempt paths still require authentication"""
is_authentic_mock.return_value = (True, 200, "")

response = self.client.get("/")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"msg": "authenticated"})
76 changes: 76 additions & 0 deletions tests/middlewares/wsgi_test.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -192,3 +192,79 @@ def post_test():

self.assertEqual(response.status_code, 200)
self.assertEqual(response.json, body)


class TestMAuthWSGIMiddlewareWithPrefixMatch(unittest.TestCase):
def setUp(self):
self.app_uuid = str(uuid4())
Config.APP_UUID = self.app_uuid
Config.MAUTH_URL = "https://mauth.com"
Config.MAUTH_API_VERSION = "v1"
Config.PRIVATE_KEY = "key"

self.app = Flask("Test App")
self.app.wsgi_app = MAuthWSGIMiddleware(
self.app.wsgi_app,
exempt={"/health", "/metrics"},
exempt_prefix_match=True
)

@self.app.get("/")
def root():
return "authenticated!"

@self.app.get("/health")
def health_exact():
return "exact health"

@self.app.get("/health/live")
def health_live():
return "health live"

@self.app.get("/health/ready")
def health_ready():
return "health ready"

@self.app.get("/metrics/prometheus")
def metrics():
return "metrics"

@self.app.get("/api/health")
def api_health():
return "api health"

self.client = self.app.test_client()

def test_prefix_match_allows_nested_paths(self):
"""Test that nested paths under exempt prefix are allowed"""
response = self.client.get("/health/live")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_data(as_text=True), "health live")

response = self.client.get("/health/ready")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_data(as_text=True), "health ready")

response = self.client.get("/metrics/prometheus")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_data(as_text=True), "metrics")

def test_prefix_match_blocks_similar_paths(self):
"""Test that similar but non-matching paths are still blocked"""
response = self.client.get("/api/health")
self.assertEqual(response.status_code, 401)

def test_prefix_match_allows_exact_match_in_exempt_set(self):
"""Test that exact match in exempt set is allowed (from exact match check)"""
response = self.client.get("/health")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_data(as_text=True), "exact health")

@patch.object(LocalAuthenticator, "is_authentic")
def test_prefix_match_still_authenticates_non_exempt_paths(self, is_authentic_mock):
"""Test that non-exempt paths still require authentication"""
is_authentic_mock.return_value = (True, 200, "")

response = self.client.get("/")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_data(as_text=True), "authenticated!")
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
# 1.6.7
- Added optional substring exempt path matching when `exempt_prefix_match` is `True`

# 1.6.6
- Support long-lived connections in ASGI middleware

Expand Down
8 changes: 6 additions & 2 deletions mauth_client/middlewares/asgi.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,16 +19,17 @@
)
from mauth_client.signable import RequestSignable
from mauth_client.signed import Signed
from mauth_client.utils import decode
from mauth_client.utils import decode, is_exempt_request_path

logger = logging.getLogger("mauth_asgi")


class MAuthASGIMiddleware:
def __init__(self, app: ASGI3Application, exempt: Optional[set] = None) -> None:
def __init__(self, app: ASGI3Application, exempt: Optional[set] = None, exempt_prefix_match: bool = False) -> None:
self._validate_configs()
self.app = app
self.exempt = exempt.copy() if exempt else set()
self.exempt_prefix_match = exempt_prefix_match

async def __call__(
self, scope: Scope, receive: ASGIReceiveCallable, send: ASGISendCallable
Expand All@@ -40,6 +41,9 @@ async def __call__(
if path in self.exempt:
return await self.app(scope, receive, send)

if self.exempt_prefix_match and is_exempt_request_path(path, self.exempt):
return await self.app(scope, receive, send)

query_string = scope["query_string"]
url = f"{path}?{decode(query_string)}" if query_string else path
headers = {decode(k): decode(v) for k, v in scope["headers"]}
Expand Down
7 changes: 6 additions & 1 deletion mauth_client/middlewares/wsgi.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,22 +14,27 @@

from mauth_client.signable import RequestSignable
from mauth_client.signed import Signed
from mauth_client.utils import is_exempt_request_path

logger = logging.getLogger("mauth_wsgi")


class MAuthWSGIMiddleware:
def __init__(self, app, exempt=None):
def __init__(self, app, exempt=None, exempt_prefix_match=False):
self._validate_configs()
self.app = app
self.exempt = exempt.copy() if exempt else set()
self.exempt_prefix_match = exempt_prefix_match

def __call__(self, environ, start_response):
path = environ.get("PATH_INFO", "")

if path in self.exempt:
return self.app(environ, start_response)

if self.exempt_prefix_match and is_exempt_request_path(path, self.exempt):
return self.app(environ, start_response)

signable = RequestSignable(
method=environ["REQUEST_METHOD"],
url=self._extract_url(environ),
Expand Down
33 changes: 33 additions & 0 deletions mauth_client/utils.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -32,3 +32,36 @@ def decode(byte_string: bytes) -> str:
except UnicodeDecodeError:
encoding = charset_normalizer.detect(byte_string)["encoding"]
return byte_string.decode(encoding)


def is_exempt_request_path(path: str, exempt: set) -> bool:
"""
Check if a request path should be exempt from authentication based on prefix matching.

This function performs prefix matching with path separator boundary checking to prevent
false positives. A path matches an exempt prefix only if it starts with the exempt path
followed by a path separator ('/').

:param str path: The request path to check (e.g., '/health/live', '/api/users')
:param set exempt: Set of exempt path prefixes (e.g., {'/health', '/metrics'})
:return: True if the path matches any exempt prefix, False otherwise
:rtype: bool

Examples:
Matching cases (returns True):
- path='/health/live', exempt={'/health'} -> True
- path='/health/ready', exempt={'/health'} -> True
- path='/metrics/prometheus', exempt={'/metrics'} -> True

Non-matching cases (returns False):
- path='/health', exempt={'/health'} -> False (exact match without trailing slash)
- path='/api-admin', exempt={'/api'} -> False (not a path separator boundary)
- path='/app_status_admin', exempt={'/app_status'} -> False (underscore, not separator)
- path='/healthcare', exempt={'/health'} -> False (different path)
"""
for exempt_path in exempt:
# Exact match or prefix match with path separator
# For instance this prevents /api matching /api-admin or /app_status matching /app_status_admin
if path.startswith(exempt_path.rstrip('/') + '/'):
return True
return False
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "mauth-client"
version = "1.6.6"
version = "1.6.7"
description = "MAuth Client for Python"
repository = "https://github.com/mdsol/mauth-client-python"
authors = ["Medidata Solutions <support@mdsol.com>"]
Expand Down
76 changes: 76 additions & 0 deletions tests/middlewares/asgi_test.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -278,3 +278,79 @@ async def mock_receive():
self.assertEqual(call_order[0], ("body", "http.request"))
self.assertEqual(call_order[1], ("disconnect", "http.disconnect"))
self.assertEqual(receive_calls, 2) # Called once for auth, once from app


class TestMAuthASGIMiddlewareWithPrefixMatch(unittest.TestCase):
def setUp(self):
self.app_uuid = str(uuid4())
Config.APP_UUID = self.app_uuid
Config.MAUTH_URL = "https://mauth.com"
Config.MAUTH_API_VERSION = "v1"
Config.PRIVATE_KEY = "key"

self.app = FastAPI()
self.app.add_middleware(
MAuthASGIMiddleware,
exempt={"/health", "/metrics"},
exempt_prefix_match=True
)

@self.app.get("/")
async def root():
return {"msg": "authenticated"}

@self.app.get("/health")
async def health_exact():
return {"msg": "exact health"}

@self.app.get("/health/live")
async def health_live():
return {"msg": "health live"}

@self.app.get("/health/ready")
async def health_ready():
return {"msg": "health ready"}

@self.app.get("/metrics/prometheus")
async def metrics():
return {"msg": "metrics"}

@self.app.get("/api/health")
async def api_health():
return {"msg": "api health"}

self.client = TestClient(self.app)

def test_prefix_match_allows_nested_paths(self):
"""Test that nested paths under exempt prefix are allowed"""
response = self.client.get("/health/live")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"msg": "health live"})

response = self.client.get("/health/ready")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"msg": "health ready"})

response = self.client.get("/metrics/prometheus")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"msg": "metrics"})

def test_prefix_match_blocks_similar_paths(self):
"""Test that similar but non-matching paths are still blocked"""
response = self.client.get("/api/health")
self.assertEqual(response.status_code, 401)

def test_prefix_match_allows_exact_match_in_exempt_set(self):
"""Test that exact match in exempt set is allowed (from exact match check)"""
response = self.client.get("/health")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"msg": "exact health"})

@patch.object(LocalAuthenticator, "is_authentic")
def test_prefix_match_still_authenticates_non_exempt_paths(self, is_authentic_mock):
"""Test that non-exempt paths still require authentication"""
is_authentic_mock.return_value = (True, 200, "")

response = self.client.get("/")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"msg": "authenticated"})
76 changes: 76 additions & 0 deletions tests/middlewares/wsgi_test.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -192,3 +192,79 @@ def post_test():

self.assertEqual(response.status_code, 200)
self.assertEqual(response.json, body)


class TestMAuthWSGIMiddlewareWithPrefixMatch(unittest.TestCase):
def setUp(self):
self.app_uuid = str(uuid4())
Config.APP_UUID = self.app_uuid
Config.MAUTH_URL = "https://mauth.com"
Config.MAUTH_API_VERSION = "v1"
Config.PRIVATE_KEY = "key"

self.app = Flask("Test App")
self.app.wsgi_app = MAuthWSGIMiddleware(
self.app.wsgi_app,
exempt={"/health", "/metrics"},
exempt_prefix_match=True
)

@self.app.get("/")
def root():
return "authenticated!"

@self.app.get("/health")
def health_exact():
return "exact health"

@self.app.get("/health/live")
def health_live():
return "health live"

@self.app.get("/health/ready")
def health_ready():
return "health ready"

@self.app.get("/metrics/prometheus")
def metrics():
return "metrics"

@self.app.get("/api/health")
def api_health():
return "api health"

self.client = self.app.test_client()

def test_prefix_match_allows_nested_paths(self):
"""Test that nested paths under exempt prefix are allowed"""
response = self.client.get("/health/live")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_data(as_text=True), "health live")

response = self.client.get("/health/ready")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_data(as_text=True), "health ready")

response = self.client.get("/metrics/prometheus")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_data(as_text=True), "metrics")

def test_prefix_match_blocks_similar_paths(self):
"""Test that similar but non-matching paths are still blocked"""
response = self.client.get("/api/health")
self.assertEqual(response.status_code, 401)

def test_prefix_match_allows_exact_match_in_exempt_set(self):
"""Test that exact match in exempt set is allowed (from exact match check)"""
response = self.client.get("/health")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_data(as_text=True), "exact health")

@patch.object(LocalAuthenticator, "is_authentic")
def test_prefix_match_still_authenticates_non_exempt_paths(self, is_authentic_mock):
"""Test that non-exempt paths still require authentication"""
is_authentic_mock.return_value = (True, 200, "")

response = self.client.get("/")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_data(as_text=True), "authenticated!")
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
# 1.6.7
- Added optional substring exempt path matching when `exempt_prefix_match` is `True`

# 1.6.6
- Support long-lived connections in ASGI middleware

Expand Down
8 changes: 6 additions & 2 deletions mauth_client/middlewares/asgi.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,16 +19,17 @@
)
from mauth_client.signable import RequestSignable
from mauth_client.signed import Signed
from mauth_client.utils import decode
from mauth_client.utils import decode, is_exempt_request_path

logger = logging.getLogger("mauth_asgi")


class MAuthASGIMiddleware:
def __init__(self, app: ASGI3Application, exempt: Optional[set] = None) -> None:
def __init__(self, app: ASGI3Application, exempt: Optional[set] = None, exempt_prefix_match: bool = False) -> None:
self._validate_configs()
self.app = app
self.exempt = exempt.copy() if exempt else set()
self.exempt_prefix_match = exempt_prefix_match

async def __call__(
self, scope: Scope, receive: ASGIReceiveCallable, send: ASGISendCallable
Expand All@@ -40,6 +41,9 @@ async def __call__(
if path in self.exempt:
return await self.app(scope, receive, send)

if self.exempt_prefix_match and is_exempt_request_path(path, self.exempt):
return await self.app(scope, receive, send)

query_string = scope["query_string"]
url = f"{path}?{decode(query_string)}" if query_string else path
headers = {decode(k): decode(v) for k, v in scope["headers"]}
Expand Down
7 changes: 6 additions & 1 deletion mauth_client/middlewares/wsgi.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,22 +14,27 @@

from mauth_client.signable import RequestSignable
from mauth_client.signed import Signed
from mauth_client.utils import is_exempt_request_path

logger = logging.getLogger("mauth_wsgi")


class MAuthWSGIMiddleware:
def __init__(self, app, exempt=None):
def __init__(self, app, exempt=None, exempt_prefix_match=False):
self._validate_configs()
self.app = app
self.exempt = exempt.copy() if exempt else set()
self.exempt_prefix_match = exempt_prefix_match

def __call__(self, environ, start_response):
path = environ.get("PATH_INFO", "")

if path in self.exempt:
return self.app(environ, start_response)

if self.exempt_prefix_match and is_exempt_request_path(path, self.exempt):
return self.app(environ, start_response)

signable = RequestSignable(
method=environ["REQUEST_METHOD"],
url=self._extract_url(environ),
Expand Down
33 changes: 33 additions & 0 deletions mauth_client/utils.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -32,3 +32,36 @@ def decode(byte_string: bytes) -> str:
except UnicodeDecodeError:
encoding = charset_normalizer.detect(byte_string)["encoding"]
return byte_string.decode(encoding)


def is_exempt_request_path(path: str, exempt: set) -> bool:
"""
Check if a request path should be exempt from authentication based on prefix matching.

This function performs prefix matching with path separator boundary checking to prevent
false positives. A path matches an exempt prefix only if it starts with the exempt path
followed by a path separator ('/').

:param str path: The request path to check (e.g., '/health/live', '/api/users')
:param set exempt: Set of exempt path prefixes (e.g., {'/health', '/metrics'})
:return: True if the path matches any exempt prefix, False otherwise
:rtype: bool

Examples:
Matching cases (returns True):
- path='/health/live', exempt={'/health'} -> True
- path='/health/ready', exempt={'/health'} -> True
- path='/metrics/prometheus', exempt={'/metrics'} -> True

Non-matching cases (returns False):
- path='/health', exempt={'/health'} -> False (exact match without trailing slash)
- path='/api-admin', exempt={'/api'} -> False (not a path separator boundary)
- path='/app_status_admin', exempt={'/app_status'} -> False (underscore, not separator)
- path='/healthcare', exempt={'/health'} -> False (different path)
"""
for exempt_path in exempt:
# Exact match or prefix match with path separator
# For instance this prevents /api matching /api-admin or /app_status matching /app_status_admin
if path.startswith(exempt_path.rstrip('/') + '/'):
return True
return False
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "mauth-client"
version = "1.6.6"
version = "1.6.7"
description = "MAuth Client for Python"
repository = "https://github.com/mdsol/mauth-client-python"
authors = ["Medidata Solutions <support@mdsol.com>"]
Expand Down
76 changes: 76 additions & 0 deletions tests/middlewares/asgi_test.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -278,3 +278,79 @@ async def mock_receive():
self.assertEqual(call_order[0], ("body", "http.request"))
self.assertEqual(call_order[1], ("disconnect", "http.disconnect"))
self.assertEqual(receive_calls, 2) # Called once for auth, once from app


class TestMAuthASGIMiddlewareWithPrefixMatch(unittest.TestCase):
def setUp(self):
self.app_uuid = str(uuid4())
Config.APP_UUID = self.app_uuid
Config.MAUTH_URL = "https://mauth.com"
Config.MAUTH_API_VERSION = "v1"
Config.PRIVATE_KEY = "key"

self.app = FastAPI()
self.app.add_middleware(
MAuthASGIMiddleware,
exempt={"/health", "/metrics"},
exempt_prefix_match=True
)

@self.app.get("/")
async def root():
return {"msg": "authenticated"}

@self.app.get("/health")
async def health_exact():
return {"msg": "exact health"}

@self.app.get("/health/live")
async def health_live():
return {"msg": "health live"}

@self.app.get("/health/ready")
async def health_ready():
return {"msg": "health ready"}

@self.app.get("/metrics/prometheus")
async def metrics():
return {"msg": "metrics"}

@self.app.get("/api/health")
async def api_health():
return {"msg": "api health"}

self.client = TestClient(self.app)

def test_prefix_match_allows_nested_paths(self):
"""Test that nested paths under exempt prefix are allowed"""
response = self.client.get("/health/live")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"msg": "health live"})

response = self.client.get("/health/ready")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"msg": "health ready"})

response = self.client.get("/metrics/prometheus")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"msg": "metrics"})

def test_prefix_match_blocks_similar_paths(self):
"""Test that similar but non-matching paths are still blocked"""
response = self.client.get("/api/health")
self.assertEqual(response.status_code, 401)

def test_prefix_match_allows_exact_match_in_exempt_set(self):
"""Test that exact match in exempt set is allowed (from exact match check)"""
response = self.client.get("/health")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"msg": "exact health"})

@patch.object(LocalAuthenticator, "is_authentic")
def test_prefix_match_still_authenticates_non_exempt_paths(self, is_authentic_mock):
"""Test that non-exempt paths still require authentication"""
is_authentic_mock.return_value = (True, 200, "")

response = self.client.get("/")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"msg": "authenticated"})
76 changes: 76 additions & 0 deletions tests/middlewares/wsgi_test.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -192,3 +192,79 @@ def post_test():

self.assertEqual(response.status_code, 200)
self.assertEqual(response.json, body)


class TestMAuthWSGIMiddlewareWithPrefixMatch(unittest.TestCase):
def setUp(self):
self.app_uuid = str(uuid4())
Config.APP_UUID = self.app_uuid
Config.MAUTH_URL = "https://mauth.com"
Config.MAUTH_API_VERSION = "v1"
Config.PRIVATE_KEY = "key"

self.app = Flask("Test App")
self.app.wsgi_app = MAuthWSGIMiddleware(
self.app.wsgi_app,
exempt={"/health", "/metrics"},
exempt_prefix_match=True
)

@self.app.get("/")
def root():
return "authenticated!"

@self.app.get("/health")
def health_exact():
return "exact health"

@self.app.get("/health/live")
def health_live():
return "health live"

@self.app.get("/health/ready")
def health_ready():
return "health ready"

@self.app.get("/metrics/prometheus")
def metrics():
return "metrics"

@self.app.get("/api/health")
def api_health():
return "api health"

self.client = self.app.test_client()

def test_prefix_match_allows_nested_paths(self):
"""Test that nested paths under exempt prefix are allowed"""
response = self.client.get("/health/live")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_data(as_text=True), "health live")

response = self.client.get("/health/ready")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_data(as_text=True), "health ready")

response = self.client.get("/metrics/prometheus")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_data(as_text=True), "metrics")

def test_prefix_match_blocks_similar_paths(self):
"""Test that similar but non-matching paths are still blocked"""
response = self.client.get("/api/health")
self.assertEqual(response.status_code, 401)

def test_prefix_match_allows_exact_match_in_exempt_set(self):
"""Test that exact match in exempt set is allowed (from exact match check)"""
response = self.client.get("/health")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_data(as_text=True), "exact health")

@patch.object(LocalAuthenticator, "is_authentic")
def test_prefix_match_still_authenticates_non_exempt_paths(self, is_authentic_mock):
"""Test that non-exempt paths still require authentication"""
is_authentic_mock.return_value = (True, 200, "")

response = self.client.get("/")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_data(as_text=True), "authenticated!")
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
# 1.6.7
- Added optional substring exempt path matching when `exempt_prefix_match` is `True`

# 1.6.6
- Support long-lived connections in ASGI middleware

Expand Down
8 changes: 6 additions & 2 deletions mauth_client/middlewares/asgi.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,16 +19,17 @@
)
from mauth_client.signable import RequestSignable
from mauth_client.signed import Signed
from mauth_client.utils import decode
from mauth_client.utils import decode, is_exempt_request_path

logger = logging.getLogger("mauth_asgi")


class MAuthASGIMiddleware:
def __init__(self, app: ASGI3Application, exempt: Optional[set] = None) -> None:
def __init__(self, app: ASGI3Application, exempt: Optional[set] = None, exempt_prefix_match: bool = False) -> None:
self._validate_configs()
self.app = app
self.exempt = exempt.copy() if exempt else set()
self.exempt_prefix_match = exempt_prefix_match

async def __call__(
self, scope: Scope, receive: ASGIReceiveCallable, send: ASGISendCallable
Expand All@@ -40,6 +41,9 @@ async def __call__(
if path in self.exempt:
return await self.app(scope, receive, send)

if self.exempt_prefix_match and is_exempt_request_path(path, self.exempt):
return await self.app(scope, receive, send)

query_string = scope["query_string"]
url = f"{path}?{decode(query_string)}" if query_string else path
headers = {decode(k): decode(v) for k, v in scope["headers"]}
Expand Down
7 changes: 6 additions & 1 deletion mauth_client/middlewares/wsgi.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,22 +14,27 @@

from mauth_client.signable import RequestSignable
from mauth_client.signed import Signed
from mauth_client.utils import is_exempt_request_path

logger = logging.getLogger("mauth_wsgi")


class MAuthWSGIMiddleware:
def __init__(self, app, exempt=None):
def __init__(self, app, exempt=None, exempt_prefix_match=False):
self._validate_configs()
self.app = app
self.exempt = exempt.copy() if exempt else set()
self.exempt_prefix_match = exempt_prefix_match

def __call__(self, environ, start_response):
path = environ.get("PATH_INFO", "")

if path in self.exempt:
return self.app(environ, start_response)

if self.exempt_prefix_match and is_exempt_request_path(path, self.exempt):
return self.app(environ, start_response)

signable = RequestSignable(
method=environ["REQUEST_METHOD"],
url=self._extract_url(environ),
Expand Down
33 changes: 33 additions & 0 deletions mauth_client/utils.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -32,3 +32,36 @@ def decode(byte_string: bytes) -> str:
except UnicodeDecodeError:
encoding = charset_normalizer.detect(byte_string)["encoding"]
return byte_string.decode(encoding)


def is_exempt_request_path(path: str, exempt: set) -> bool:
"""
Check if a request path should be exempt from authentication based on prefix matching.

This function performs prefix matching with path separator boundary checking to prevent
false positives. A path matches an exempt prefix only if it starts with the exempt path
followed by a path separator ('/').

:param str path: The request path to check (e.g., '/health/live', '/api/users')
:param set exempt: Set of exempt path prefixes (e.g., {'/health', '/metrics'})
:return: True if the path matches any exempt prefix, False otherwise
:rtype: bool

Examples:
Matching cases (returns True):
- path='/health/live', exempt={'/health'} -> True
- path='/health/ready', exempt={'/health'} -> True
- path='/metrics/prometheus', exempt={'/metrics'} -> True

Non-matching cases (returns False):
- path='/health', exempt={'/health'} -> False (exact match without trailing slash)
- path='/api-admin', exempt={'/api'} -> False (not a path separator boundary)
- path='/app_status_admin', exempt={'/app_status'} -> False (underscore, not separator)
- path='/healthcare', exempt={'/health'} -> False (different path)
"""
for exempt_path in exempt:
# Exact match or prefix match with path separator
# For instance this prevents /api matching /api-admin or /app_status matching /app_status_admin
if path.startswith(exempt_path.rstrip('/') + '/'):
return True
return False
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "mauth-client"
version = "1.6.6"
version = "1.6.7"
description = "MAuth Client for Python"
repository = "https://github.com/mdsol/mauth-client-python"
authors = ["Medidata Solutions <support@mdsol.com>"]
Expand Down
76 changes: 76 additions & 0 deletions tests/middlewares/asgi_test.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -278,3 +278,79 @@ async def mock_receive():
self.assertEqual(call_order[0], ("body", "http.request"))
self.assertEqual(call_order[1], ("disconnect", "http.disconnect"))
self.assertEqual(receive_calls, 2) # Called once for auth, once from app


class TestMAuthASGIMiddlewareWithPrefixMatch(unittest.TestCase):
def setUp(self):
self.app_uuid = str(uuid4())
Config.APP_UUID = self.app_uuid
Config.MAUTH_URL = "https://mauth.com"
Config.MAUTH_API_VERSION = "v1"
Config.PRIVATE_KEY = "key"

self.app = FastAPI()
self.app.add_middleware(
MAuthASGIMiddleware,
exempt={"/health", "/metrics"},
exempt_prefix_match=True
)

@self.app.get("/")
async def root():
return {"msg": "authenticated"}

@self.app.get("/health")
async def health_exact():
return {"msg": "exact health"}

@self.app.get("/health/live")
async def health_live():
return {"msg": "health live"}

@self.app.get("/health/ready")
async def health_ready():
return {"msg": "health ready"}

@self.app.get("/metrics/prometheus")
async def metrics():
return {"msg": "metrics"}

@self.app.get("/api/health")
async def api_health():
return {"msg": "api health"}

self.client = TestClient(self.app)

def test_prefix_match_allows_nested_paths(self):
"""Test that nested paths under exempt prefix are allowed"""
response = self.client.get("/health/live")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"msg": "health live"})

response = self.client.get("/health/ready")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"msg": "health ready"})

response = self.client.get("/metrics/prometheus")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"msg": "metrics"})

def test_prefix_match_blocks_similar_paths(self):
"""Test that similar but non-matching paths are still blocked"""
response = self.client.get("/api/health")
self.assertEqual(response.status_code, 401)

def test_prefix_match_allows_exact_match_in_exempt_set(self):
"""Test that exact match in exempt set is allowed (from exact match check)"""
response = self.client.get("/health")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"msg": "exact health"})

@patch.object(LocalAuthenticator, "is_authentic")
def test_prefix_match_still_authenticates_non_exempt_paths(self, is_authentic_mock):
"""Test that non-exempt paths still require authentication"""
is_authentic_mock.return_value = (True, 200, "")

response = self.client.get("/")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"msg": "authenticated"})
76 changes: 76 additions & 0 deletions tests/middlewares/wsgi_test.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -192,3 +192,79 @@ def post_test():

self.assertEqual(response.status_code, 200)
self.assertEqual(response.json, body)


class TestMAuthWSGIMiddlewareWithPrefixMatch(unittest.TestCase):
def setUp(self):
self.app_uuid = str(uuid4())
Config.APP_UUID = self.app_uuid
Config.MAUTH_URL = "https://mauth.com"
Config.MAUTH_API_VERSION = "v1"
Config.PRIVATE_KEY = "key"

self.app = Flask("Test App")
self.app.wsgi_app = MAuthWSGIMiddleware(
self.app.wsgi_app,
exempt={"/health", "/metrics"},
exempt_prefix_match=True
)

@self.app.get("/")
def root():
return "authenticated!"

@self.app.get("/health")
def health_exact():
return "exact health"

@self.app.get("/health/live")
def health_live():
return "health live"

@self.app.get("/health/ready")
def health_ready():
return "health ready"

@self.app.get("/metrics/prometheus")
def metrics():
return "metrics"

@self.app.get("/api/health")
def api_health():
return "api health"

self.client = self.app.test_client()

def test_prefix_match_allows_nested_paths(self):
"""Test that nested paths under exempt prefix are allowed"""
response = self.client.get("/health/live")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_data(as_text=True), "health live")

response = self.client.get("/health/ready")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_data(as_text=True), "health ready")

response = self.client.get("/metrics/prometheus")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_data(as_text=True), "metrics")

def test_prefix_match_blocks_similar_paths(self):
"""Test that similar but non-matching paths are still blocked"""
response = self.client.get("/api/health")
self.assertEqual(response.status_code, 401)

def test_prefix_match_allows_exact_match_in_exempt_set(self):
"""Test that exact match in exempt set is allowed (from exact match check)"""
response = self.client.get("/health")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_data(as_text=True), "exact health")

@patch.object(LocalAuthenticator, "is_authentic")
def test_prefix_match_still_authenticates_non_exempt_paths(self, is_authentic_mock):
"""Test that non-exempt paths still require authentication"""
is_authentic_mock.return_value = (True, 200, "")

response = self.client.get("/")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_data(as_text=True), "authenticated!")
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
# 1.6.7
- Added optional substring exempt path matching when `exempt_prefix_match` is `True`

# 1.6.6
- Support long-lived connections in ASGI middleware

Expand Down
8 changes: 6 additions & 2 deletions mauth_client/middlewares/asgi.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,16 +19,17 @@
)
from mauth_client.signable import RequestSignable
from mauth_client.signed import Signed
from mauth_client.utils import decode
from mauth_client.utils import decode, is_exempt_request_path

logger = logging.getLogger("mauth_asgi")


class MAuthASGIMiddleware:
def __init__(self, app: ASGI3Application, exempt: Optional[set] = None) -> None:
def __init__(self, app: ASGI3Application, exempt: Optional[set] = None, exempt_prefix_match: bool = False) -> None:
self._validate_configs()
self.app = app
self.exempt = exempt.copy() if exempt else set()
self.exempt_prefix_match = exempt_prefix_match

async def __call__(
self, scope: Scope, receive: ASGIReceiveCallable, send: ASGISendCallable
Expand All@@ -40,6 +41,9 @@ async def __call__(
if path in self.exempt:
return await self.app(scope, receive, send)

if self.exempt_prefix_match and is_exempt_request_path(path, self.exempt):
return await self.app(scope, receive, send)

query_string = scope["query_string"]
url = f"{path}?{decode(query_string)}" if query_string else path
headers = {decode(k): decode(v) for k, v in scope["headers"]}
Expand Down
7 changes: 6 additions & 1 deletion mauth_client/middlewares/wsgi.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,22 +14,27 @@

from mauth_client.signable import RequestSignable
from mauth_client.signed import Signed
from mauth_client.utils import is_exempt_request_path

logger = logging.getLogger("mauth_wsgi")


class MAuthWSGIMiddleware:
def __init__(self, app, exempt=None):
def __init__(self, app, exempt=None, exempt_prefix_match=False):
self._validate_configs()
self.app = app
self.exempt = exempt.copy() if exempt else set()
self.exempt_prefix_match = exempt_prefix_match

def __call__(self, environ, start_response):
path = environ.get("PATH_INFO", "")

if path in self.exempt:
return self.app(environ, start_response)

if self.exempt_prefix_match and is_exempt_request_path(path, self.exempt):
return self.app(environ, start_response)

signable = RequestSignable(
method=environ["REQUEST_METHOD"],
url=self._extract_url(environ),
Expand Down
33 changes: 33 additions & 0 deletions mauth_client/utils.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -32,3 +32,36 @@ def decode(byte_string: bytes) -> str:
except UnicodeDecodeError:
encoding = charset_normalizer.detect(byte_string)["encoding"]
return byte_string.decode(encoding)


def is_exempt_request_path(path: str, exempt: set) -> bool:
"""
Check if a request path should be exempt from authentication based on prefix matching.

This function performs prefix matching with path separator boundary checking to prevent
false positives. A path matches an exempt prefix only if it starts with the exempt path
followed by a path separator ('/').

:param str path: The request path to check (e.g., '/health/live', '/api/users')
:param set exempt: Set of exempt path prefixes (e.g., {'/health', '/metrics'})
:return: True if the path matches any exempt prefix, False otherwise
:rtype: bool

Examples:
Matching cases (returns True):
- path='/health/live', exempt={'/health'} -> True
- path='/health/ready', exempt={'/health'} -> True
- path='/metrics/prometheus', exempt={'/metrics'} -> True

Non-matching cases (returns False):
- path='/health', exempt={'/health'} -> False (exact match without trailing slash)
- path='/api-admin', exempt={'/api'} -> False (not a path separator boundary)
- path='/app_status_admin', exempt={'/app_status'} -> False (underscore, not separator)
- path='/healthcare', exempt={'/health'} -> False (different path)
"""
for exempt_path in exempt:
# Exact match or prefix match with path separator
# For instance this prevents /api matching /api-admin or /app_status matching /app_status_admin
if path.startswith(exempt_path.rstrip('/') + '/'):
return True
return False
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "mauth-client"
version = "1.6.6"
version = "1.6.7"
description = "MAuth Client for Python"
repository = "https://github.com/mdsol/mauth-client-python"
authors = ["Medidata Solutions <support@mdsol.com>"]
Expand Down
76 changes: 76 additions & 0 deletions tests/middlewares/asgi_test.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -278,3 +278,79 @@ async def mock_receive():
self.assertEqual(call_order[0], ("body", "http.request"))
self.assertEqual(call_order[1], ("disconnect", "http.disconnect"))
self.assertEqual(receive_calls, 2) # Called once for auth, once from app


class TestMAuthASGIMiddlewareWithPrefixMatch(unittest.TestCase):
def setUp(self):
self.app_uuid = str(uuid4())
Config.APP_UUID = self.app_uuid
Config.MAUTH_URL = "https://mauth.com"
Config.MAUTH_API_VERSION = "v1"
Config.PRIVATE_KEY = "key"

self.app = FastAPI()
self.app.add_middleware(
MAuthASGIMiddleware,
exempt={"/health", "/metrics"},
exempt_prefix_match=True
)

@self.app.get("/")
async def root():
return {"msg": "authenticated"}

@self.app.get("/health")
async def health_exact():
return {"msg": "exact health"}

@self.app.get("/health/live")
async def health_live():
return {"msg": "health live"}

@self.app.get("/health/ready")
async def health_ready():
return {"msg": "health ready"}

@self.app.get("/metrics/prometheus")
async def metrics():
return {"msg": "metrics"}

@self.app.get("/api/health")
async def api_health():
return {"msg": "api health"}

self.client = TestClient(self.app)

def test_prefix_match_allows_nested_paths(self):
"""Test that nested paths under exempt prefix are allowed"""
response = self.client.get("/health/live")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"msg": "health live"})

response = self.client.get("/health/ready")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"msg": "health ready"})

response = self.client.get("/metrics/prometheus")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"msg": "metrics"})

def test_prefix_match_blocks_similar_paths(self):
"""Test that similar but non-matching paths are still blocked"""
response = self.client.get("/api/health")
self.assertEqual(response.status_code, 401)

def test_prefix_match_allows_exact_match_in_exempt_set(self):
"""Test that exact match in exempt set is allowed (from exact match check)"""
response = self.client.get("/health")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"msg": "exact health"})

@patch.object(LocalAuthenticator, "is_authentic")
def test_prefix_match_still_authenticates_non_exempt_paths(self, is_authentic_mock):
"""Test that non-exempt paths still require authentication"""
is_authentic_mock.return_value = (True, 200, "")

response = self.client.get("/")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"msg": "authenticated"})
76 changes: 76 additions & 0 deletions tests/middlewares/wsgi_test.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -192,3 +192,79 @@ def post_test():

self.assertEqual(response.status_code, 200)
self.assertEqual(response.json, body)


class TestMAuthWSGIMiddlewareWithPrefixMatch(unittest.TestCase):
def setUp(self):
self.app_uuid = str(uuid4())
Config.APP_UUID = self.app_uuid
Config.MAUTH_URL = "https://mauth.com"
Config.MAUTH_API_VERSION = "v1"
Config.PRIVATE_KEY = "key"

self.app = Flask("Test App")
self.app.wsgi_app = MAuthWSGIMiddleware(
self.app.wsgi_app,
exempt={"/health", "/metrics"},
exempt_prefix_match=True
)

@self.app.get("/")
def root():
return "authenticated!"

@self.app.get("/health")
def health_exact():
return "exact health"

@self.app.get("/health/live")
def health_live():
return "health live"

@self.app.get("/health/ready")
def health_ready():
return "health ready"

@self.app.get("/metrics/prometheus")
def metrics():
return "metrics"

@self.app.get("/api/health")
def api_health():
return "api health"

self.client = self.app.test_client()

def test_prefix_match_allows_nested_paths(self):
"""Test that nested paths under exempt prefix are allowed"""
response = self.client.get("/health/live")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_data(as_text=True), "health live")

response = self.client.get("/health/ready")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_data(as_text=True), "health ready")

response = self.client.get("/metrics/prometheus")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_data(as_text=True), "metrics")

def test_prefix_match_blocks_similar_paths(self):
"""Test that similar but non-matching paths are still blocked"""
response = self.client.get("/api/health")
self.assertEqual(response.status_code, 401)

def test_prefix_match_allows_exact_match_in_exempt_set(self):
"""Test that exact match in exempt set is allowed (from exact match check)"""
response = self.client.get("/health")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_data(as_text=True), "exact health")

@patch.object(LocalAuthenticator, "is_authentic")
def test_prefix_match_still_authenticates_non_exempt_paths(self, is_authentic_mock):
"""Test that non-exempt paths still require authentication"""
is_authentic_mock.return_value = (True, 200, "")

response = self.client.get("/")
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_data(as_text=True), "authenticated!")
Loading
Loading