Uh oh!
There was an error while loading. Please reload this page.
Support chinese - #34
Closed
wangyum wants to merge 3 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
You are using a hard coded line separator here. Do you have a specific reason not to use System.lineSeparator() instead?
guerda
commented
Nov 24, 2015
Contributor
Does the changed code work on Western European texts as well? I think this might be a big change, especially to just use characters at all times. |
wangyum
commented
Nov 25, 2015
Author
Yeah, it works well on Western European texts. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.