chore: organize dependencies - #271
Conversation
augustoccesar
commented
Apr 7, 2026
- Move dependencies that are used on multiple crates to be defined on the workspace (use the highest version).
- Use the exported wasm_bindgen on worker instead of defining dependency.
- Move dependencies that are used on multiple crates to be defined on the workspace (use the highest version). - Use the exported wasm_bindgen on worker instead of defining dependency.
Druue
left a comment
There was a problem hiding this comment.
I didn't realise that we had a local fork -- the cloudflare workspace/crate
It's using it's own versions for reqwest and some other deps too:
| Dependency | cloudflare/Cargo.toml | workspace Cargo.toml |
|---|---|---|
http |
"1" |
"1.2.0" |
reqwest |
0.12.12 (no defaults, json) |
0.13.2 (no defaults) |
serde |
"1.0" (with derive) |
"1.0.217" |
serde_json |
"1.0" |
"1.0.138" |
thiserror |
"2" |
"2.0.11" |
url |
"2.2" |
"2.5.4" (with serde) |
Is the goal here to minimise changes to this crate and only modify what's really needed for linkup hence why we're not using workspace versions here?
|
|
||
| members = ["linkup-cli", "linkup", "worker", "local-server", "server-tests", "cloudflare"] | ||
|
|
||
| [workspace.dependencies] |
Yes. That is a copy-paste of the original code from cloudflare at that time with some small tweaks that we needed to make things work, so I don't want to change its dependencies. |
- Move dependencies that are used on multiple crates to be defined on the workspace (use the highest version). - Use the exported wasm_bindgen on worker instead of defining dependency.
- Move dependencies that are used on multiple crates to be defined on the workspace (use the highest version). - Use the exported wasm_bindgen on worker instead of defining dependency.