Skip to content

Test graph container - #24

Open
RISHI27-dot wants to merge 10 commits into
meshtag:testingfrom
RISHI27-dot:test_graph_container
Open

Test graph container#24
RISHI27-dot wants to merge 10 commits into
meshtag:testingfrom
RISHI27-dot:test_graph_container

Conversation

@RISHI27-dot

@RISHI27-dotRISHI27-dot commented Nov 1, 2022•
edited
Loading

Copy link
Copy Markdown

This PR tests the translation of graphs into MemRef using a variety of different graph representations. Additionally, this PR includes tests for the overloaded operators and constructors of the MemRef Class.

An object of the Graph class is created and edges are added to the graph. The graph is then converted to MemRef. Now, a MemRef class object is created with the allocated, strided, size, and sizes fields hardcoded, giving us a resulting MemRef object that should exactly match the MemRef obtained after the conversion from the graph. Comparison of the two MemRef class objects is handled by the overloaded comparison operator.

@RISHI27-dot
RISHI27-dot marked this pull request as ready for review November 1, 2022 06:18
meshtag
meshtag requested changes Nov 5, 2022
View reviewed changes

@meshtagmeshtag left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a clear description for your PR. You can summarize your thinking and express any design changes proposed by you.

Comment threadCMakeLists.txt Outdated
Comment threadCMakeLists.txt Outdated
Comment threadexamples/bfsExample.cpp Outdated
Comment threadlib/Interface/Container.cpp Outdated
Comment threadlib/Interface/Container.cpp
Comment threadunittests/CMakeLists.txt Outdated
Comment threadunittests/Interface/ContainerTest.cpp Outdated
Comment threadunittests/Interface/GraphContainerTest.cpp
@RISHI27-dot
RISHI27-dot marked this pull request as draft November 7, 2022 19:09
@RISHI27-dot
RISHI27-dot marked this pull request as ready for review November 8, 2022 18:53
meshtag
meshtag requested changes Nov 13, 2022
View reviewed changes
Comment threadtests/unittests/Interface/GraphContainerTest.cpp Outdated
Comment threadtests/unittests/Interface/GraphContainerTest.cpp Outdated
Comment threadtests/unittests/Interface/GraphContainerTest.cpp Outdated
Comment threadCMakeLists.txt Outdated
Comment threadtests/unittests/Interface/ContainerTest.cpp
Comment threadtests/unittests/Interface/ContainerTest.cpp Outdated
@meshtag

meshtag commented Feb 26, 2023

Copy link
Copy Markdown
Owner

Ping @RISHI27-dot

Rishikesh Donadkar
Requested changes in Interface Tests.
84d7aa0
1. Removed the print statements in tests.
2. Use different approach for testing the move assignment operator and
the move constructor.
3. Steal the members of the original object using std::swap() as the
constructor MemRef<float, 2>::MemRef cannot be called directly.
4. Remove unwanted variable in CMakeLists.txt
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@meshtagmeshtagmeshtag requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RISHI27-dot@meshtag@sarrah-basta