Uh oh!
There was an error while loading. Please reload this page.
MAINT: avoid warnings because of symlinks pointing outside repo - #747
Conversation
fa269c5 to
ebe7411Compare
dnicolodi
left a comment
There was a problem hiding this comment.
Another solution would be to create the symlinks in the test code. This is simpler, but should we add a note in the test somewhere stating that these test files are not present in the sdist?
Uh oh!
There was an error while loading. Please reload this page.
ebe7411 to
5915072Comparergommers
commented
Jul 15, 2025
I prefer this, both because it's simpler and because I regularly use test packages directly rather than via a |
rgommers
commented
Jul 15, 2025
Added the note in the test case itself, that is indeed useful. |
rgommers
commented
Jul 15, 2025
CI failure is unrelated, looks like a change in Meson master: |
eli-schwartz
commented
Jul 15, 2025
mesonbuild/meson#12194 probably. |
dnicolodi
commented
Jul 15, 2025
Most likely. That patch changes the format of the introspection data used by meson-python. So far meson-python assumes that the introspection data uses native path separators. Now, some data uses native path separators, and some uses POSIX path separators independently of the platform. For supporting Meson version before and after the change, meson-python will need to normalize all paths read from introspection data. |
rgommers
commented
Jul 16, 2025
I opened gh-778 to keep track of the new failure. This PR is ready to merge I'd say. |
5915072 to
e344701Comparee344701 to
d95885dComparednicolodi
commented
Jul 31, 2025
I moved the note in a place where it makes more sense. |
Follows up on #728 (comment) and gh-745.