Uh oh!
There was an error while loading. Please reload this page.
BUG: use the correct encoding to read the compilation log - #887
Merged
Conversation
dnicolodiforce-pushed
the
fix/compilation-log-encoding
branch
from
September 2, 2026 19:15
4e432fe to
177b976Comparednicolodiforce-pushed
the
fix/compilation-log-encoding
branch
from
September 2, 2026 19:37
177b976 to
d8b2495Comparergommers
approved these changes
Sep 3, 2026
rgommers
left a comment
Contributor
There was a problem hiding this comment.
This LGTM, and CI is all green - so in it goes. Thanks @dnicolodi!
Uh oh!
There was an error while loading. Please reload this page.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to the recently-merged gh-859, and in particular the
encodingcomments starting at #859 (comment).