Uh oh!
There was an error while loading. Please reload this page.
upgrade deps - #75
Merged
Merged
Conversation
jalerson
reviewed
Apr 3, 2022
Uh oh!
There was an error while loading. Please reload this page.
marcelcorso
commented
Apr 3, 2022
via email
ContributorAuthor
Yes. But we should fix them anyway.
If we do a major version release it's ok …On Sun, Apr 3, 2022, 10:14 Jalerson Lima ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In lib/messagebird/callflow.rb
<#75 (comment)>
:
> @@ -26,7 +26,8 @@ def updated_at=(value)
end
class CallFlowList < List
- attr_accessor :perPage, :currentPage, :pageCount, :totalCount
Aren't these breaking changes?
—
Reply to this email directly, view it on GitHub
<#75 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAEZOWVFM7KNURFBXIFMU3VDFHNDANCNFSM5SEVC3FA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
jalerson
reviewed
Apr 3, 2022
Uh oh!
There was an error while loading. Please reload this page.
jalerson
reviewed
Apr 3, 2022
Uh oh!
There was an error while loading. Please reload this page.
jalerson
reviewed
Apr 3, 2022
jalerson
left a comment
Contributor
There was a problem hiding this comment.
Very nice work! Added a few comments.
jalerson
commented
Apr 3, 2022
Contributor
@marcelcorso if we're going to go with a major release, let's ship this one as well? It fixes #22 |
marcelcorso
commented
Apr 4, 2022
ContributorAuthor
@jalerson yes! |
Co-authored-by: Jalerson Lima <jalerson.lima@messagebird.com>
Co-authored-by: Jalerson Lima <jalerson.lima@messagebird.com>
jalerson
approved these changes
Apr 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on #74 we added github actions but we didn't manage to pass tests.
on #76 we made them pass with old ruby targets.
on this PR I try to modernise ✨ things like target new rubies on rubocop or raise gem limits of rubocup and rspec.