Skip to content

Definition of Audit API. - #186

Merged
Gerrit91 merged 30 commits into
mainfrom
audit-api
Apr 23, 2025
Merged

Definition of Audit API.#186
Gerrit91 merged 30 commits into
mainfrom
audit-api

Conversation

@Gerrit91

@Gerrit91Gerrit91 commented Nov 29, 2024

Copy link
Copy Markdown
Contributor

No description provided.

Gerrit91
Gerrit91 commented Jan 13, 2025
View reviewed changes
Comment threadproto/api/v1/audit.proto Outdated
majst01
majst01 requested changes Jan 16, 2025
View reviewed changes
Comment threadproto/api/v1/audit.proto Outdated
Comment threadproto/api/v1/audit.proto Outdated
Comment threadproto/api/v1/audit.proto Outdated
Comment threadproto/api/v1/audit.proto Outdated
Comment threadproto/api/v1/audit.proto Outdated
majst01
majst01 reviewed Jan 20, 2025
View reviewed changes
Comment threadproto/api/v1/audit.proto Outdated
@ostempel
ostempel requested a review from majst01January 27, 2025 10:44
@ostempel
ostempel marked this pull request as ready for review January 27, 2025 10:53
majst01
majst01 reviewed Jan 27, 2025
View reviewed changes
Comment threadproto/api/v1/audit.proto Outdated
majst01
majst01 requested changes Mar 7, 2025
View reviewed changes
Comment threadproto/api/v1/audit.proto Outdated
Comment threadproto/api/v1/audit.proto Outdated
Comment threadproto/api/v1/audit.proto Outdated
Gerrit91
Gerrit91 commented Mar 11, 2025
View reviewed changes
Comment threadproto/api/v1/audit.proto Outdated
@ostempelostempel mentioned this pull request Mar 25, 2025
Merged
Gerrit91
Gerrit91 commented Apr 23, 2025
View reviewed changes

@Gerrit91Gerrit91 left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only improvements on comments / docs.

Comment threadproto/api/v1/audit.proto Outdated
Comment threadproto/api/v1/audit.proto Outdated
Comment threadproto/api/v1/audit.proto Outdated
Comment threadproto/api/v1/audit.proto Outdated
Comment threadproto/api/v1/audit.proto Outdated
Comment threadproto/api/v1/audit.proto Outdated
Comment threadproto/api/v1/audit.proto Outdated
Comment threadproto/api/v1/audit.proto Outdated
Gerrit91
Gerrit91 commented Apr 23, 2025
View reviewed changes

@Gerrit91Gerrit91 left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only improvements on comments / docs.

Comment threadproto/api/v1/audit.proto Outdated
Comment threadproto/api/v1/audit.proto Outdated
@Gerrit91

Gerrit91 commented Apr 23, 2025

Copy link
Copy Markdown
ContributorAuthor

We should somehow discuss how we want to deal with default values for the API. It's problematic to write them into the doc strings of the API because this implies an update of the API repository if we want to change the default in the api-server. On the other hand we do not have a documentation portal where we describe these things and clients also should not handle them individually.

@Gerrit91
Gerrit91 merged commit 0bf6d41 into mainApr 23, 2025
@Gerrit91
Gerrit91 deleted the audit-api branch April 23, 2025 13:46
@Gerrit91Gerrit91 mentioned this pull request Apr 23, 2025
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@majst01majst01majst01 approved these changes
@vknabelvknabelvknabel approved these changes
@ostempelostempelAwaiting requested review from ostempel
@mac641mac641Awaiting requested review from mac641

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Gerrit91@majst01@vknabel@ostempel@AnnaSchreiner