Uh oh!
There was an error while loading. Please reload this page.
chore: streamline project foundation and document architecture decision - #6
Merged
Merged
Conversation
- Remove smoke and functional test source sets and tasks. - Remove JaCoCo and SonarQube plugins and configurations. - Clean up task workarounds for deleted source sets.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR documents the architectural rationale for choosing between a “downgraded HMCTS template” and a greenfield Spring Boot project, while streamlining the repository by removing build/test/quality tooling and several template-derived endpoints/tests to reduce build overhead and confusion.
Changes:
- Added ADR 0001 under
docs/adr/describing the template-vs-greenfield evaluation and decision criteria. - Simplified Gradle build by removing JaCoCo/SonarQube and dropping functional/smoke test source sets/tasks, keeping only
integrationTest. - Removed template-provided
RootController, OpenAPI configuration, and related smoke/functional/integration tests.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
build.gradle | Removes JaCoCo/SonarQube and simplifies test source sets/tasks to reduce build overhead. |
src/main/resources/application.yaml | Minor formatting/comment tweak to actuator health show-details. |
docs/adr/0001-project-foundation-choice.md | Adds ADR documenting the project foundation decision process. |
src/main/java/uk/gov/hmcts/reform/dataViewstoreRestApi/controllers/RootController.java | Removes the template welcome/root endpoint. |
src/main/java/uk/gov/hmcts/reform/dataViewstoreRestApi/config/OpenAPIConfiguration.java | Removes custom OpenAPI bean configuration. |
src/test/java/.../DemoUnitTest.java | Deletes placeholder unit test. |
src/smokeTest/java/.../SampleSmokeTest.java | Removes smoke test suite and its dependency usage. |
src/functionalTest/java/.../SampleFunctionalTest.java | Removes functional test suite and its dependency usage. |
src/integrationTest/java/.../GetWelcomeTest.java | Removes integration test tied to the deleted root endpoint. |
src/integrationTest/java/.../OpenAPIPublisherTest.java | Removes OpenAPI publishing test tied to removed template tooling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Comment on lines
+2
to
+3
| This ADR follows 'The ADR GitHub Organization' (https://github.com/architecture-decision-record/architecture-decision-record) ADR standards which recommends the docs/adr folder | ||
| structure. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
newmaldenite pushed a commit
that referenced
this pull request
Jun 2, 2026
…on (#6) * Refactor: Streamline project structure and simplify build.gradle - Remove smoke and functional test source sets and tasks. - Remove JaCoCo and SonarQube plugins and configurations. - Clean up task workarounds for deleted source sets. * Add basic instructions/links in README.md --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/PDE-985
Change description
Changes:
docs/adr/describing the template-vs-greenfield evaluation and decision criteria.integrationTest.RootController, OpenAPI configuration, and related smoke/functional/integration tests.Does this PR introduce a breaking change? (check one with "x")
Yes (Architectural change). This PR significantly alters the project structure by removing deployment-related folders. However, the core Spring Boot application and database logic remain fully functional.