Uh oh!
There was an error while loading. Please reload this page.
Docker file for CSSIFY - #23
Conversation
sansyrox
left a comment
There was a problem hiding this comment.
@ShubhamPatel33 , please do not commit the package-lock.json from the commit.
And can you show the POC maybe like a gif that the dockerfile is working?
sansyrox
commented
Feb 27, 2021
@ShubhamPatel33 , i was referring to this one: client/package-lock.json |
aeyshubh
commented
Feb 27, 2021
Okay,is it fine now, only gif remaining,correct ? |
sansyrox
commented
Feb 27, 2021
Yes, @ShubhamPatel33 . Even a simple video would suffice. |
aeyshubh
commented
Feb 27, 2021
Created a small video how one can start the docker and have fun with it . Uploading demo_dockerfile.mp4… |
aeyshubh
commented
Feb 27, 2021
demo_dockerfile.mp4 |
sansyrox
commented
Feb 27, 2021
@ShubhamPatel33 , good work! But this is not what I was looking for. By deployment, we are looking to expose the port locally. You'd have to do more work in this PR and create a way so that you can read access the port through your localhost. |
aeyshubh
commented
Feb 27, 2021
aeyshubh
commented
Feb 27, 2021
Thanks |
aeyshubh
commented
Mar 1, 2021
Updating the video by the docker build and run command. docker_final.mp4 |
sansyrox
commented
Mar 2, 2021
Looks good! |
| "react-bootstrap": "^1.0.1", | ||
| "react-dom": "^16.13.1", | ||
| "react-scripts": "^3.4.4", | ||
| "react-scripts": "^4.0.3", |
There was a problem hiding this comment.
These changes were automatically been made while making the docker file
| "helmet": "^3.22.0", | ||
| "node-sass": "^4.14.1", | ||
| "node-sass-json-importer": "^4.3.0", | ||
| "socket.io": "^3.1.2", |
There was a problem hiding this comment.
These changes were automatically been made while making the docker file
There was a problem hiding this comment.
@ShubhamPatel33, please remove the socket io dependency as it is not required. And sorry for the slow reviews, have been a little occupied lately.
There was a problem hiding this comment.
Removed the socket.io,will it gonna count in Mwoc as the PR was made in the mentioned date and the changes took some time .
sansyrox
commented
Mar 2, 2021
All looks good, please do these minor tweaks before we merge it. |
Thanks, finally it will be merged . |
issue #5
Description
I have created a docker file for CSSIFY with NOde version of 14 which is compatible for the project.
Motivation and Context
How Has This Been Tested?
The file was successfully built and no errors were generated.
Screenshots (if appropriate):
Types of changes
Checklist: