Uh oh!
There was an error while loading. Please reload this page.
Align CI with org-wide shared Python workflow template - #554
Merged
Conversation
Inline the ruff/ty/pytest steps directly (matching meyer-lab/.github's python-uv-ruff-pytest template) instead of going through make targets, and add pull_request as a trigger alongside push.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/test.ymlto inline the ruff/ty/pytest steps directly, matching the pattern in meyer-lab/.github'spython-uv-ruff-pytesttemplate (uv sync -> ruff check -> ruff format --check -> ty check -> pytest --cov), instead of going throughmake lint/make typecheck/make coverage.pull_requestas a trigger alongsidepush, and enables uv's dependency cache.ruff check ddmc,ruff format --check ddmc,ty check ddmc,pytest --cov=ddmc --cov-report=term) — themakefiletargets stay available for local use.Test plan