[lenny] integrate REG-10: per-community brand color (NIP-11 buzz_brand_color, migration 0048) by mfethe1 · Pull Request #30 · mfethe1/buzz

mfethe1 · 2026-09-10T15:38:46Z

What changed

Per-community brand color on the workspace profile (kind:9033 write path, same seam as icon), served as namespaced buzz_brand_color in the NIP-11 document — host-scoped, no cross-tenant leak (conformance A≡B proof extended).
Desktop: relayBrandColor.ts applies the relay-advertised color as a composable custom property; 202-line test module.
Migration renumbered 0037→0048 per Michael's 2026-09-10 owner resolve (thread 79398): 0037 is upstream-owned relay_admin_action_lease, 0047 contested by upstream feat(desktop): report private per-Desktop runtime capabilities block/buzz#7333.

Merge resolution (feat/REG-10 `6e1565f` × product/main `adeec6e`)

runtime/migration.rs: count 45→46; brand test retargeted to version 48; include_str path depth fixed for the runtime/ move.
nip11.rs: RelayInfo::build merged to 8 params (brand_color 3rd; trunk's admin_api kept 7th); all 16 test call sites updated; trunk's admin_api test suite preserved intact.
Both sides preserved per owner resolve: upstream 0037 functionality AND the REG-10 design.

Evidence (run 99, 2026-09-10)

buzz-db --lib: 127P/0F · buzz-core: 262P/0F · buzz-acp: 968P/0F
buzz-relay --lib: 1066P/6F — failure name-set vs baseline(product/main adeec6e): zero regressions (comm -23 empty; the 6 = pre-existing api::media cluster; baseline's 7th, mesh_demo known-flake, passed on candidate)
desktop: typecheck rc=0; all 5 check:* guards rc=0; unit 6594P/1F — the 1 (provenance context follows exact local inventory...) fails IDENTICALLY on baseline → zero regressions; 12 new brand-color tests green
flutter analyze: 7 diagnostics = owner-acknowledged baseline (identical signatures); flutter test: 15 failures = baseline count, mobile/ byte-identical to product/main (0 diff lines)
community_brand_color_is_additive_and_mirrored_in_desired_state passes on the merged tree
DCO: branch commits signed-off (Michael Feth); merge commit signed-off; no AI attribution trailers

Sensitive paths (owner merge required — never self-merge)

migrations/0048_community_brand_color.sql (schema), schema/schema.sql, crates/buzz-db/src/store/community.rs
kind:9033 write authorization (relay_admin.rs), pre-auth NIP-11 exposure (nip11.rs)

UNVERIFIED

Postgres-gated tests (258 ignored in buzz-db; brand_color round-trip, relay_admin postgres_tests): no test database on this host — requires CI/host with Postgres.
Visual evidence: not captured this run (desktop-only theme change; NIP-11 JSON serialization proven by unit tests instead). Evidence gap stated explicitly per DIGEST_CONTRACT.

Merge commit: 129a3ec (integration/reg10-brand-color-run99). Authored locally (REG-10 branch authored by lenny/claude-loop, adopted per owner resolve).

…REG-10)

Signed-off-by: Michael Feth <mfethe1@gmail.com>

…ered 0037->0048 per owner resolve thread 79398) Merge feat/REG-10 (6e1565f) into product/main (adeec6e), resolving both sides per Michael's 2026-09-10 owner resolve: - migration 0037_community_brand_color.sql -> 0048_community_brand_color.sql (0037 is upstream-owned relay_admin_action_lease; 0047 contested by block#7333) - runtime/migration.rs: count 45 -> 46; brand-color test retargeted version 48 - nip11.rs: RelayInfo::build merged to 8 params (brand_color 3rd, admin_api kept); all test call sites updated; both icon and admin_api test suites kept Signed-off-by: Michael Feth <mfethe1@gmail.com>

coderabbitai · 2026-09-10T15:38:57Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 533ab41b-801a-4713-a75f-96959db840f0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

…ntegration The run-99 worktree applied these fixes after the merge commit but they were not committed before push: (1) include_str depth for runtime/ move, (2) five 7-arg RelayInfo::build test calls extended to the merged 8-param signature. Signed-off-by: Michael Feth <mfethe1@gmail.com>

…un in brand color test - cargo fmt --all on crates/buzz-relay/src/nip11.rs (7 diffs, all from RelayInfo::build gaining the brand_color parameter) - #[allow(clippy::too_many_arguments)] on RelayInfo::build with rationale; the parameter is required by REG-10 and pushes arity to 8/7. Verified this is the only arity site in the workspace. - Drop redundant run_migrations() from community_brand_color_round_trips_and_clears_independently_from_icon. setup_db() connects to an already-migrated shared test database; re-running migrations replayed 0001's CREATE TYPE channel_type and failed 42710. No other test in community.rs calls run_migrations. Local gates: cargo fmt --all -- --check exit 0; cargo clippy --workspace --all-targets -- -D warnings clean.

Trunk landed 0047_agent_machine_homes (AGENT-HOMES-001 PR-3) while this branch carried its own 0047_task_event_changes, so both sides claimed version 47. PR #30 already owns 0048_community_brand_color, so this takes 0049. sqlx::migrate! globs migrations/ by filename, so renaming the file is the whole renumber. Inventory assertions pin 47 migrations, 46/47/49.

Trunk landed 0047_agent_machine_homes while this branch carried its own 0047_task_optimistic_concurrency. PR #30 owns 0048 and PR #18 owns 0049, so this takes 0050 (matching the numbering PR #27 already expects). sqlx::migrate! globs migrations/ by filename, so the rename is the whole renumber. Inventory now pins 47 migrations with 50 last.

Trunk landed 0047_agent_machine_homes; this branch keeps 0048_community_brand_color. Both are additive, so the inventory is 47 with 48 last.

…eg10-brand-color-run99 # Conflicts: # crates/buzz-db/src/runtime/migration.rs

mfethe1 · 2026-09-17T00:16:38Z

🧪 Jev PR-Triage Pilot

PR #30: [lenny] integrate REG-10: per-community brand color (NIP-11 buzz_brand_color, migration 0048) — verdict: BLOCK

question	answer	confidence
sensitive_path	P(yes)=0.99	—
test_coverage	P(yes)=0.99	—
size_concern	P(yes)=0.91	—
risk	1.97/2	0.95
route	needs_review	0.77
block_reason	sensitive_path	0.91

Block reason (if any): sensitive_path
Pilot: Jev (System One) typed triage. Verdict thresholds in code; escalate on low confidence.

mfethe1 · 2026-09-17T00:52:45Z

🧪 Jev PR-Triage (v3)

PR #30: [lenny] integrate REG-10: per-community brand color (NIP-11 buzz_brand_color, migration 0048) — verdict: BLOCK

dimension	metric	value
Correctness	problem resolved	P(yes)=0.70
Correctness	rework needed	0.37/2
Quality	code quality	1.90/2
Quality	test coverage	P(yes)=0.98
Architecture	integration compatibility	2.00/2
Architecture	future proof	1.52/2
Governance	sensitive path	P(yes)=0.98
Governance	size concern	P(yes)=0.95
Synthesis	merge risk	1.86/2
Synthesis	route	needs_review (0.77)
Diff	security exposure	P(yes)=0.18
Diff	performance impact	0.28/2

🔍 Reviewer focus

File: crates/buzz-relay/src/handlers/relay_admin.rs
Concern: security

Block reason (if any): sensitive_path
Pilot: Jev (System One) typed triage, 15 metrics + reviewer focus. Verdict thresholds in code.

…or-run99 Resolve migration.rs inventory conflict: merged tree carries 49 migrations — upstream 0045 push revocation tombstones (sync #67) + REG-10 0048 community_brand_color + fork 0046/0047/0049. Versions 45-49 at indices 44-48.

mfethe1 · 2026-09-17T02:35:12Z

🧪 Jev PR-Triage (v3)

PR #30: [lenny] integrate REG-10: per-community brand color (NIP-11 buzz_brand_color, migration 0048) — verdict: BLOCK

dimension	metric	value
Correctness	problem resolved	P(yes)=0.68
Correctness	rework needed	0.35/2
Quality	code quality	1.89/2
Quality	test coverage	P(yes)=0.98
Architecture	integration compatibility	2.00/2
Architecture	future proof	1.51/2
Governance	sensitive path	P(yes)=0.99
Governance	size concern	P(yes)=0.95
Synthesis	merge risk	1.87/2
Synthesis	route	needs_review (0.78)
Diff	security exposure	P(yes)=0.17
Diff	performance impact	0.28/2

🔍 Reviewer focus

File: crates/buzz-relay/src/handlers/relay_admin.rs
Concern: security

Block reason (if any): sensitive_path
Pilot: Jev (System One) typed triage, 15 metrics + reviewer focus. Verdict thresholds in code.

mfethe1 · 2026-09-17T22:24:33Z

🧪 Jev PR-Triage (v3) — ADVISORY, NON-GATING

PR #30: [lenny] integrate REG-10: per-community brand color (NIP-11 buzz_brand_color, migration 0048) — verdict: BLOCK

This verdict does not gate this PR and no human review requirement is waived or added by it. Jev is uncalibrated: the ground-truth corpus is 7 resolved PRs (1 bad), below the threshold to publish any AUC, so a BLOCK here carries no demonstrated predictive value. It is a reading suggestion — start at the focus file — not a judgment.

dimension	metric	value
Correctness	problem resolved	P(yes)=0.70
Correctness	rework needed	0.38/2
Quality	code quality †	1.50/2
Quality	test coverage	P(yes)=0.98
Architecture	integration compatibility †	0.90/2
Architecture	future proof †	0.90/2
Governance	sensitive path	P(yes)=0.99
Governance	size concern	P(yes)=0.95
Synthesis	merge risk	1.89/2
Synthesis	route	needs_review (0.76)
Diff	security exposure	P(yes)=0.17
Diff	performance impact	0.30/2

🔍 Reviewer focus

File: crates/buzz-relay/src/handlers/relay_admin.rs
Concern: security

Block reason (if any): sensitive_path
† PROBATIONAL — measured as an anti-signal on the (contaminated) pilot corpus; excluded from the verdict, shown for audit only.
Pilot: Jev (System One) typed triage, 15 metrics + reviewer focus. Verdict thresholds in code.

The brand_color migration was renumbered 0037 -> 0048 because 0037 is upstream-owned (relay_admin_action_lease), but two comments still named 0037: - migrations/0048: the numbering note also claimed product/main owned 0035_task_system and a sibling branch owned 0036. Neither holds -- 0035 is relay_operators, 0036 is relay_admin_actions, task_system is 0046. Replaced with the real reason, which migration.rs:709 already records. - schema/schema.sql:61: brand_color was attributed to "migration 0037", pointing the schema SSOT at an unrelated upstream migration. Comment-only; no DDL change. The three remaining 0037 references in schema.sql (1927/1944/1971) are correct -- they describe the lease migration -- and are untouched. Safe to edit 0048's text: checksum immutability binds migrations already applied by running relays; 0048 is unmerged and has no checksum pin. cargo test -p buzz-db --lib runtime::migration: 14 passed, 0 failed -- including community_brand_color_is_additive_and_mirrored_in_desired_state, which include_str!s both edited files.

mfethe1 · 2026-09-17T23:41:59Z

🧪 Jev PR-Triage (v3)

PR #30: [lenny] integrate REG-10: per-community brand color (NIP-11 buzz_brand_color, migration 0048) — verdict: BLOCK

dimension	metric	value
Correctness	problem resolved	P(yes)=0.70
Correctness	rework needed	0.37/2
Quality	code quality	1.89/2
Quality	test coverage	P(yes)=0.98
Architecture	integration compatibility	2.00/2
Architecture	future proof	1.55/2
Governance	sensitive path	P(yes)=0.99
Governance	size concern	P(yes)=0.95
Synthesis	merge risk	1.87/2
Synthesis	route	needs_review (0.76)
Diff	security exposure	P(yes)=0.17
Diff	performance impact	0.30/2

🔍 Reviewer focus

File: crates/buzz-relay/src/handlers/relay_admin.rs
Concern: security

Block reason (if any): sensitive_path
Pilot: Jev (System One) typed triage, 15 metrics + reviewer focus. Verdict thresholds in code.

mfethe1 added 4 commits August 27, 2026 01:13

[lenny] add: per-tenant brand color on the NIP-11 workspace profile (…

0fa7f41

…REG-10)

[lenny] wire: apply relay brand color in the live theme path (REG-10)

5c30cc9

[claude-loop] harden: brand color after trunk renumber (REG-10)

6e1565f

Signed-off-by: Michael Feth <mfethe1@gmail.com>

mfethe1 and others added 2 commits September 10, 2026 12:00

mfethe1 added 2 commits September 11, 2026 22:55

[lenny] merge product/main; pin 0047+0048 migration inventory

4141029

Trunk landed 0047_agent_machine_homes; this branch keeps 0048_community_brand_color. Both are additive, so the inventory is 47 with 48 last.

Merge remote-tracking branch 'origin/product/main' into integration/r…

60335c1

…eg10-brand-color-run99 # Conflicts: # crates/buzz-db/src/runtime/migration.rs

Navigation Menu

[lenny] integrate REG-10: per-community brand color (NIP-11 buzz_brand_color, migration 0048) - #30

[lenny] integrate REG-10: per-community brand color (NIP-11 buzz_brand_color, migration 0048)#30
mfethe1 wants to merge 10 commits into
product/mainfrom
integration/reg10-brand-color-run99

mfethe1 commented Sep 10, 2026

Uh oh!

coderabbitai Bot commented Sep 10, 2026 •

edited

Loading

Review skipped

Uh oh!

mfethe1 commented Sep 17, 2026

Uh oh!

mfethe1 commented Sep 17, 2026

Uh oh!

mfethe1 commented Sep 17, 2026

Uh oh!

mfethe1 commented Sep 17, 2026

Uh oh!

mfethe1 commented Sep 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

mfethe1 commented Sep 10, 2026

What changed

Merge resolution (feat/REG-10 6e1565f × product/main adeec6e)

Evidence (run 99, 2026-09-10)

Sensitive paths (owner merge required — never self-merge)

UNVERIFIED

Uh oh!

coderabbitai Bot commented Sep 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

mfethe1 commented Sep 17, 2026

🧪 Jev PR-Triage Pilot

Uh oh!

mfethe1 commented Sep 17, 2026

🧪 Jev PR-Triage (v3)

Uh oh!

mfethe1 commented Sep 17, 2026

🧪 Jev PR-Triage (v3)

Uh oh!

mfethe1 commented Sep 17, 2026

🧪 Jev PR-Triage (v3) — ADVISORY, NON-GATING

Uh oh!

mfethe1 commented Sep 17, 2026

🧪 Jev PR-Triage (v3)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Merge resolution (feat/REG-10 `6e1565f` × product/main `adeec6e`)

coderabbitai Bot commented Sep 10, 2026 •

edited

Loading